From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 6/7] net: systemport: Add support for WAKE_FILTER Date: Fri, 20 Jul 2018 00:25:10 +0200 Message-ID: <20180719222510.GG12150@lunn.ch> References: <20180717153645.7500-1-f.fainelli@gmail.com> <20180717153645.7500-8-f.fainelli@gmail.com> <20180717161459.GG968@lunn.ch> <87910e9c-0783-98e9-eb44-ce85656912d8@gmail.com> <20180717164908.GI968@lunn.ch> <20180717170653.GK968@lunn.ch> <1eec25bd-2cc1-3fa7-08b5-fa4ab7c5e777@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linville@tuxdriver.com, davem@davemloft.net, vivien.didelot@savoirfairelinux.com To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:40610 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbeGSXKW (ORCPT ); Thu, 19 Jul 2018 19:10:22 -0400 Content-Disposition: inline In-Reply-To: <1eec25bd-2cc1-3fa7-08b5-fa4ab7c5e777@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: > In both of your examples, only one bit is set, what will change is the > value being programmed to RXHCK_BRCM_TAG(i), which will be either 0, or > 1, but the value programmed to RXCHK_CONTROL as far as which filter is > enabled will be the same because we can use filter position 0. > > What the code basically does is look at how many bits are set in the > filters bitmap, and then it starts populating the filters from filter 0 > up to filter 7 with the value of the bit. O.K. Now it get it. Sorry for being so slow. Andrew