From: Al Viro <viro@ZenIV.linux.org.uk>
To: Theuns Verwoerd <theuns.verwoerd@alliedtelesis.co.nz>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] jffs2: Provide jffs2_sync files to track gc POLL progress
Date: Fri, 20 Jul 2018 01:04:31 +0100 [thread overview]
Message-ID: <20180720000431.GA30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <f1c6c3cc0c8850e143594afd57b50d30cd8bb5f8.1532043059.git.theuns.verwoerd@alliedtelesis.co.nz>
On Fri, Jul 20, 2018 at 11:50:12AM +1200, Theuns Verwoerd wrote:
> +ssize_t jffs2_sync_file_read(struct file *f,
> + char __user *b, size_t len, loff_t *ofs)
> +{
> + struct jffs2_sb_info *c = file_inode(f)->i_private;
> +
> + while (c->tidemark)
> + schedule();
> +
> + return 0;
> +}
Brilliant. So when that gets called with c->tidemark being true and
need_resched() - false, we shall...
Bonus question: what happens if that is called after that jffs2_sb_info
gets freed?
--
It Doesn't Need To Make Sense - It's For Security Purposes.
next prev parent reply other threads:[~2018-07-20 0:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 23:50 [PATCH 0/2] Secure deletion under JFFS2 Theuns Verwoerd
2018-07-19 23:50 ` [PATCH 1/2] jffs2: Provide forced dirty node cleanup via POLL signal Theuns Verwoerd
2018-07-19 23:50 ` [PATCH 2/2] jffs2: Provide jffs2_sync files to track gc POLL progress Theuns Verwoerd
2018-07-20 0:04 ` Al Viro [this message]
2018-07-20 0:54 ` Theuns Verwoerd
2018-07-22 13:17 ` Richard Weinberger
2018-07-22 13:49 ` Al Viro
2018-07-22 22:22 ` Theuns Verwoerd
2018-07-22 19:06 ` [PATCH 0/2] Secure deletion under JFFS2 Richard Weinberger
2018-07-22 22:29 ` Theuns Verwoerd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720000431.GA30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=theuns.verwoerd@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.