From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v3 01/33] mtd: rawnand: brcmnand: convert driver to nand_scan() Date: Fri, 20 Jul 2018 09:12:07 +0200 Message-ID: <20180720091207.7828147d@xps13> References: <20180719230026.8741-1-miquel.raynal@bootlin.com> <20180719230026.8741-2-miquel.raynal@bootlin.com> <20180720011719.7545fbb9@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180720011719.7545fbb9@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Boris Brezillon Cc: Alexandre Belloni , Mans Rullgard , Maxime Ripard , Stefan Agner , linux-kernel@vger.kernel.org, Masahiro Yamada , linux-mtd@lists.infradead.org, Kamal Dasu , Josh Wu , Marc Gonzalez , Marek Vasut , Chen-Yu Tsai , bcm-kernel-feedback-list@broadcom.com, Sylvain Lemieux , Wenyou Yang , Tudor Ambarus , Vladimir Zapolskiy , Harvey Hunt , linux-mediatek@lists.infradead.org, Matthias Brugger , Han Xu , Xiaolei Li , linux-arm-kernel@lists.infradead.org, Richard List-Id: linux-mediatek@lists.infradead.org SGkgQm9yaXMsCgpCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4g d3JvdGUgb24gRnJpLCAyMCBKdWwgMjAxOAowMToxNzoxOSArMDIwMDoKCj4gT24gRnJpLCAyMCBK dWwgMjAxOCAwMDo1OTo1NCArMDIwMAo+IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9v dGxpbi5jb20+IHdyb3RlOgo+IAo+ID4gKwo+ID4gK3N0YXRpYyBzdHJ1Y3QgbmFuZF9jb250cm9s bGVyX29wcyBicmNtbmFuZF9jb250cm9sbGVyX29wcyA9IHsgIAo+IAo+IHN0YXRpYyBjb25zdCAu Li4KCk1tbWggcmlnaHQsIEknbGwgY29uc3RpZnkgZXZlcnkgY29udHJvbGxlcl9vcHMgZGVmaW5p dGlvbi4KCj4gCj4gVGhlIHNhbWUgY29tbWVudCBhcHBsaWVzIHRvIGFsbCBwYXRjaGVzIG9mIHRo aXMgc2VyaWVzLgo+IAo+ID4gKwkuYXR0YWNoX2NoaXAgPSBicmNtbmFuZF9hdHRhY2hfY2hpcCwK PiA+ICt9OyAgCj4gCgoKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 20 Jul 2018 09:12:07 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 01/33] mtd: rawnand: brcmnand: convert driver to nand_scan() Message-ID: <20180720091207.7828147d@xps13> In-Reply-To: <20180720011719.7545fbb9@bbrezillon> References: <20180719230026.8741-1-miquel.raynal@bootlin.com> <20180719230026.8741-2-miquel.raynal@bootlin.com> <20180720011719.7545fbb9@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Boris, Boris Brezillon wrote on Fri, 20 Jul 2018 01:17:19 +0200: > On Fri, 20 Jul 2018 00:59:54 +0200 > Miquel Raynal wrote: >=20 > > + > > +static struct nand_controller_ops brcmnand_controller_ops =3D { =20 >=20 > static const ... Mmmh right, I'll constify every controller_ops definition. >=20 > The same comment applies to all patches of this series. >=20 > > + .attach_chip =3D brcmnand_attach_chip, > > +}; =20 >=20 Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Fri, 20 Jul 2018 09:12:07 +0200 Subject: [PATCH v3 01/33] mtd: rawnand: brcmnand: convert driver to nand_scan() In-Reply-To: <20180720011719.7545fbb9@bbrezillon> References: <20180719230026.8741-1-miquel.raynal@bootlin.com> <20180719230026.8741-2-miquel.raynal@bootlin.com> <20180720011719.7545fbb9@bbrezillon> Message-ID: <20180720091207.7828147d@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Boris, Boris Brezillon wrote on Fri, 20 Jul 2018 01:17:19 +0200: > On Fri, 20 Jul 2018 00:59:54 +0200 > Miquel Raynal wrote: > > > + > > +static struct nand_controller_ops brcmnand_controller_ops = { > > static const ... Mmmh right, I'll constify every controller_ops definition. > > The same comment applies to all patches of this series. > > > + .attach_chip = brcmnand_attach_chip, > > +}; > Miqu?l