From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component Date: Fri, 20 Jul 2018 14:22:58 +0100 Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> References: <20180720075148.14648-1-marcel@ziswiler.com> <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kuninori Morimoto Cc: Kate Stewart , linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Neil Armstrong , Marcel Ziswiler , James Hogan , Takashi Iwai , Thierry Reding , Lee Jones , Robert Jarzmik , Gregory CLEMENT , Russell King , Donglin Peng , Jonathan Hunter , Haojian Zhuang , Boris Brezillon , Mark Brown , linux-tegra@vger.kernel.org, Han Xu , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Bhumika Goyal , Greg Kroah-Hartman , Liam List-Id: alsa-devel@alsa-project.org On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote: > > Hi Marcel > > > From: Marcel Ziswiler > > > > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") > > "wm9712-codec" got renamed to "wm9712-component", however, this change > > never got propagated down to the actual board/platform drivers. E.g. on > > Colibri T20 this lead to the following spew upon boot with sound/touch > > being broken: > > Oops, my bad... > The platform_driver name is not important, > how about simply rename back it to "wm9712-codec" ? > Yeah I would agree here wm9712-component isn't great as a name for board files etc. Lets rename back to wm9712-codec for these specific bits. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 20 Jul 2018 15:23:37 +0200 (CEST) Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:54562 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23993256AbeGTNXeHjwPG (ORCPT ); Fri, 20 Jul 2018 15:23:34 +0200 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6KDIxZK009824; Fri, 20 Jul 2018 08:23:03 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail3.cirrus.com ([87.246.76.56]) by mx0a-001ae601.pphosted.com with ESMTP id 2kbg2301br-1; Fri, 20 Jul 2018 08:23:03 -0500 Received: from EX17.ad.cirrus.com (ex17.ad.cirrus.com [172.20.9.81]) by mail3.cirrus.com (Postfix) with ESMTP id 8E608611CE60; Fri, 20 Jul 2018 08:24:13 -0500 (CDT) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.301.0; Fri, 20 Jul 2018 14:23:02 +0100 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id w6KDMwCn011246; Fri, 20 Jul 2018 14:22:58 +0100 Date: Fri, 20 Jul 2018 14:22:58 +0100 From: Charles Keepax To: Kuninori Morimoto CC: Marcel Ziswiler , , , Mark Brown , "Marcel Ziswiler" , , Gregory CLEMENT , Haojian Zhuang , James Hogan , "Philippe Ombredanne" , Bhumika Goyal , Kate Stewart , Greg Kroah-Hartman , Ralf Baechle , "Thierry Reding" , Jonathan Hunter , Takashi Iwai , Paul Burton , "Liam Girdwood" , Lee Jones , "Daniel Mack" , Manuel Lauss , Russell King , , "Jaroslav Kysela" , Robert Jarzmik , , , Han Xu , Donglin Peng , Neil Armstrong , Boris Brezillon Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> References: <20180720075148.14648-1-marcel@ziswiler.com> <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=495 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807200152 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 64986 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ckeepax@opensource.cirrus.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote: > > Hi Marcel > > > From: Marcel Ziswiler > > > > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") > > "wm9712-codec" got renamed to "wm9712-component", however, this change > > never got propagated down to the actual board/platform drivers. E.g. on > > Colibri T20 this lead to the following spew upon boot with sound/touch > > being broken: > > Oops, my bad... > The platform_driver name is not important, > how about simply rename back it to "wm9712-codec" ? > Yeah I would agree here wm9712-component isn't great as a name for board files etc. Lets rename back to wm9712-codec for these specific bits. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:54562 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23993256AbeGTNXeHjwPG (ORCPT ); Fri, 20 Jul 2018 15:23:34 +0200 Date: Fri, 20 Jul 2018 14:22:58 +0100 From: Charles Keepax Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> References: <20180720075148.14648-1-marcel@ziswiler.com> <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Kuninori Morimoto Cc: Marcel Ziswiler , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, Mark Brown , Marcel Ziswiler , linux-mips@linux-mips.org, Gregory CLEMENT , Haojian Zhuang , James Hogan , Philippe Ombredanne , Bhumika Goyal , Kate Stewart , Greg Kroah-Hartman , Ralf Baechle , Thierry Reding , Jonathan Hunter , Takashi Iwai , Paul Burton , Liam Girdwood , Lee Jones , Daniel Mack , Manuel Lauss , Russell King , linux-arm-kernel@lists.infradead.org, Jaroslav Kysela , Robert Jarzmik , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Han Xu , Donglin Peng , Neil Armstrong , Boris Brezillon Message-ID: <20180720132258.BiDDHoH3IvldNJXx68otvBV_CslVDD2ES2PrnbNYVy8@z> On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote: > > Hi Marcel > > > From: Marcel Ziswiler > > > > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") > > "wm9712-codec" got renamed to "wm9712-component", however, this change > > never got propagated down to the actual board/platform drivers. E.g. on > > Colibri T20 this lead to the following spew upon boot with sound/touch > > being broken: > > Oops, my bad... > The platform_driver name is not important, > how about simply rename back it to "wm9712-codec" ? > Yeah I would agree here wm9712-component isn't great as a name for board files etc. Lets rename back to wm9712-codec for these specific bits. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: ckeepax@opensource.cirrus.com (Charles Keepax) Date: Fri, 20 Jul 2018 14:22:58 +0100 Subject: [PATCH] ASoC: wm9712: fix replace codec to component In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> References: <20180720075148.14648-1-marcel@ziswiler.com> <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote: > > Hi Marcel > > > From: Marcel Ziswiler > > > > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") > > "wm9712-codec" got renamed to "wm9712-component", however, this change > > never got propagated down to the actual board/platform drivers. E.g. on > > Colibri T20 this lead to the following spew upon boot with sound/touch > > being broken: > > Oops, my bad... > The platform_driver name is not important, > how about simply rename back it to "wm9712-codec" ? > Yeah I would agree here wm9712-component isn't great as a name for board files etc. Lets rename back to wm9712-codec for these specific bits. Thanks, Charles