From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RESEND] drm/i915: Interactive RPS mode
Date: Fri, 20 Jul 2018 17:19:20 +0300 [thread overview]
Message-ID: <20180720141920.GQ5565@intel.com> (raw)
In-Reply-To: <153209538981.26154.18058391045817491033@skylake-alporthouse-com>
On Fri, Jul 20, 2018 at 03:03:09PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-07-20 14:50:25)
> > On Fri, Jul 20, 2018 at 02:38:32PM +0100, Chris Wilson wrote:
> > > Quoting Ville Syrjälä (2018-07-20 14:32:40)
> > > > Another question is what happens where there are parallel flips
> > > > happening? One could undo the boost from the other AFAICS. But maybe
> > > > we don't care enough to protect against that?
> > >
> > > It's a counter, so the "interactive" mode remains high until all
> > > concurrent flips are completed.
> >
> > Ah. I guess the bool in the atomic state threw me off. I suppose that
> > one is just an optimization to avoid calling the function more than
> > once?
>
> Yes, it's that I caught the RPS counter going negative. We have more
> cleanup_plane than we prepared.... I believe that's from
> find_initial_plane.
Hmm. I don't quite see how that could happen. I believe
prepare_fb/cleanup_fb should be fully paired up within a single commit.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-20 14:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 21:01 [PATCH] drm/i915: Interactive RPS mode Chris Wilson
2018-07-11 22:06 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-07-11 22:07 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-07-11 22:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-07-12 7:50 ` [PATCH v3] " Chris Wilson
2018-07-12 8:02 ` [PATCH v4] " Chris Wilson
2018-07-12 17:38 ` [RESEND] " Chris Wilson
2018-07-20 12:49 ` Tvrtko Ursulin
2018-07-20 13:02 ` Chris Wilson
2018-07-20 13:07 ` Ville Syrjälä
2018-07-20 13:14 ` Chris Wilson
2018-07-20 13:32 ` Ville Syrjälä
2018-07-20 13:38 ` Chris Wilson
2018-07-20 13:50 ` Ville Syrjälä
2018-07-20 14:03 ` Chris Wilson
2018-07-20 14:19 ` Ville Syrjälä [this message]
2018-07-21 8:44 ` Chris Wilson
2018-07-20 13:29 ` Tvrtko Ursulin
2018-07-20 13:59 ` Chris Wilson
2018-07-20 14:58 ` Tvrtko Ursulin
2018-07-20 15:01 ` Chris Wilson
2018-07-12 17:58 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Interactive RPS mode (rev4) Patchwork
2018-07-12 17:59 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-07-12 18:15 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-23 10:01 ` [PATCH] drm/i915: Interactive RPS mode Chris Wilson
2018-07-31 13:01 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720141920.GQ5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.