From: Sam Protsenko <semen.protsenko@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] disk: part: Don't show redundant error message
Date: Fri, 20 Jul 2018 18:18:56 +0300 [thread overview]
Message-ID: <20180720151856.23458-3-semen.protsenko@linaro.org> (raw)
In-Reply-To: <20180720151856.23458-1-semen.protsenko@linaro.org>
Underlying API should already print some meaningful error message, so
this one is just brings more noise. E.g. we can see log like this:
MMC: no card present
** Bad device mmc 0 **
Obviously, second error message is unwanted. Let's only print it in case
when DEBUG is defined to keep log short and clear.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
Changes in v2:
- Instead of removing error message, print it with debug()
disk/part.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disk/part.c b/disk/part.c
index 9266a09ec3..9e457a6e72 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -400,7 +400,7 @@ int blk_get_device_by_str(const char *ifname, const char *dev_hwpart_str,
*dev_desc = get_dev_hwpart(ifname, dev, hwpart);
if (!(*dev_desc) || ((*dev_desc)->type == DEV_TYPE_UNKNOWN)) {
- printf("** Bad device %s %s **\n", ifname, dev_hwpart_str);
+ debug("** Bad device %s %s **\n", ifname, dev_hwpart_str);
dev = -ENOENT;
goto cleanup;
}
--
2.18.0
next prev parent reply other threads:[~2018-07-20 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 15:18 [U-Boot] [PATCH v2 0/2] env: Make environment loading log more clear Sam Protsenko
2018-07-20 15:18 ` [U-Boot] [PATCH v2 1/2] env: Don't print "Failed" error message Sam Protsenko
2018-07-20 15:18 ` Sam Protsenko [this message]
2018-07-23 23:48 ` [U-Boot] [PATCH v2 2/2] disk: part: Don't show redundant " Simon Glass
2018-07-24 16:42 ` [U-Boot] [PATCH v2 0/2] env: Make environment loading log more clear Sam Protsenko
2018-07-26 13:28 ` Wolfgang Denk
2018-07-30 16:06 ` Sam Protsenko
2018-07-25 11:05 ` Yaniv Levinsky
2018-07-30 15:52 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720151856.23458-3-semen.protsenko@linaro.org \
--to=semen.protsenko@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.