From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 20 Jul 2018 15:54:49 -0400 Subject: [U-Boot] [U-Boot,V3,1/2] spl: Fix redundant image of uboot In-Reply-To: <20180706150920.GA30520@panicking> References: <20180706150920.GA30520@panicking> Message-ID: <20180720195449.GT11755@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jul 06, 2018 at 05:09:22PM +0200, Michael Trimarchi wrote: > We need to address the redundat image case and undestand if the > image is corrupted or not. In error case we need to try the fallback copy. > The function used before was always return 0 without any evaluation of the > error. We try to make it work properly > > Signed-off-by: Michael Trimarchi > --- > Changes V2->V3: > Fix patch mistake due the a wrong edit of it > Changes V1->V2: > Address the comments on using the err variable > --- > common/spl/spl_nand.c | 34 +++++++++++++++++++++++++--------- > 1 file changed, 25 insertions(+), 9 deletions(-) I see two problems here. First, this is a generic issue (any legacy-style U-Boot image that we load should be verified). Second, we need to make this behavior configurable as as-is this overflows one board (omapl138_lcdk) and I expect would be problematic for many more boards when we make it done more commonly. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: