From: Eugene Korenevsky <ekorenevsky@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: [PATCH] genhd: register_disk: inform about dev_set_name() failure
Date: Sun, 22 Jul 2018 01:28:49 +0300 [thread overview]
Message-ID: <20180721222849.GA23331@vnote> (raw)
Although dev_set_name() failure is not fatal, it is better to print
a warning message into dmesg about it.
Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
---
block/genhd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/genhd.c b/block/genhd.c
index f1543a45e73b..071f8cbd529a 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -577,7 +577,9 @@ static void register_disk(struct device *parent, struct gendisk *disk)
ddev->parent = parent;
- dev_set_name(ddev, "%s", disk->disk_name);
+ err = dev_set_name(ddev, "%s", disk->disk_name);
+ if (err)
+ pr_warn("%s: cannot set disk name: %d", __func__, err);
/* delay uevents, until we scanned partition table */
dev_set_uevent_suppress(ddev, 1);
--
2.18.0
reply other threads:[~2018-07-21 22:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721222849.GA23331@vnote \
--to=ekorenevsky@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.