From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: adilger.kernel@dilger.ca, jack@suse.cz,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
sirmy15@gmail.com, stable@vger.kernel.org,
tgnottingham@gmail.com, y2038@lists.linaro.org
Subject: Re: [PATCH v2 1/6] ext4: sysfs: print ext4_super_block fields as little-endian
Date: Sun, 22 Jul 2018 13:23:20 -0400 [thread overview]
Message-ID: <20180722172320.GB6685@thunk.org> (raw)
In-Reply-To: <20180711091414.1494843-1-arnd@arndb.de>
On Wed, Jul 11, 2018 at 11:14:09AM +0200, Arnd Bergmann wrote:
> While working on extended rand for last_error/first_error timestamps,
> I noticed that the endianess is wrong, we access the little-endian
> fields in struct ext4_super_block as native-endian when we print them.
>
> This adds a special case in ext4_attr_show() and ext4_attr_store()
> to byteswap the superblock fields if needed.
>
> In older kernels, this code was part of super.c, it got moved to sysfs.c
> in linux-4.4.
>
> Cc: stable@vger.kernel.org
> Fixes: 52c198c6820f ("ext4: add sysfs entry showing whether the fs contains errors")
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
- Ted
prev parent reply other threads:[~2018-07-22 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 9:14 [PATCH v2 1/6] ext4: sysfs: print ext4_super_block fields as little-endian Arnd Bergmann
2018-07-11 9:14 ` [PATCH v2 2/6] ext4: use 64-bit timestamps for mmp_time Arnd Bergmann
2018-07-22 18:06 ` Theodore Y. Ts'o
2018-07-11 9:14 ` [PATCH v2 3/6] ext4: use ktime_get_real_seconds for i_dtime Arnd Bergmann
2018-07-22 18:07 ` Theodore Y. Ts'o
2018-07-11 9:14 ` [PATCH v2 4/6] ext4: use timespec64 for all inode times Arnd Bergmann
2018-07-22 18:08 ` Theodore Y. Ts'o
2018-07-11 9:14 ` [PATCH v2 5/6] jbd2: replace current_kernel_time64 with ktime equivalent Arnd Bergmann
2018-07-22 18:54 ` Theodore Y. Ts'o
2018-07-11 9:14 ` [PATCH v2 6/6] ext4: super: extend timestamps to 40 bits Arnd Bergmann
2018-07-22 18:55 ` Theodore Y. Ts'o
2018-07-22 17:23 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180722172320.GB6685@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sirmy15@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tgnottingham@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.