diff for duplicates of <20180723054337.GA29207@fergus> diff --git a/a/1.txt b/N1/1.txt index 23dbf2a..fdbf0ac 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -43,9 +43,9 @@ I have some comments relating to the situation where the stride > + const int block_offsets[MAX_SMT_THREADS] = {0, 4, 2, 6, 1, 3, 5, 7}; This needs to be {0, 4, 2, 6, 1, 5, 3, 7} (with the 3 and 5 swapped -from what you have) for the case when stride = 4 and block = 3. In +from what you have) for the case when stride == 4 and block == 3. In that case we need block_offsets[block] to be 3; if it is 5, then we -will collide with the case where block = 2 for the next virtual core. +will collide with the case where block == 2 for the next virtual core. > + int stride = kvm->arch.emul_smt_mode; > + int block = (id / KVM_MAX_VCPUS) * (MAX_SMT_THREADS / stride); diff --git a/a/content_digest b/N1/content_digest index c5889ec..c1a38f0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,13 @@ "ref\01fb3aea5f44f1029866ee10db40abde7e18b24ad.1531967105.git.sbobroff@linux.ibm.com\0" "From\0Paul Mackerras <paulus@ozlabs.org>\0" "Subject\0Re: [PATCH v3 1/1] KVM: PPC: Book3S HV: pack VCORE IDs to access full VCPU ID space\0" - "Date\0Mon, 23 Jul 2018 05:43:37 +0000\0" + "Date\0Mon, 23 Jul 2018 15:43:37 +1000\0" "To\0Sam Bobroff <sbobroff@linux.ibm.com>\0" - "Cc\0clg@kaod.org" - linuxppc-dev@lists.ozlabs.org - kvm-ppc@vger.kernel.org + "Cc\0linuxppc-dev@lists.ozlabs.org" kvm@vger.kernel.org - " david@gibson.dropbear.id.au\0" + kvm-ppc@vger.kernel.org + david@gibson.dropbear.id.au + " clg@kaod.org\0" "\00:1\0" "b\0" "On Thu, Jul 19, 2018 at 12:25:10PM +1000, Sam Bobroff wrote:\n" @@ -55,9 +55,9 @@ "> +\tconst int block_offsets[MAX_SMT_THREADS] = {0, 4, 2, 6, 1, 3, 5, 7};\n" "\n" "This needs to be {0, 4, 2, 6, 1, 5, 3, 7} (with the 3 and 5 swapped\n" - "from what you have) for the case when stride = 4 and block = 3. In\n" + "from what you have) for the case when stride == 4 and block == 3. In\n" "that case we need block_offsets[block] to be 3; if it is 5, then we\n" - "will collide with the case where block = 2 for the next virtual core.\n" + "will collide with the case where block == 2 for the next virtual core.\n" "\n" "> +\tint stride = kvm->arch.emul_smt_mode;\n" "> +\tint block = (id / KVM_MAX_VCPUS) * (MAX_SMT_THREADS / stride);\n" @@ -121,4 +121,4 @@ "\n" Paul. -49a56d212891520a0bdec5fdfcc62e3ec0818c9fc0f4af01e243627d49af566c +d935085dc8f3d85e617214055223f98f0d03c21045e1dba0955b5d2b296460c5
diff --git a/a/1.txt b/N2/1.txt index 23dbf2a..fdbf0ac 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -43,9 +43,9 @@ I have some comments relating to the situation where the stride > + const int block_offsets[MAX_SMT_THREADS] = {0, 4, 2, 6, 1, 3, 5, 7}; This needs to be {0, 4, 2, 6, 1, 5, 3, 7} (with the 3 and 5 swapped -from what you have) for the case when stride = 4 and block = 3. In +from what you have) for the case when stride == 4 and block == 3. In that case we need block_offsets[block] to be 3; if it is 5, then we -will collide with the case where block = 2 for the next virtual core. +will collide with the case where block == 2 for the next virtual core. > + int stride = kvm->arch.emul_smt_mode; > + int block = (id / KVM_MAX_VCPUS) * (MAX_SMT_THREADS / stride); diff --git a/a/content_digest b/N2/content_digest index c5889ec..78b390a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,7 +1,7 @@ "ref\01fb3aea5f44f1029866ee10db40abde7e18b24ad.1531967105.git.sbobroff@linux.ibm.com\0" "From\0Paul Mackerras <paulus@ozlabs.org>\0" "Subject\0Re: [PATCH v3 1/1] KVM: PPC: Book3S HV: pack VCORE IDs to access full VCPU ID space\0" - "Date\0Mon, 23 Jul 2018 05:43:37 +0000\0" + "Date\0Mon, 23 Jul 2018 15:43:37 +1000\0" "To\0Sam Bobroff <sbobroff@linux.ibm.com>\0" "Cc\0clg@kaod.org" linuxppc-dev@lists.ozlabs.org @@ -55,9 +55,9 @@ "> +\tconst int block_offsets[MAX_SMT_THREADS] = {0, 4, 2, 6, 1, 3, 5, 7};\n" "\n" "This needs to be {0, 4, 2, 6, 1, 5, 3, 7} (with the 3 and 5 swapped\n" - "from what you have) for the case when stride = 4 and block = 3. In\n" + "from what you have) for the case when stride == 4 and block == 3. In\n" "that case we need block_offsets[block] to be 3; if it is 5, then we\n" - "will collide with the case where block = 2 for the next virtual core.\n" + "will collide with the case where block == 2 for the next virtual core.\n" "\n" "> +\tint stride = kvm->arch.emul_smt_mode;\n" "> +\tint block = (id / KVM_MAX_VCPUS) * (MAX_SMT_THREADS / stride);\n" @@ -121,4 +121,4 @@ "\n" Paul. -49a56d212891520a0bdec5fdfcc62e3ec0818c9fc0f4af01e243627d49af566c +26d55e3e57fd31835113f6e17c87aa7c4e77a658d5ec04bf377a2102256d6a08
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.