From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47BFCECDE5F for ; Mon, 23 Jul 2018 09:31:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F150820854 for ; Mon, 23 Jul 2018 09:31:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jJNi1Hp8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F150820854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388239AbeGWKbm (ORCPT ); Mon, 23 Jul 2018 06:31:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:36540 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388161AbeGWKbl (ORCPT ); Mon, 23 Jul 2018 06:31:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=unHuIceXlVWheWta3ePHv8sGyf+Ptb68KDdWomTuEGw=; b=jJNi1Hp8pltnOrP/RZ9dZdq8yu vIzqXXpSkfujvKWcHw+R2LZdX4g8gdVMFat3SjqMh8eWAwouwqOLq4RHpaHnb0iQzHGJxJFJlgxeI RAMUvyPrg28DnXizj5PxUWcC5xkTqo3CTcCCyYKUGMptO9J+8+uYm2udrcrhHD7rneyHzp62M4bQE IkNlfC4pT4fCyQ7huby6NlFQJjMnnLhvxZtvocXfTG7C/SIhHh/Ht2hHFpzUtKFiRS2ixKErqbPdE DrD3JrPJSLB0kVF0SAOabu2KP5a6uNpUzreaG1aOXvDRyF8o1bKlnsyg1Rk+ZU1847TZUHbpc7FF2 uznyZuqw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fhXBb-0005Ki-59; Mon, 23 Jul 2018 09:31:23 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A393D20275F4B; Mon, 23 Jul 2018 11:31:21 +0200 (CEST) Date: Mon, 23 Jul 2018 11:31:21 +0200 From: Peter Zijlstra To: =?utf-8?B?546L6LSH?= Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tg: show the sum wait time of an task group Message-ID: <20180723093121.GA2494@hirez.programming.kicks-ass.net> References: <5c4c978d-e8fb-4bcb-b942-3c6d3dcfc13e@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 04, 2018 at 11:27:27AM +0800, 王贇 wrote: > @@ -6788,6 +6790,12 @@ static int cpu_cfs_stat_show(struct seq_file *sf, void *v) > seq_printf(sf, "nr_throttled %d\n", cfs_b->nr_throttled); > seq_printf(sf, "throttled_time %llu\n", cfs_b->throttled_time); > > + if (schedstat_enabled() && tg != &root_task_group) { I put the variables here. > + for_each_possible_cpu(i) > + ws += schedstat_val(tg->se[i]->statistics.wait_sum); This doesn't quite work on 32bit archs, but I'm not sure I care enough to be bothered about that. > + seq_printf(sf, "wait_sum %llu\n", ws); > + }