From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/5] misc: rtsx_usb: Use USB remote wakeup signaling for card insertion detection From: Kai-Heng Feng Message-Id: <20180723102744.15140-2-kai.heng.feng@canonical.com> Date: Mon, 23 Jul 2018 18:27:40 +0800 To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: ulf.hansson@linaro.org, stern@rowland.harvard.edu, bauer.chen@realtek.com, ricky_wu@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Kai-Heng Feng List-ID: QWx0aG91Z2ggcnRzeF91c2IgZG9lc24ndCBzdXBwb3J0IGNhcmQgcmVtb3ZhbCBkZXRlY3Rpb24s IGNhcmQgaW5zZXJ0aW9uCndpbGwgcmVzdW1lIHJ0c3hfdXNiIGJ5IFVTQiByZW1vdGUgd2FrZXVw IHNpZ25hbGluZy4KCldoZW4gcnRzeF91c2IgZ2V0cyByZXN1bWVkLCBhbHNvIHJlc3VtZXMgaXRz IGNoaWxkIGRldmljZXMsCnJ0c3hfdXNiX3NkbW1jIGFuZCBydHN4X3VzYl9tcywgdG8gbm90aWZ5 IHRoZW0gdGhlcmUncyBhIGNhcmQgaW4gaXRzCnNsb3QuCgpTaWduZWQtb2ZmLWJ5OiBLYWktSGVu ZyBGZW5nIDxrYWkuaGVuZy5mZW5nQGNhbm9uaWNhbC5jb20+Ci0tLQogZHJpdmVycy9taXNjL2Nh cmRyZWFkZXIvcnRzeF91c2IuYyB8IDEzICsrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAx MyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9taXNjL2NhcmRyZWFkZXIvcnRz eF91c2IuYyBiL2RyaXZlcnMvbWlzYy9jYXJkcmVhZGVyL3J0c3hfdXNiLmMKaW5kZXggYjk3OTAz ZmYxYTcyLi5mZWQ4MzQ1M2U1YzUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbWlzYy9jYXJkcmVhZGVy L3J0c3hfdXNiLmMKKysrIGIvZHJpdmVycy9taXNjL2NhcmRyZWFkZXIvcnRzeF91c2IuYwpAQCAt NzIzLDggKzcyMywyMCBAQCBzdGF0aWMgaW50IHJ0c3hfdXNiX3N1c3BlbmQoc3RydWN0IHVzYl9p bnRlcmZhY2UgKmludGYsIHBtX21lc3NhZ2VfdCBtZXNzYWdlKQogCXJldHVybiAwOwogfQogCitz dGF0aWMgaW50IHJ0c3hfdXNiX3Jlc3VtZV9jaGlsZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHZvaWQg KmRhdGEpCit7CisJLyogTm8gbmVlZCB0byB3YWtlIHVwIHNlbGYgYWdhaW4gKi8KKwlpZiAoZGV2 ID09IGRhdGEpCisJCXJldHVybiAwOworCisJZGV2X2RiZyhkZXYsICIlcyBjYWxsZWRcbiIsIF9f ZnVuY19fKTsKKwlwbV9yZXF1ZXN0X3Jlc3VtZShkZXYpOworCXJldHVybiAwOworfQorCiBzdGF0 aWMgaW50IHJ0c3hfdXNiX3Jlc3VtZShzdHJ1Y3QgdXNiX2ludGVyZmFjZSAqaW50ZikKIHsKKwlk ZXZpY2VfZm9yX2VhY2hfY2hpbGQoJmludGYtPmRldiwgJmludGYtPmRldiwgcnRzeF91c2JfcmVz dW1lX2NoaWxkKTsKIAlyZXR1cm4gMDsKIH0KIApAQCAtNzM0LDYgKzc0Niw3IEBAIHN0YXRpYyBp bnQgcnRzeF91c2JfcmVzZXRfcmVzdW1lKHN0cnVjdCB1c2JfaW50ZXJmYWNlICppbnRmKQogCQko c3RydWN0IHJ0c3hfdWNyICopdXNiX2dldF9pbnRmZGF0YShpbnRmKTsKIAogCXJ0c3hfdXNiX3Jl c2V0X2NoaXAodWNyKTsKKwlkZXZpY2VfZm9yX2VhY2hfY2hpbGQoJmludGYtPmRldiwgJmludGYt PmRldiwgcnRzeF91c2JfcmVzdW1lX2NoaWxkKTsKIAlyZXR1cm4gMDsKIH0KIAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848F5ECDFB8 for ; Mon, 23 Jul 2018 10:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41DDF20846 for ; Mon, 23 Jul 2018 10:28:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41DDF20846 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388254AbeGWL23 (ORCPT ); Mon, 23 Jul 2018 07:28:29 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38515 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388059AbeGWL23 (ORCPT ); Mon, 23 Jul 2018 07:28:29 -0400 Received: from 1-161-144-158.dynamic-ip.hinet.net ([1.161.144.158] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fhY4J-0002TB-4e; Mon, 23 Jul 2018 10:27:55 +0000 From: Kai-Heng Feng To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: ulf.hansson@linaro.org, stern@rowland.harvard.edu, bauer.chen@realtek.com, ricky_wu@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Kai-Heng Feng Subject: [PATCH 1/5] misc: rtsx_usb: Use USB remote wakeup signaling for card insertion detection Date: Mon, 23 Jul 2018 18:27:40 +0800 Message-Id: <20180723102744.15140-2-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723102744.15140-1-kai.heng.feng@canonical.com> References: <20180723102744.15140-1-kai.heng.feng@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Although rtsx_usb doesn't support card removal detection, card insertion will resume rtsx_usb by USB remote wakeup signaling. When rtsx_usb gets resumed, also resumes its child devices, rtsx_usb_sdmmc and rtsx_usb_ms, to notify them there's a card in its slot. Signed-off-by: Kai-Heng Feng --- drivers/misc/cardreader/rtsx_usb.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/misc/cardreader/rtsx_usb.c b/drivers/misc/cardreader/rtsx_usb.c index b97903ff1a72..fed83453e5c5 100644 --- a/drivers/misc/cardreader/rtsx_usb.c +++ b/drivers/misc/cardreader/rtsx_usb.c @@ -723,8 +723,20 @@ static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message) return 0; } +static int rtsx_usb_resume_child(struct device *dev, void *data) +{ + /* No need to wake up self again */ + if (dev == data) + return 0; + + dev_dbg(dev, "%s called\n", __func__); + pm_request_resume(dev); + return 0; +} + static int rtsx_usb_resume(struct usb_interface *intf) { + device_for_each_child(&intf->dev, &intf->dev, rtsx_usb_resume_child); return 0; } @@ -734,6 +746,7 @@ static int rtsx_usb_reset_resume(struct usb_interface *intf) (struct rtsx_ucr *)usb_get_intfdata(intf); rtsx_usb_reset_chip(ucr); + device_for_each_child(&intf->dev, &intf->dev, rtsx_usb_resume_child); return 0; } -- 2.17.1