From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y Date: Mon, 23 Jul 2018 13:26:24 +0200 Message-ID: <20180723112624.GA29710@kroah.com> References: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fhYyz-0000oS-FF for xen-devel@lists.xenproject.org; Mon, 23 Jul 2018 11:26:29 +0000 Content-Disposition: inline In-Reply-To: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "Srivatsa S. Bhat" Cc: Dave Hansen , Wanpeng Li , ak@linux.intel.com, linux-tip-commits@vger.kernel.org, Piotr Luc , Mel Gorman , arjan.van.de.ven@intel.com, xen-devel@lists.xenproject.org, Alexander Sergeyev , Brian Gerst , Andy Lutomirski , =?iso-8859-1?Q?Micka=EBlSala=FCn?= , Thomas Gleixner , Joe Konno , Laura Abbott , Will Drewry , Jiri Kosina , linux-kernel@vger.kernel.org, Jia Zhang , Andrew Morton , torvalds@linux-foundation.org, dwmw@amazon.co.uk, karahmed@amazon.de, dave.hansen@linux.intel.com, linux@dominikbrodowski.net, Bo Gan , Andrey Ryabinin List-Id: xen-devel@lists.xenproject.org T24gU2F0LCBKdWwgMTQsIDIwMTggYXQgMDI6MjU6NDNBTSAtMDcwMCwgU3JpdmF0c2EgUy4gQmhh dCB3cm90ZToKPiBIaSBHcmVnLAo+IAo+IFRoaXMgcGF0Y2ggc2VyaWVzIGlzIGEgYmFja3BvcnQg b2YgdGhlIFNwZWN0cmUtdjIgZml4ZXMgKElCUEIvSUJSUykKPiBhbmQgcGF0Y2hlcyBmb3IgdGhl IFNwZWN1bGF0aXZlIFN0b3JlIEJ5cGFzcyB2dWxuZXJhYmlsaXR5IHRvIDQuNC55Cj4gKHRoZXkg YXBwbHkgY2xlYW5seSBvbiB0b3Agb2YgNC40LjE0MCkuCj4gCj4gSSB1c2VkIDQuOS55IGFzIG15 IHJlZmVyZW5jZSB3aGVuIGJhY2twb3J0aW5nIHRvIDQuNC55IChhcyBJIHRob3VnaHQKPiB0aGF0 IHdvdWxkIG1pbmltaXplIHRoZSBhbW91bnQgb2YgZml4aW5nIHVwIG5lY2Vzc2FyeSkuIFVuZm9y dHVuYXRlbHkKPiBJIGhhZCB0byBza2lwIHRoZSBLVk0gZml4ZXMgZm9yIHRoZXNlIHZ1bG5lcmFi aWxpdGllcywgYXMgdGhlIEtWTQo+IGNvZGViYXNlIGlzIGRyYXN0aWNhbGx5IGRpZmZlcmVudCBp biA0LjQgYXMgY29tcGFyZWQgdG8gNC45LiAoSSB0cmllZAo+IG15IGJlc3QgdG8gYmFja3BvcnQg dGhlbSBpbml0aWFsbHksIGJ1dCB3YXNuJ3QgY29uZmlkZW50IHRoYXQgdGhleQo+IHdlcmUgY29y cmVjdCwgc28gSSBkZWNpZGVkIHRvIGRyb3AgdGhlbSBmcm9tIHRoaXMgc2VyaWVzKS4KPiAKPiBZ b3UnbGwgbm90aWNlIHRoYXQgdGhlIGluaXRpYWwgZmV3IHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMg aW5jbHVkZQo+IGNsZWFudXBzIGV0Yy4sIHRoYXQgYXJlIG5vbi1jcml0aWNhbCB0byBJQlBCL0lC UlMvU1NCRC4gTW9zdCBvZiB0aGVzZQo+IHBhdGNoZXMgYXJlIGFpbWVkIGF0IGdldHRpbmcgdGhl IGNwdWZlYXR1cmUuaCB2cyBjcHVmZWF0dXJlcy5oIHNwbGl0Cj4gaW50byA0LjQsIHNpbmNlIGEg bG90IG9mIHRoZSBzdWJzZXF1ZW50IHBhdGNoZXMgdXBkYXRlIHRoZXNlIGhlYWRlcnMuCj4gT24g bXkgZmlyc3QgYXR0ZW1wdCB0byBiYWNrcG9ydCB0aGVzZSBwYXRjaGVzIHRvIDQuNC55LCBJIGhh ZCBhY3R1YWxseQo+IHRyaWVkIHRvIGRvIGFsbCB0aGUgdXBkYXRlcyBvbiB0aGUgY3B1ZmVhdHVy ZS5oIGZpbGUgaXRzZWxmLCBidXQgaXQKPiBzdGFydGVkIGdldHRpbmcgdmVyeSBjdW1iZXJzb21l LCBzbyBJIHJlc29ydGVkIHRvIGJhY2twb3J0aW5nIHRoZQo+IGNwdWZlYXR1cmUuaCB2cyBjcHVm ZWF0dXJlcy5oIHNwbGl0IGFuZCB0aGVpciBkZXBlbmRlbmNpZXMgYXMgd2VsbC4gSQo+IHRoaW5r IGFwYXJ0IGZyb20gdGhlc2UgaW5pdGlhbCBwYXRjaGVzLCB0aGUgcmVzdCBvZiB0aGUgcGF0Y2hz ZXQKPiBkb2Vzbid0IGhhdmUgYWxsIHRoYXQgbXVjaCBub2lzZS4gCj4gCj4gVGhpcyBwYXRjaHNl dCBoYXMgYmVlbiB0ZXN0ZWQgb24gYm90aCBJbnRlbCBhbmQgQU1EIG1hY2hpbmVzIChJbnRlbAo+ IFhlb24gQ1BVIEU1LTI2NjAgdjQgYW5kIEFNRCBFUFlDIDcyODEgMTYtQ29yZSBQcm9jZXNzb3Is IHJlc3BlY3RpdmVseSkKPiB3aXRoIHVwZGF0ZWQgbWljcm9jb2RlLiBBbGwgdGhlIHBhdGNoIGJh Y2twb3J0cyBoYXZlIGJlZW4KPiBpbmRlcGVuZGVudGx5IHJldmlld2VkIGJ5IE1hdHQgSGVsc2xl eSwgQWxleGV5IE1ha2hhbG92IGFuZCBCbyBHYW4uCj4gCj4gSSB3b3VsZCBhcHByZWNpYXRlIGlm IHlvdSBjb3VsZCBraW5kbHkgY29uc2lkZXIgdGhlc2UgcGF0Y2hlcyBmb3IKPiByZXZpZXcgYW5k IGluY2x1c2lvbiBpbiBhIGZ1dHVyZSA0LjQueSByZWxlYXNlLgoKR2l2ZW4gbm8gb25lIGhhcyBj b21wbGFpbmVkIGFib3V0IHRoZXNlIHlldCwgSSd2ZSBxdWV1ZWQgdGhlbSBhbGwgdXAsCmluY2x1 ZGluZyB0aGUgMiBleHRyYSBvbmVzIHlvdSBzZW50IGFmdGVyd2FyZC4KCkxldCdzIHNlZSB3aGF0 IGJyZWFrcyA6KQoKdGhhbmtzLAoKZ3JlZyBrLWgKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9s aXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by kanga.kvack.org (Postfix) with ESMTP id 549AB6B026B for ; Mon, 23 Jul 2018 07:26:29 -0400 (EDT) Received: by mail-pg1-f197.google.com with SMTP id h5-v6so148503pgs.13 for ; Mon, 23 Jul 2018 04:26:29 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id h89-v6si7976997pld.378.2018.07.23.04.26.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 04:26:28 -0700 (PDT) Date: Mon, 23 Jul 2018 13:26:24 +0200 From: Greg KH Subject: Re: [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y Message-ID: <20180723112624.GA29710@kroah.com> References: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> Sender: owner-linux-mm@kvack.org List-ID: To: "Srivatsa S. Bhat" Cc: stable@vger.kernel.org, Denys Vlasenko , Bo Gan , Konrad Rzeszutek Wilk , Borislav Petkov , Thomas Gleixner , Ricardo Neri , Tom Lendacky , ak@linux.intel.com, linux-tip-commits@vger.kernel.org, Jia Zhang , Josh Poimboeuf , xen-devel@lists.xenproject.org, =?utf-8?B?S3LEjW3DocWZ?= , Peter Zijlstra , Andy Lutomirski , Arnaldo Carvalho de Melo , Sherry Hurwitz , Kees Cook , linux-kernel@vger.kernel.org, Shuah Khan , Oleg Nesterov , torvalds@linux-foundation.org, dwmw@amazon.co.uk, karahmed@amazon.de, Borislav Petkov , dave.hansen@linux.intel.com, linux@dominikbrodowski.net, Quentin Casasnovas , Joerg Roedel , Alexander Shishkin , Kyle Huey , Will Drewry , Andrey Ryabinin , "H. Peter Anvin" , Brian Gerst , Kristen Carlson Accardi , Thomas Garnier , Andrew Morton , Joe Konno , kvm , Piotr Luc , boris.ostrovsky@oracle.com, Jan Beulich , arjan@linux.intel.com, Alexander Kuleshov , Juergen Gross , Ross Zwisler , =?iso-8859-1?Q?J=F6rg?= Otte , tim.c.chen@linux.intel.com, Alexander Sergeyev , Josh Triplett , gnomes@lxorguk.ukuu.org.uk, Tony Luck , Laura Abbott , dave.hansen@intel.com, Ingo Molnar , Mike Galbraith , Rik van Riel , "Kirill A. Shutemov" , Alexey Makhalov , Dave Hansen , ashok.raj@intel.com, Mel Gorman , =?iso-8859-1?Q?Micka=EBlSala=FCn?= , Fenghua Yu , "Matt Helsley (VMware)" , Vince Weaver , Prarit Bhargava , rostedt@goodmis.org, Dan Williams , Jim Mattson , Dave Young , linux-edac , Jon Masters , Jiri Kosina , Andy Lutomirski , Paolo Bonzini , Arnd Bergmann , linux-mm@kvack.org, Jiri Olsa , arjan.van.de.ven@intel.com, sironi@amazon.de, Frederic Weisbecker , Kyle Huey , Alexander Popov , Andy Shevchenko , Nadav Amit , Yazen Ghannam , Wanpeng Li , Stephane Eranian , David Woodhouse , srivatsab@vmware.com On Sat, Jul 14, 2018 at 02:25:43AM -0700, Srivatsa S. Bhat wrote: > Hi Greg, > > This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) > and patches for the Speculative Store Bypass vulnerability to 4.4.y > (they apply cleanly on top of 4.4.140). > > I used 4.9.y as my reference when backporting to 4.4.y (as I thought > that would minimize the amount of fixing up necessary). Unfortunately > I had to skip the KVM fixes for these vulnerabilities, as the KVM > codebase is drastically different in 4.4 as compared to 4.9. (I tried > my best to backport them initially, but wasn't confident that they > were correct, so I decided to drop them from this series). > > You'll notice that the initial few patches in this series include > cleanups etc., that are non-critical to IBPB/IBRS/SSBD. Most of these > patches are aimed at getting the cpufeature.h vs cpufeatures.h split > into 4.4, since a lot of the subsequent patches update these headers. > On my first attempt to backport these patches to 4.4.y, I had actually > tried to do all the updates on the cpufeature.h file itself, but it > started getting very cumbersome, so I resorted to backporting the > cpufeature.h vs cpufeatures.h split and their dependencies as well. I > think apart from these initial patches, the rest of the patchset > doesn't have all that much noise. > > This patchset has been tested on both Intel and AMD machines (Intel > Xeon CPU E5-2660 v4 and AMD EPYC 7281 16-Core Processor, respectively) > with updated microcode. All the patch backports have been > independently reviewed by Matt Helsley, Alexey Makhalov and Bo Gan. > > I would appreciate if you could kindly consider these patches for > review and inclusion in a future 4.4.y release. Given no one has complained about these yet, I've queued them all up, including the 2 extra ones you sent afterward. Let's see what breaks :) thanks, greg k-h