From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54262 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387975AbeGWNOL (ORCPT ); Mon, 23 Jul 2018 09:14:11 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6NCA4jq074068 for ; Mon, 23 Jul 2018 08:13:15 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0b-001b2d01.pphosted.com with ESMTP id 2kdbqgytvv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 23 Jul 2018 08:13:14 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Jul 2018 08:13:14 -0400 Date: Mon, 23 Jul 2018 17:43:06 +0530 From: Gautham R Shenoy To: Greg KH Cc: "Gautham R. Shenoy" , stable@vger.kernel.org, Michael Ellerman Subject: Re: [PATCH] powerpc/powernv : Save/Restore SPRG3 on entry/exit from stop. Reply-To: ego@linux.vnet.ibm.com References: <1532277223142142@kroah.com> <1532323855-25307-1-git-send-email-ego@linux.vnet.ibm.com> <20180723061628.GA2035@kroah.com> <20180723075350.GA31879@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723075350.GA31879@kroah.com> Message-Id: <20180723121306.GB342@in.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: Hello Greg, On Mon, Jul 23, 2018 at 09:53:50AM +0200, Greg KH wrote: > On Mon, Jul 23, 2018 at 08:16:28AM +0200, Greg KH wrote: > > On Mon, Jul 23, 2018 at 11:00:55AM +0530, Gautham R. Shenoy wrote: > > > From: "Gautham R. Shenoy" > > > > > > [ Upstream commit b03897cf318dfc47de33a7ecbc7655584266f034 ] > > > > > > On 64-bit servers, SPRN_SPRG3 and its userspace read-only mirror > > > SPRN_USPRG3 are used as userspace VDSO write and read registers > > > respectively. > > > > > > SPRN_SPRG3 is lost when we enter stop4 and above, and is currently not > > > restored. As a result, any read from SPRN_USPRG3 returns zero on an > > > exit from stop4 and above. > > > > > > Thus in this situation, on POWER9, any call from sched_getcpu() always > > > returns zero, as on powerpc, we call __kernel_getcpu() which relies > > > upon SPRN_USPRG3 to report the CPU and NUMA node information. > > > > > > Fix this by restoring SPRN_SPRG3 on wake up from a deep stop state > > > with the sprg_vdso value that is cached in PACA. > > > > > > Fixes: e1c1cfed5432 ("powerpc/powernv: Save/Restore additional SPRs > > > for stop4 cpuidle") > > > > > > Reported-by: Florian Weimer > > > Cc: # 4.14 > > > Signed-off-by: Gautham R. Shenoy > > > Reviewed-by: Michael Ellerman > > > Signed-off-by: Michael Ellerman > > > --- > > > arch/powerpc/kernel/idle_book3s.S | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > What stable tree(s) do you want this applied to? > > I've now guessed that it is 4.14.y. If that's not the case, please let > me know. Yes, this backport is for 4.14.y. The upstream commit cleanly applies on 4.15.18 and 4.16.18. > > greg k-h > -- Thanks and Regards gautham.