From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 1/5] drm/vkms: Add functions to map/unmap GEM backing storage Date: Mon, 23 Jul 2018 09:51:47 -0400 Message-ID: <20180723135147.GE20359@art_vandelay> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x241.google.com (mail-yb0-x241.google.com [IPv6:2607:f8b0:4002:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 901176E163 for ; Mon, 23 Jul 2018 13:51:49 +0000 (UTC) Received: by mail-yb0-x241.google.com with SMTP id s8-v6so251495ybe.8 for ; Mon, 23 Jul 2018 06:51:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Haneen Mohammed Cc: rodrigosiqueiramelo@gmail.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMTksIDIwMTggYXQgMDM6MTg6MDNBTSArMDMwMCwgSGFuZWVuIE1vaGFtbWVk IHdyb3RlOgo+IFRoaXMgcGF0Y2ggYWRkIHRoZSBuZWNlc3NhcnkgZnVuY3Rpb25zIHRvIG1hcC91 bm1hcCBHRU0KPiBiYWNraW5nIG1lbW9yeSB0byB0aGUga2VybmVsJ3MgdmlydHVhbCBhZGRyZXNz IHNwYWNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEhhbmVlbiBNb2hhbW1lZCA8aGFtb2hhbW1lZC5z YUBnbWFpbC5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2MjoKPiAtIGFkZCB2a21zX2dlbV92dW5t YXAKPiAtIHVzZSB2bWFwX2NvdW50IHRvIGd1YXJkIGFnYWluc3QgbXVsdGlwbGUgcHJlcGFyZV9m YiBjYWxscyBvbiB0aGUgc2FtZQo+ICAgZmIKPiBDaGFuZ2VzIGluIHYzOgo+IC0gY2hhbmdlIHZr bXNfZ2VtX3ZtYXAgdG8gcmV0cnVuIGludAo+IC0gY2xlYW51cCBpZiB2bWFwIGZhaWxlZAo+IC0g aW5jcmVtZW50IHZtYXBfY291bnQgYWZ0ZXIgc3VjY2Vzc2Z1bCB2bWFwCj4gCj4gIGRyaXZlcnMv Z3B1L2RybS92a21zL3ZrbXNfZHJ2LmggfCAgOSArKysrCj4gIGRyaXZlcnMvZ3B1L2RybS92a21z L3ZrbXNfZ2VtLmMgfCA4MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgMiBm aWxlcyBjaGFuZ2VkLCA4OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0v dmttcy92a21zX2Rydi5oCj4gaW5kZXggMDdiZTI5ZjJkYzQ0Li40NzA0OGY3MDc1NjYgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19kcnYuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS92a21zL3ZrbXNfZHJ2LmgKPiBAQCAtMzksNiArMzksOCBAQCBzdHJ1Y3Qgdmttc19n ZW1fb2JqZWN0IHsKPiAgCXN0cnVjdCBkcm1fZ2VtX29iamVjdCBnZW07Cj4gIAlzdHJ1Y3QgbXV0 ZXggcGFnZXNfbG9jazsgLyogUGFnZSBsb2NrIHVzZWQgaW4gcGFnZSBmYXVsdCBoYW5kbGVyICov Cj4gIAlzdHJ1Y3QgcGFnZSAqKnBhZ2VzOwo+ICsJdW5zaWduZWQgaW50IHZtYXBfY291bnQ7Cj4g Kwl2b2lkICp2YWRkcjsKPiAgfTsKPiAgCj4gICNkZWZpbmUgZHJtX2NydGNfdG9fdmttc19vdXRw dXQodGFyZ2V0KSBcCj4gQEAgLTQ3LDYgKzQ5LDkgQEAgc3RydWN0IHZrbXNfZ2VtX29iamVjdCB7 Cj4gICNkZWZpbmUgZHJtX2RldmljZV90b192a21zX2RldmljZSh0YXJnZXQpIFwKPiAgCWNvbnRh aW5lcl9vZih0YXJnZXQsIHN0cnVjdCB2a21zX2RldmljZSwgZHJtKQo+ICAKPiArI2RlZmluZSBk cm1fZ2VtX3RvX3ZrbXNfZ2VtKHRhcmdldClcCj4gKwljb250YWluZXJfb2YodGFyZ2V0LCBzdHJ1 Y3Qgdmttc19nZW1fb2JqZWN0LCBnZW0pCj4gKwo+ICAvKiBDUlRDICovCj4gIGludCB2a21zX2Ny dGNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g IAkJICAgc3RydWN0IGRybV9wbGFuZSAqcHJpbWFyeSwgc3RydWN0IGRybV9wbGFuZSAqY3Vyc29y KTsKPiBAQCAtNzUsNCArODAsOCBAQCBpbnQgdmttc19kdW1iX21hcChzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGUsIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAo+ICB2b2lkIHZrbXNfZ2VtX2ZyZWVf b2JqZWN0KHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKTsKPiAgCj4gK2ludCB2a21zX2dlbV92 bWFwKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKTsKPiArCj4gK3ZvaWQgdmttc19nZW1fdnVu bWFwKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKTsKPiArCj4gICNlbmRpZiAvKiBfVktNU19E UlZfSF8gKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19nZW0uYyBi L2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZ2VtLmMKPiBpbmRleCBjN2UzODM2ODYwMmIuLjJl NTVjOTA2ZDliMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2dlbS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19nZW0uYwo+IEBAIC0zNyw3ICszNyw5 IEBAIHZvaWQgdmttc19nZW1fZnJlZV9vYmplY3Qoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmop Cj4gIAlzdHJ1Y3Qgdmttc19nZW1fb2JqZWN0ICpnZW0gPSBjb250YWluZXJfb2Yob2JqLCBzdHJ1 Y3Qgdmttc19nZW1fb2JqZWN0LAo+ICAJCQkJCQkgICBnZW0pOwo+ICAKPiAtCWt2ZnJlZShnZW0t PnBhZ2VzKTsKPiArCVdBUk5fT04oZ2VtLT5wYWdlcyk7Cj4gKwlXQVJOX09OKGdlbS0+dmFkZHIp Owo+ICsKPiAgCW11dGV4X2Rlc3Ryb3koJmdlbS0+cGFnZXNfbG9jayk7Cj4gIAlkcm1fZ2VtX29i amVjdF9yZWxlYXNlKG9iaik7Cj4gIAlrZnJlZShnZW0pOwo+IEBAIC0xNzcsMyArMTc5LDc5IEBA IGludCB2a21zX2R1bWJfbWFwKHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwgc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKPiAgCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gKwo+ICtzdGF0aWMgc3RydWN0IHBh Z2UgKipfZ2V0X3BhZ2VzKHN0cnVjdCB2a21zX2dlbV9vYmplY3QgKnZrbXNfb2JqKQo+ICt7Cj4g KwlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKmdlbV9vYmogPSAmdmttc19vYmotPmdlbTsKPiArCj4g KwlpZiAoIXZrbXNfb2JqLT5wYWdlcykgewo+ICsJCXN0cnVjdCBwYWdlICoqcGFnZXMgPSBkcm1f Z2VtX2dldF9wYWdlcyhnZW1fb2JqKTsKPiArCj4gKwkJaWYgKElTX0VSUihwYWdlcykpCj4gKwkJ CXJldHVybiBwYWdlczsKPiArCj4gKwkJaWYgKGNtcHhjaGcoJnZrbXNfb2JqLT5wYWdlcywgTlVM TCwgcGFnZXMpKQo+ICsJCQlkcm1fZ2VtX3B1dF9wYWdlcyhnZW1fb2JqLCBwYWdlcywgZmFsc2Us IHRydWUpOwo+ICsJfQo+ICsKPiArCXJldHVybiB2a21zX29iai0+cGFnZXM7Cj4gK30KPiArCj4g K3ZvaWQgdmttc19nZW1fdnVubWFwKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKQo+ICt7Cj4g KwlzdHJ1Y3Qgdmttc19nZW1fb2JqZWN0ICp2a21zX29iaiA9IGRybV9nZW1fdG9fdmttc19nZW0o b2JqKTsKPiArCj4gKwltdXRleF9sb2NrKCZ2a21zX29iai0+cGFnZXNfbG9jayk7Cj4gKwlpZiAo dmttc19vYmotPnZtYXBfY291bnQgPCAxKSB7Cj4gKwkJV0FSTl9PTih2a21zX29iai0+dmFkZHIp Owo+ICsJCVdBUk5fT04odmttc19vYmotPnBhZ2VzKTsKPiArCQltdXRleF91bmxvY2soJnZrbXNf b2JqLT5wYWdlc19sb2NrKTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJdmttc19vYmotPnZt YXBfY291bnQtLTsKPiArCj4gKwlpZiAodmttc19vYmotPnZtYXBfY291bnQgPT0gMCkgewo+ICsJ CXZ1bm1hcCh2a21zX29iai0+dmFkZHIpOwo+ICsJCXZrbXNfb2JqLT52YWRkciA9IE5VTEw7Cj4g KwkJZHJtX2dlbV9wdXRfcGFnZXMob2JqLCB2a21zX29iai0+cGFnZXMsIGZhbHNlLCB0cnVlKTsK PiArCQl2a21zX29iai0+cGFnZXMgPSBOVUxMOwo+ICsJfQo+ICsKPiArCW11dGV4X3VubG9jaygm dmttc19vYmotPnBhZ2VzX2xvY2spOwo+ICt9Cj4gKwo+ICtpbnQgdmttc19nZW1fdm1hcChzdHJ1 Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikKPiArewo+ICsJc3RydWN0IHZrbXNfZ2VtX29iamVjdCAq dmttc19vYmogPSBkcm1fZ2VtX3RvX3ZrbXNfZ2VtKG9iaik7Cj4gKwlpbnQgcmV0ID0gMDsKPiAr Cj4gKwltdXRleF9sb2NrKCZ2a21zX29iai0+cGFnZXNfbG9jayk7Cj4gKwo+ICsJaWYgKCF2a21z X29iai0+dmFkZHIpIHsKPiArCQl1bnNpZ25lZCBpbnQgbl9wYWdlcyA9IG9iai0+c2l6ZSA+PiBQ QUdFX1NISUZUOwo+ICsJCXN0cnVjdCBwYWdlICoqcGFnZXMgPSBfZ2V0X3BhZ2VzKHZrbXNfb2Jq KTsKPiArCj4gKwkJaWYgKElTX0VSUihwYWdlcykpIHsKPiArCQkJcmV0ID0gUFRSX0VSUihwYWdl cyk7Cj4gKwkJCWdvdG8gZmFpbDsKPiArCQl9Cj4gKwo+ICsJCXZrbXNfb2JqLT52YWRkciA9IHZt YXAocGFnZXMsIG5fcGFnZXMsIFZNX01BUCwgUEFHRV9LRVJORUwpOwo+ICsJCWlmICghdmttc19v YmotPnZhZGRyKSB7Cj4gKwkJCXJldCA9IC1FTk9NRU07Cj4gKwkJCWRybV9nZW1fcHV0X3BhZ2Vz KG9iaiwgdmttc19vYmotPnBhZ2VzLCBmYWxzZSwgdHJ1ZSk7Cj4gKwkJCXZrbXNfb2JqLT5wYWdl cyA9IE5VTEw7Cj4gKwkJCWdvdG8gZmFpbDsKPiArCQl9Cj4gKwo+ICsJCXZrbXNfb2JqLT52bWFw X2NvdW50Kys7Cj4gKwl9Cj4gKwo+ICsJbXV0ZXhfdW5sb2NrKCZ2a21zX29iai0+cGFnZXNfbG9j ayk7Cj4gKwlyZXR1cm4gMDsKPiArCj4gK2ZhaWw6CgpTaW5jZSBmYWlsIGRvZXMgdGhlIHNhbWUg YXMgdGhlIHN1Y2Nlc3MgcGF0aCwgdGhlcmUgYXJlIDIgd2F5cyBvZiBoYW5kbGluZyB0aGlzCnRo YXQgd291bGQgYmUgKElNTykgYmV0dGVyOgoKMS0gUmVuYW1lIGZhaWwgdG8gb3V0IGFuZCByZW1v dmUgdGhlIHJlZHVuZGFudCAyIGxpbmVzIGFib3ZlCjItIEFkZCBhIG5ldyBsYWJlbCBhYm92ZSBm YWlsIGNhbGxlZCBlcnJfdm1hcCBhbmQgZG8gdGhlIHJldC9wdXRfcGFnZXMvcGFnZXM9TlVMTAog ICBjbGVhbnVwIHRoZXJlLCBkcm9wcGluZyBpbnRvIHRoZSB1bmxvY2sgYW5kIHJldHVybiBhZnRl ci4KCldpdGggZWl0aGVyIG9mIHRoZXNlIGNoYW5nZXMsCgpSZXZpZXdlZC1ieTogU2VhbiBQYXVs IDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+CgoKU2VhbgoKPiArCW11dGV4X3VubG9jaygmdmttc19v YmotPnBhZ2VzX2xvY2spOwo+ICsJcmV0dXJuIHJldDsKPiArfQo+IC0tIAo+IDIuMTcuMQo+IAoK LS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=