All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: John Snow <jsnow@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149
Date: Mon, 23 Jul 2018 14:55:19 +0100	[thread overview]
Message-ID: <20180723135519.GI3397@redhat.com> (raw)
In-Reply-To: <20180723135345.GF8817@localhost.localdomain>

On Mon, Jul 23, 2018 at 03:53:45PM +0200, Kevin Wolf wrote:
> Am 13.07.2018 um 20:12 hat John Snow geschrieben:
> > 
> > 
> > On 07/13/2018 03:10 AM, Kevin Wolf wrote:
> > > The test case uses block devices with driver=file, which causes the test
> > > to fail after commit 230ff73904 added a deprecation warning for this.
> > > Fix the test case to use driver=host_device and update the reference
> > > output accordingly.
> > > 
> > > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > 
> > 149         [not run] requires password-less sudo access: sudo: a
> > password is required
> > 
> > Ah, this one hides from regression scripts quite well...
> > 
> > This test fails both before and after this patch for me, with
> > 
> > +Traceback (most recent call last):
> > +  File "149", line 525, in <module>
> > +    test_once(config, qemu_img=False)
> > +  File "149", line 336, in test_once
> > +    cryptsetup_open(config)
> > +  File "149", line 200, in cryptsetup_open
> > +    cryptsetup(args, password)
> > +  File "149", line 124, in cryptsetup
> > +    raise Exception(msg)
> > +Exception: Device qiotest-145-twofish-128-xts-plain64-sha1 already exists.
> > +Command failed with code 17: File exists
> > 
> > Am I missing some prerequisite, maybe?
> 
> Hm, sounds a bit like a failed first attempt that didn't clean up behind
> itself properly? Just guessing though.

Yeah, sounds like it failed badly enough that cleanup broke.

Can probably fix it by either rebooting, or the more nuanced:

  cryptsetup luksClose qiotest-145-twofish-128-xts-plain64-sha1

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

      reply	other threads:[~2018-07-23 13:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  7:10 [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149 Kevin Wolf
2018-07-13 18:12 ` John Snow
2018-07-23 13:53   ` Kevin Wolf
2018-07-23 13:55     ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723135519.GI3397@redhat.com \
    --to=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.