All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] iotest: Fix filtering order in 226
Date: Mon, 23 Jul 2018 15:55:38 +0200	[thread overview]
Message-ID: <20180723135538.GG8817@localhost.localdomain> (raw)
In-Reply-To: <4347078d-5854-ac6e-f0cd-7512cbd9f419@redhat.com>

Am 13.07.2018 um 22:14 hat John Snow geschrieben:
> 
> 
> On 07/13/2018 03:41 PM, Max Reitz wrote:
> > The test directory should be filtered before the image format, otherwise
> > the test will fail if the image format is part of the test directory,
> > like so:
> > 
> > [...]
> > -can't open: Could not open 'TEST_DIR/t.IMGFMT': Is a directory
> > +can't open: Could not open '/tmp/test-IMGFMT/t.IMGFMT': Is a directory
> > [...]
> > 
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> 
> Too many gotchas in our test suite.
> 
> Thanks :(

Maybe we should start writing tests for our tests? ;-)

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2018-07-23 13:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 19:41 [Qemu-devel] [PATCH] iotest: Fix filtering order in 226 Max Reitz
2018-07-13 20:14 ` John Snow
2018-07-23 13:55   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723135538.GG8817@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.