All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 4/7] iotests: remove LUKS support from test 226
Date: Mon, 23 Jul 2018 18:45:27 +0200	[thread overview]
Message-ID: <20180723164530.26599-5-kwolf@redhat.com> (raw)
In-Reply-To: <20180723164530.26599-1-kwolf@redhat.com>

From: John Snow <jsnow@redhat.com>

This test doesn't actually care about the format anyway, it just
supports "all formats" as a convenience. LUKS however does not use a
simple image filename which confuses this iotest.

We can simply skip the test for formats that use IMGOPTSSYNTAX for
their filenames without missing much coverage.

Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/226 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226
index 460aea2fc9..34987d43f9 100755
--- a/tests/qemu-iotests/226
+++ b/tests/qemu-iotests/226
@@ -41,6 +41,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 # Generic format, but tests file-protocol specific error handling
 _supported_fmt generic
+if [ "$IMGOPTSSYNTAX" = "true" ]; then
+    _unsupported_fmt $IMGFMT
+fi
 _supported_proto file
 _supported_os Linux
 
-- 
2.13.6

  parent reply	other threads:[~2018-07-23 16:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 16:45 [Qemu-devel] [PULL 0/7] Block layer patches Kevin Wolf
2018-07-23 16:45 ` [Qemu-devel] [PULL 1/7] qemu-iotests: Use host_device instead of file in 149 Kevin Wolf
2018-07-23 16:45 ` [Qemu-devel] [PULL 2/7] block: Fix typos in comments (found by codespell) Kevin Wolf
2018-07-23 16:45 ` [Qemu-devel] [PULL 3/7] qemu-img: avoid overflow of min_sparse parameter Kevin Wolf
2018-07-23 16:45 ` Kevin Wolf [this message]
2018-07-23 16:45 ` [Qemu-devel] [PULL 5/7] iotest: Fix filtering order in 226 Kevin Wolf
2018-07-23 16:45 ` [Qemu-devel] [PULL 6/7] iotests: Disallow compat=0.10 in 223 Kevin Wolf
2018-07-23 16:45 ` [Qemu-devel] [PULL 7/7] block/vvfat: Disable debug message by default Kevin Wolf
2018-07-23 18:23 ` [Qemu-devel] [PULL 0/7] Block layer patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723164530.26599-5-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.