From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Tue, 24 Jul 2018 08:58:28 +0200 Subject: [U-Boot] [PATCH 11/20] w1: enumerate sandbox driver if configured In-Reply-To: References: <1531994288-19423-1-git-send-email-eugen.hristev@microchip.com> <1531994288-19423-12-git-send-email-eugen.hristev@microchip.com> <20180720160153.18c85f96@jawa> Message-ID: <20180724065828.nsbfkitstqg53h4c@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jul 23, 2018 at 05:48:25PM -0600, Simon Glass wrote: > Hi, > > On 20 July 2018 at 08:01, Lukasz Majewski wrote: > > Hi Eugen, > > > > Thanks for (re-)bringing the One wire support to u-boot. > > > >> Add a sandbox eeprom on the bus as a device, if sandbox driver is > >> configured. > >> > >> Signed-off-by: Eugen Hristev > >> --- > >> drivers/w1/w1-uclass.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/drivers/w1/w1-uclass.c b/drivers/w1/w1-uclass.c > >> index cfddda3..e58c1ca 100644 > >> --- a/drivers/w1/w1-uclass.c > >> +++ b/drivers/w1/w1-uclass.c > >> @@ -142,6 +142,11 @@ static int w1_enumerate(struct udevice *bus) > >> } > >> } > >> > >> +#ifdef CONFIG_W1_EEPROM_SANDBOX > >> + /* before we are finished, add a sandbox device if we can */ > >> + w1_new_device(bus, W1_FAMILY_EEP_SANDBOX); > >> +#endif > > > > IMHO we shouldn't mix the sandbox code with production (on boards) code. > > > > Maybe Simon (+CCed) could provide some more input here? > > I have not seen this series. But new devices should be created > automatically based on them being in the device tree. So you should > just be able to add them there. 1-Wire is discoverable, so there's no device nodes in the DT. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: