From: Pavel Machek <pavel@ucw.cz>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
David Lechner <david@lechnology.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface
Date: Tue, 24 Jul 2018 13:50:29 +0200 [thread overview]
Message-ID: <20180724115029.GB26036@amd> (raw)
In-Reply-To: <CAMz4kuKGcnDqyF29vGDqjRDMWmmk=c=QVQExYrx_Ymomm3qh+g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
Hi!
> Thanks for showing your thoughts. But I failed to compile your code,
> would you like to send out formal patches (Or only including software
> pattern, I will help to add hardware pattern part and do some testing
> with our driver)? Thanks.
Random thoughts:
I am not sure "struct led_pattern" makes sense. Maybe array of
integers would be enough? Should we have structure with whole array
and length of the pattern?
struct led_pattern {
int len;
struct led_pattern steps[];
}
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-07-24 11:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 5:03 [PATCH v3 1/2] leds: core: Introduce generic pattern interface Baolin Wang
2018-06-29 5:03 ` [PATCH v3 2/2] leds: sc27xx: Add pattern_set/get/clear interfaces for LED controller Baolin Wang
2018-07-11 11:02 ` [PATCH v3 1/2] leds: core: Introduce generic pattern interface Baolin Wang
2018-07-11 21:10 ` Jacek Anaszewski
2018-07-12 12:24 ` Baolin Wang
2018-07-12 21:41 ` Jacek Anaszewski
2018-07-13 1:58 ` Baolin Wang
2018-07-14 21:20 ` Pavel Machek
2018-07-14 22:02 ` Jacek Anaszewski
2018-07-14 22:29 ` Pavel Machek
2018-07-14 22:39 ` Pavel Machek
2018-07-15 12:22 ` Jacek Anaszewski
2018-07-16 1:00 ` David Lechner
2018-07-16 20:29 ` Jacek Anaszewski
2018-07-16 21:56 ` Pavel Machek
2018-07-17 20:26 ` Jacek Anaszewski
2018-07-17 21:07 ` Pavel Machek
2018-07-24 0:35 ` Bjorn Andersson
2018-07-18 7:56 ` Pavel Machek
2018-07-18 11:32 ` Baolin Wang
2018-07-18 12:08 ` Pavel Machek
2018-07-18 17:00 ` David Lechner
2018-07-20 19:11 ` Jacek Anaszewski
2018-07-24 0:55 ` Bjorn Andersson
2018-07-18 18:54 ` Jacek Anaszewski
2018-07-18 19:22 ` Jacek Anaszewski
2018-07-18 22:13 ` David Lechner
2018-07-18 22:17 ` Pavel Machek
2018-07-19 20:20 ` Pavel Machek
2018-07-20 18:08 ` Jacek Anaszewski
2018-07-23 6:59 ` Baolin Wang
2018-07-24 11:41 ` Pavel Machek
2018-07-27 5:15 ` Baolin Wang
2018-07-27 8:36 ` Pavel Machek
2018-07-27 8:41 ` Baolin Wang
2018-07-24 11:50 ` Pavel Machek [this message]
2018-07-24 0:18 ` Bjorn Andersson
2018-07-16 11:08 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724115029.GB26036@amd \
--to=pavel@ucw.cz \
--cc=baolin.wang@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.