All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] network-manager: add optional dependency on polkit
Date: Tue, 24 Jul 2018 15:48:42 +0200	[thread overview]
Message-ID: <20180724134841.GA11682@dell5510> (raw)
In-Reply-To: <20180724105013.7137-1-apanfilov@spectracom.com>

Hi Artem,

> Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>
> ---
>  package/network-manager/network-manager.mk | 4 ++++
>  1 file changed, 4 insertions(+)

> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> index a520aad9c0..9774921838 100644
> --- a/package/network-manager/network-manager.mk
> +++ b/package/network-manager/network-manager.mk
> @@ -82,6 +82,10 @@ else
>  NETWORK_MANAGER_CONF_OPTS += --disable-ovs
>  endif

> +ifeq ($(BR2_PACKAGE_POLKIT),y)
> +NETWORK_MANAGER_DEPENDENCIES += polkit
> +endif
Shouldn't we pass --enable-polkit=yes to configure?
Or is it enough that it's detected here?

> +
>  # uClibc by default doesn't have backtrace support, so don't use it
>  ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
>  NETWORK_MANAGER_CONF_OPTS += --disable-crashtrace


Kind regards,
Petr

           reply	other threads:[~2018-07-24 13:48 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180724105013.7137-1-apanfilov@spectracom.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724134841.GA11682@dell5510 \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.