From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 24 Jul 2018 14:12:35 -0000 Received: from mga14.intel.com ([192.55.52.115]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fhy3G-0002ZN-4b for speck@linutronix.de; Tue, 24 Jul 2018 16:12:34 +0200 Date: Tue, 24 Jul 2018 07:12:28 -0700 From: Andi Kleen Subject: [MODERATED] Re: [RFC PATCH 4/6] kvm: handle host mode irqs 4 Message-ID: <20180724141228.GH35943@tassilo.jf.intel.com> References: <6815cf025aa41954f911a1e76c2415035307b00f.1532339695.git.nstange@suse.de> <20180723154021.GE35943@tassilo.jf.intel.com> <87sh49xjip.fsf_-_@suse.de> MIME-Version: 1.0 In-Reply-To: <87sh49xjip.fsf_-_@suse.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > > You can put it into irq_enter/exit, no need to mess with assembler code. > > The reason I put it there was to avoid touching anything outside of > arch/x86. > > In addition, > - uv_bau_message_interrupt() doesn't call irq_enter() at all, > - smp_reschedule_interrupt() calls it conditionally > > But I'm not sure it matters much and either way is fine by me. Upstream normally prefers C changes -Andi