From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhyhy-0004ai-J9 for qemu-devel@nongnu.org; Tue, 24 Jul 2018 10:54:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhyhv-0005FK-9e for qemu-devel@nongnu.org; Tue, 24 Jul 2018 10:54:38 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56708 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fhyhv-0005F5-27 for qemu-devel@nongnu.org; Tue, 24 Jul 2018 10:54:35 -0400 Date: Tue, 24 Jul 2018 15:54:30 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180724145429.GD2374@work-vm> References: <20180722193350.6028-1-zhangckid@gmail.com> <20180722193350.6028-11-zhangckid@gmail.com> <0f358f05-46c7-cb77-c9fd-1d6673493df4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH V10 10/20] qmp event: Add COLO_EXIT event to notify users while exited COLO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen Cc: Eric Blake , qemu-devel@nongnu.org, Paolo Bonzini , Juan Quintela , Jason Wang , Markus Armbruster , zhanghailiang , Li Zhijian * Zhang Chen (zhangckid@gmail.com) wrote: > On Tue, Jul 24, 2018 at 2:41 AM, Eric Blake wrote: > > > On 07/22/2018 02:33 PM, Zhang Chen wrote: > > > >> From: zhanghailiang > >> > >> If some errors happen during VM's COLO FT stage, it's important to > >> notify the users of this event. Together with 'x-colo-lost-heartbeat', > >> Users can intervene in COLO's failover work immediately. > >> If users don't want to get involved in COLO's failover verdict, > >> it is still necessary to notify users that we exited COLO mode. > >> > >> Signed-off-by: zhanghailiang > >> Signed-off-by: Li Zhijian > >> Signed-off-by: Zhang Chen > >> Reviewed-by: Eric Blake > >> Reviewed-by: Markus Armbruster > >> --- > >> migration/colo.c | 31 +++++++++++++++++++++++++++++++ > >> qapi/migration.json | 38 ++++++++++++++++++++++++++++++++++++++ > >> 2 files changed, 69 insertions(+) > >> > > > > At this point in the release cycle, this series feels like enough of a new > > feature (rather than a bug fix) that it is probably not appropriate for > > 3.0, which means... > > > > > > +++ b/qapi/migration.json > >> @@ -900,6 +900,44 @@ > >> { 'enum': 'FailoverStatus', > >> 'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] } > >> +## > >> +# @COLO_EXIT: > >> +# > >> +# Emitted when VM finishes COLO mode due to some errors happening or > >> +# at the request of users. > >> +# > >> +# @mode: report COLO mode when COLO exited. > >> +# > >> +# @reason: describes the reason for the COLO exit. > >> +# > >> +# Since: 3.0 > >> > > > > ...this and other references should be updated to 3.1. > > > OK, I will fix it and resend this series. No need to resend now; resend after the review of the other bits in the series; I'm sure there will be other minor things; anyway we can always fix up version nunmbers in merge. Dave > Thanks > Zhang Chen > > > > > > > > -- > > Eric Blake, Principal Software Engineer > > Red Hat, Inc. +1-919-301-3266 > > Virtualization: qemu.org | libvirt.org > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK