From: Mike Snitzer <snitzer@redhat.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: data corruption with 'splt' workload to XFS on DM cache with its 3 underlying devices being on same NVMe device
Date: Tue, 24 Jul 2018 11:07:25 -0400 [thread overview]
Message-ID: <20180724150725.GA3235@redhat.com> (raw)
In-Reply-To: <bc63227473a19cb23d6b2bb38eefa564dfec1ffc.camel@wdc.com>
On Tue, Jul 24 2018 at 10:25am -0400,
Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> On Tue, 2018-07-24 at 08:00 +0200, Hannes Reinecke wrote:
> > So, have you tested that request-based multipathing works on a partition
> > _at all_? I'm not sure if partition mapping is done correctly here; we
> > never remap the start of the request (nor bio, come to speak of it), so
> > it looks as if we would be doing the wrong things here.
> >
> > Have you checked that partition remapping is done correctly?
>
> I think generic_make_request() takes care of partition remapping by calling
> blk_partition_remap(). generic_make_request() is called by submit_bio(). Is
> that sufficient to cover all dm drivers?
Seems not for request-based DM (see my previous reply in this thread).
But bio-based DM-multipath seems to work just fine.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.de" <hare@suse.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: data corruption with 'splt' workload to XFS on DM cache with its 3 underlying devices being on same NVMe device
Date: Tue, 24 Jul 2018 11:07:25 -0400 [thread overview]
Message-ID: <20180724150725.GA3235@redhat.com> (raw)
In-Reply-To: <bc63227473a19cb23d6b2bb38eefa564dfec1ffc.camel@wdc.com>
On Tue, Jul 24 2018 at 10:25am -0400,
Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> On Tue, 2018-07-24 at 08:00 +0200, Hannes Reinecke wrote:
> > So, have you tested that request-based multipathing works on a partition
> > _at all_? I'm not sure if partition mapping is done correctly here; we
> > never remap the start of the request (nor bio, come to speak of it), so
> > it looks as if we would be doing the wrong things here.
> >
> > Have you checked that partition remapping is done correctly?
>
> I think generic_make_request() takes care of partition remapping by calling
> blk_partition_remap(). generic_make_request() is called by submit_bio(). Is
> that sufficient to cover all dm drivers?
Seems not for request-based DM (see my previous reply in this thread).
But bio-based DM-multipath seems to work just fine.
WARNING: multiple messages have this Message-ID (diff)
From: snitzer@redhat.com (Mike Snitzer)
Subject: data corruption with 'splt' workload to XFS on DM cache with its 3 underlying devices being on same NVMe device
Date: Tue, 24 Jul 2018 11:07:25 -0400 [thread overview]
Message-ID: <20180724150725.GA3235@redhat.com> (raw)
In-Reply-To: <bc63227473a19cb23d6b2bb38eefa564dfec1ffc.camel@wdc.com>
On Tue, Jul 24 2018 at 10:25am -0400,
Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> On Tue, 2018-07-24@08:00 +0200, Hannes Reinecke wrote:
> > So, have you tested that request-based multipathing works on a partition
> > _at all_? I'm not sure if partition mapping is done correctly here; we
> > never remap the start of the request (nor bio, come to speak of it), so
> > it looks as if we would be doing the wrong things here.
> >
> > Have you checked that partition remapping is done correctly?
>
> I think generic_make_request() takes care of partition remapping by calling
> blk_partition_remap(). generic_make_request() is called by submit_bio(). Is
> that sufficient to cover all dm drivers?
Seems not for request-based DM (see my previous reply in this thread).
But bio-based DM-multipath seems to work just fine.
next prev parent reply other threads:[~2018-07-24 15:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 16:33 data corruption with 'splt' workload to XFS on DM cache with its 3 underlying devices being on same NVMe device Mike Snitzer
2018-07-23 16:33 ` Mike Snitzer
2018-07-23 16:33 ` Mike Snitzer
2018-07-24 6:00 ` Hannes Reinecke
2018-07-24 6:00 ` Hannes Reinecke
2018-07-24 13:07 ` Mike Snitzer
2018-07-24 13:07 ` Mike Snitzer
2018-07-24 13:07 ` Mike Snitzer
2018-07-24 13:22 ` Laurence Oberman
2018-07-24 13:22 ` Laurence Oberman
2018-07-24 13:22 ` Laurence Oberman
2018-07-24 13:51 ` Hannes Reinecke
2018-07-24 13:51 ` Hannes Reinecke
2018-07-24 13:51 ` Hannes Reinecke
2018-07-24 13:57 ` Laurence Oberman
2018-07-24 13:57 ` Laurence Oberman
2018-07-24 13:57 ` Laurence Oberman
2018-07-24 15:18 ` Mike Snitzer
2018-07-24 15:18 ` Mike Snitzer
2018-07-24 15:18 ` Mike Snitzer
2018-07-24 15:31 ` Laurence Oberman
2018-07-24 15:31 ` Laurence Oberman
2018-07-24 15:31 ` Laurence Oberman
2018-07-24 17:42 ` Christoph Hellwig
2018-07-24 17:42 ` Christoph Hellwig
2018-07-24 17:42 ` Christoph Hellwig
2018-07-24 14:25 ` Bart Van Assche
2018-07-24 14:25 ` Bart Van Assche
2018-07-24 14:25 ` Bart Van Assche
2018-07-24 15:07 ` Mike Snitzer [this message]
2018-07-24 15:07 ` Mike Snitzer
2018-07-24 15:07 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724150725.GA3235@redhat.com \
--to=snitzer@redhat.com \
--cc=Bart.VanAssche@wdc.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.