From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Lidong Chen <jemmy858585@gmail.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org,
Lidong Chen <lidongchen@tencent.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] migration: fix duplicate initialization for expected_downtime and cleanup_bh
Date: Tue, 24 Jul 2018 17:28:49 +0100 [thread overview]
Message-ID: <20180724162849.GF48553@work-vm> (raw)
In-Reply-To: <1532434585-14732-2-git-send-email-lidongchen@tencent.com>
* Lidong Chen (jemmy858585@gmail.com) wrote:
> migrate_fd_connect duplicate initialize expected_downtime and cleanup_bh.
Queued (just 2/2)
> Signed-off-by: Lidong Chen <lidongchen@tencent.com>
> ---
> migration/migration.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index ff05422..b8c4fec 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3032,8 +3032,6 @@ void migrate_fd_connect(MigrationState *s, Error *error_in)
> } else {
> /* This is a fresh new migration */
> rate_limit = s->parameters.max_bandwidth / XFER_LIMIT_RATIO;
> - s->expected_downtime = s->parameters.downtime_limit;
> - s->cleanup_bh = qemu_bh_new(migrate_fd_cleanup, s);
>
> /* Notify before starting migration thread */
> notifier_list_notify(&migration_state_notifiers, s);
> --
> 1.8.3.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-07-24 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 12:16 [Qemu-devel] [PATCH 1/2] migration: fix the Unknown ending state error log Lidong Chen
2018-07-24 12:16 ` [Qemu-devel] [PATCH 2/2] migration: fix duplicate initialization for expected_downtime and cleanup_bh Lidong Chen
2018-07-24 13:07 ` Peter Xu
2018-07-24 13:33 ` Juan Quintela
2018-07-24 16:28 ` Dr. David Alan Gilbert [this message]
2018-07-24 13:02 ` [Qemu-devel] [PATCH 1/2] migration: fix the Unknown ending state error log Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724162849.GF48553@work-vm \
--to=dgilbert@redhat.com \
--cc=jemmy858585@gmail.com \
--cc=lidongchen@tencent.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.