All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andreas Noever <andreas.noever@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 7/7] thunderbolt: Remove redundant variable 'approved'
Date: Wed, 25 Jul 2018 11:03:21 +0300	[thread overview]
Message-ID: <20180725080321.35746-8-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <20180725080321.35746-1-mika.westerberg@linux.intel.com>

From: Colin Ian King <colin.king@canonical.com>

Variable 'approved' is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'approved' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/thunderbolt/icm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index 47f00752a3c2..e1e264a9a4c7 100644
--- a/drivers/thunderbolt/icm.c
+++ b/drivers/thunderbolt/icm.c
@@ -736,7 +736,6 @@ icm_fr_xdomain_connected(struct tb *tb, const struct icm_pkg_header *hdr)
 	struct tb_xdomain *xd;
 	struct tb_switch *sw;
 	u8 link, depth;
-	bool approved;
 	u64 route;
 
 	/*
@@ -750,7 +749,6 @@ icm_fr_xdomain_connected(struct tb *tb, const struct icm_pkg_header *hdr)
 	link = pkg->link_info & ICM_LINK_INFO_LINK_MASK;
 	depth = (pkg->link_info & ICM_LINK_INFO_DEPTH_MASK) >>
 		ICM_LINK_INFO_DEPTH_SHIFT;
-	approved = pkg->link_info & ICM_LINK_INFO_APPROVED;
 
 	if (link > ICM_MAX_LINK || depth > ICM_MAX_DEPTH) {
 		tb_warn(tb, "invalid topology %u.%u, ignoring\n", link, depth);
-- 
2.18.0


      parent reply	other threads:[~2018-07-25  8:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25  8:03 [PATCH 0/7] thunderbolt: Changes for v4.19 merge window Mika Westerberg
2018-07-25  8:03 ` [PATCH 1/7] thunderbolt: Fix small typo in variable name Mika Westerberg
2018-07-25  8:03 ` [PATCH 2/7] thunderbolt: Use 64-bit DMA mask if supported by the platform Mika Westerberg
2018-07-25  8:03 ` [PATCH 3/7] thunderbolt: Do not unnecessarily call ICM get route Mika Westerberg
2018-07-25  8:03 ` [PATCH 4/7] thunderbolt: No need to take tb->lock in domain suspend/complete Mika Westerberg
2018-07-25  8:03 ` [PATCH 5/7] thunderbolt: Use correct ICM commands in system suspend Mika Westerberg
2018-07-25  8:03 ` [PATCH 6/7] thunderbolt: Add support for runtime PM Mika Westerberg
2018-07-25  8:17   ` Greg Kroah-Hartman
2018-07-25  8:43     ` Mika Westerberg
2018-07-25  8:48   ` [PATCH v2 " Mika Westerberg
2018-07-25  8:03 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725080321.35746-8-mika.westerberg@linux.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.