From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Leonid Bloch <lbloch@janustech.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/5 for-3.0] A grammar fix
Date: Wed, 25 Jul 2018 10:49:28 +0200 [thread overview]
Message-ID: <20180725084928.GB4879@localhost.localdomain> (raw)
In-Reply-To: <3edeb663-8e53-ec83-bc19-45a5804d6be3@redhat.com>
Am 24.07.2018 um 23:00 hat Eric Blake geschrieben:
> On 07/24/2018 03:03 PM, Leonid Bloch wrote:
>
> Subject line is rather vague; at a bare minimum, mentioning 'qcow2:' might
> be helpful. But the maintainer can improve that. My suggestion:
>
> qcow2: grammar fix for conflicting cache sizing
How about "qcow2: Grammar fix for conflicting cache size options"?
> > Signed-off-by: Leonid Bloch <lbloch@janustech.com>
> > ---
> > block/qcow2.c | 2 +-
> > tests/qemu-iotests/103.out | 2 +-
You replaced only one of the two places in the reference output, so 103
fails for me now.
Kevin
next prev parent reply other threads:[~2018-07-25 8:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 20:03 [Qemu-devel] [PATCH v3 0/5] Introduction of l2-cache-full option for qcow2 images Leonid Bloch
2018-07-24 20:03 ` [Qemu-devel] [PATCH v3 1/5 for-3.0] A grammar fix Leonid Bloch
2018-07-24 21:00 ` Eric Blake
2018-07-25 8:49 ` Kevin Wolf [this message]
2018-07-25 9:08 ` Leonid Bloch
2018-07-24 20:03 ` [Qemu-devel] [PATCH v3 2/5 for-3.0] qcow2: Options' documentation fixes Leonid Bloch
2018-07-24 21:07 ` Eric Blake
2018-07-24 20:03 ` [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image Leonid Bloch
2018-07-25 8:26 ` Kevin Wolf
2018-07-25 12:22 ` Eric Blake
2018-07-25 12:32 ` Leonid Bloch
2018-07-25 13:32 ` Kevin Wolf
2018-07-25 15:23 ` Leonid Bloch
2018-07-25 15:53 ` Kevin Wolf
2018-07-26 12:24 ` Leonid Bloch
2018-07-26 14:42 ` Kevin Wolf
2018-07-26 14:50 ` Leonid Bloch
2018-07-26 19:43 ` Leonid Bloch
2018-07-26 20:19 ` Kevin Wolf
2018-07-26 21:08 ` Leonid Bloch
2018-07-26 21:28 ` Kevin Wolf
2018-07-26 21:51 ` Leonid Bloch
2018-07-25 15:59 ` Daniel P. Berrangé
2018-07-24 20:03 ` [Qemu-devel] [PATCH v3 4/5] iotests: Add tests for the new l2-cache-full option Leonid Bloch
2018-07-24 20:03 ` [Qemu-devel] [PATCH v3 5/5] docs: Document the " Leonid Bloch
2018-07-24 21:22 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725084928.GB4879@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=lbloch@janustech.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.