All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Rudo <prudo@linux.ibm.com>
To: linux-s390@vger.kernel.org
Subject: [PATCH 4/5] zipl: Move macro definition to Makefile
Date: Wed, 25 Jul 2018 11:36:14 +0000	[thread overview]
Message-ID: <20180725113615.93755-5-prudo@linux.ibm.com> (raw)

In the zipl Makefile macros are defined with the sole purpose to define
other macros in zipl.h. Remove this unnecessary indirection.

Signed-off-by: Philipp Rudo <prudo@linux.ibm.com>
---
 zipl/include/zipl.h | 5 -----
 zipl/src/Makefile   | 5 ++---
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/zipl/include/zipl.h b/zipl/include/zipl.h
index fb68ae88..770801e5 100644
--- a/zipl/include/zipl.h
+++ b/zipl/include/zipl.h
@@ -48,11 +48,6 @@
 #define MENU_DEFAULT_PROMPT		0
 #define MENU_DEFAULT_TIMEOUT		0
 
-#define ZFCPDUMP_IMAGE		STRINGIFY(ZFCPDUMP_DIR) "/" \
-					STRINGIFY(ZFCPDUMP_PART_IMAGE)
-#define ZFCPDUMP_INITRD		STRINGIFY(ZFCPDUMP_DIR) "/" \
-					STRINGIFY(ZFCPDUMP_PART_RD)
-
 #define MAX_DUMP_VOLUMES		32
 
 /* Internal component load address type */
diff --git a/zipl/src/Makefile b/zipl/src/Makefile
index b9018b4b..be14fce5 100644
--- a/zipl/src/Makefile
+++ b/zipl/src/Makefile
@@ -2,9 +2,8 @@
 include ../../common.mak
 
 ALL_CPPFLAGS += -I../include -I../boot \
-	    -DZFCPDUMP_DIR=$(ZFCPDUMP_DIR) \
-	    -DZFCPDUMP_PART_IMAGE=$(ZFCPDUMP_IMAGE) \
-	    -DZFCPDUMP_PART_RD=$(ZFCPDUMP_INITRD) \
+	    -DZFCPDUMP_IMAGE="STRINGIFY($(ZFCPDUMP_DIR)/$(ZFCPDUMP_IMAGE))" \
+	    -DZFCPDUMP_INITRD="STRINGIFY($(ZFCPDUMP_DIR)/$(ZFCPDUMP_INITRD))" \
 	    -D_FILE_OFFSET_BITS=64 $(NO_PIE_CFLAGS)
 ALL_LDFLAGS += -Wl,-z,noexecstack $(NO_PIE_LDFLAGS)
 
-- 
2.16.4

             reply	other threads:[~2018-07-25 11:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 11:36 Philipp Rudo [this message]
     [not found] <31847bcc-32d6-b656-c285-bfb1fe87da23@redhat.com>
2018-08-02  9:57 ` [PATCH 4/5] zipl: Move macro definition to Makefile Hendrik Brueckner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725113615.93755-5-prudo@linux.ibm.com \
    --to=prudo@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.