All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	pombredanne@nexb.com, kstewart@linuxfoundation.org,
	tglx@linutronix.de, John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 00/10] staging:rtl8192u: Coding style - r819xU_cmdpkt.h
Date: Wed, 25 Jul 2018 23:16:20 +0100	[thread overview]
Message-ID: <20180725221630.28595-1-johnfwhitmore@gmail.com> (raw)

This series of patches contain purely simple coding style changes.

I considered renaming the struct cmpk_set_cfg_t as it is never actually
used. Following its definition however it is used in a #define:

#define		cmpk_query_cfg_t	cmpk_set_cfg_t

So whilst the struct cmpk_set_cfg_t is never used, cmpk_query_cfg_t is.
I left it because the comments described this.

I was also tempted to remove comments at the end of lines pushing the
lines over 80 character length. The comments are at the end of sizeof
operators which explicitly state the size. I'm not sure much is gained
by the comment, but I left them in:

#define ...     sizeof(struct cmpk_txfb_t)	  /* 20 */
#define	...     sizeof(struct cmpk_set_cfg_t)     /* 16 */


*** BLURB HERE ***

John Whitmore (10):
  staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
  staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE - Style
  staging:rtl8192u: Rename bit definition ISR_TxBcnOk - Style
  staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE - Style
  staging:rtl8192u: Rename ISR_TxBcnErr bit definition - Style
  staging:rtl8192u: Rename ISR_BcnTimerIntr - Style
  staging:rtl8192u: Remove multiple blank lines - Style
  staging:rtl8192u: Correct spelling in comments - style
  staging:rtl8192u: Remove typedef of struct cmpk_intr_sta_t - Style
  staging:rtl8192u: Remove typedef from struct cmpk_set_cfg_t - Style

 drivers/staging/rtl8192u/r819xU_cmdpkt.c | 22 ++++++++---------
 drivers/staging/rtl8192u/r819xU_cmdpkt.h | 31 ++++++++++--------------
 2 files changed, 24 insertions(+), 29 deletions(-)

-- 
2.18.0


             reply	other threads:[~2018-07-25 22:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 22:16 John Whitmore [this message]
2018-07-25 22:16 ` [PATCH 01/10] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style John Whitmore
2018-07-29  8:10   ` Greg KH
2018-07-29  9:46     ` John Whitmore
2018-07-25 22:16 ` [PATCH 02/10] staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE " John Whitmore
2018-07-25 22:16 ` [PATCH 03/10] staging:rtl8192u: Rename bit definition ISR_TxBcnOk " John Whitmore
2018-07-25 22:16 ` [PATCH 04/10] staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE " John Whitmore
2018-07-25 22:16 ` [PATCH 05/10] staging:rtl8192u: Rename ISR_TxBcnErr bit definition " John Whitmore
2018-07-25 22:16 ` [PATCH 06/10] staging:rtl8192u: Rename ISR_BcnTimerIntr " John Whitmore
2018-07-25 22:16 ` [PATCH 07/10] staging:rtl8192u: Remove multiple blank lines " John Whitmore
2018-07-25 22:16 ` [PATCH 08/10] staging:rtl8192u: Correct spelling in comments - style John Whitmore
2018-07-25 22:16 ` [PATCH 09/10] staging:rtl8192u: Remove typedef of struct cmpk_intr_sta_t - Style John Whitmore
2018-07-25 22:16 ` [PATCH 10/10] staging:rtl8192u: Remove typedef from struct cmpk_set_cfg_t " John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725221630.28595-1-johnfwhitmore@gmail.com \
    --to=johnfwhitmore@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.