From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
pombredanne@nexb.com, kstewart@linuxfoundation.org,
tglx@linutronix.de, John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 10/10] staging:rtl8192u: Remove typedef from struct cmpk_set_cfg_t - Style
Date: Wed, 25 Jul 2018 23:16:30 +0100 [thread overview]
Message-ID: <20180725221630.28595-11-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180725221630.28595-1-johnfwhitmore@gmail.com>
Remove the typedef from struct cmpk_set_cfg_t. This change clears the
checkpatch issue with defining new types. The change is purely a coding
style change which should have no impact on runtime code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
index 1f33353bc135..490ee399169b 100644
--- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
+++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
@@ -288,7 +288,7 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)
*/
static void cmpk_handle_query_config_rx(struct net_device *dev, u8 *pmsg)
{
- cmpk_query_cfg_t rx_query_cfg;
+ struct cmpk_query_cfg_t rx_query_cfg;
/* 1. Extract TX feedback info from RFD to temp structure buffer. */
/* It seems that FW use big endian(MIPS) and DRV use little endian in
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
index 7854530f4745..17d28244cb36 100644
--- a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
+++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
@@ -3,7 +3,7 @@
#define R819XUSB_CMDPKT_H
/* Different command packet have dedicated message length and definition. */
#define CMPK_RX_TX_FB_SIZE sizeof(struct cmpk_txfb_t) /* 20 */
-#define CMPK_BOTH_QUERY_CONFIG_SIZE sizeof(cmpk_set_cfg_t) /* 16 */
+#define CMPK_BOTH_QUERY_CONFIG_SIZE sizeof(struct cmpk_set_cfg_t) /* 16 */
#define CMPK_RX_TX_STS_SIZE sizeof(cmpk_tx_status_t)
#define CMPK_TX_RAHIS_SIZE sizeof(cmpk_tx_rahis_t)
@@ -63,7 +63,7 @@ struct cmpk_intr_sta_t {
};
/* 3. TX side: Set configuration packet. */
-typedef struct tag_cmd_pkt_set_configuration {
+struct cmpk_set_cfg_t {
u8 element_id; /* Command packet type. */
u8 length; /* Command packet length. */
u16 reserve1;
@@ -78,7 +78,7 @@ typedef struct tag_cmd_pkt_set_configuration {
u8 cfg_offset;
u32 value;
u32 mask;
-} cmpk_set_cfg_t;
+};
/* 4. Both side : TX/RX query configuration packet. The query structure is the
* same as set configuration.
--
2.18.0
prev parent reply other threads:[~2018-07-25 22:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 22:16 [PATCH 00/10] staging:rtl8192u: Coding style - r819xU_cmdpkt.h John Whitmore
2018-07-25 22:16 ` [PATCH 01/10] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style John Whitmore
2018-07-29 8:10 ` Greg KH
2018-07-29 9:46 ` John Whitmore
2018-07-25 22:16 ` [PATCH 02/10] staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE " John Whitmore
2018-07-25 22:16 ` [PATCH 03/10] staging:rtl8192u: Rename bit definition ISR_TxBcnOk " John Whitmore
2018-07-25 22:16 ` [PATCH 04/10] staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE " John Whitmore
2018-07-25 22:16 ` [PATCH 05/10] staging:rtl8192u: Rename ISR_TxBcnErr bit definition " John Whitmore
2018-07-25 22:16 ` [PATCH 06/10] staging:rtl8192u: Rename ISR_BcnTimerIntr " John Whitmore
2018-07-25 22:16 ` [PATCH 07/10] staging:rtl8192u: Remove multiple blank lines " John Whitmore
2018-07-25 22:16 ` [PATCH 08/10] staging:rtl8192u: Correct spelling in comments - style John Whitmore
2018-07-25 22:16 ` [PATCH 09/10] staging:rtl8192u: Remove typedef of struct cmpk_intr_sta_t - Style John Whitmore
2018-07-25 22:16 ` John Whitmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725221630.28595-11-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.