All of lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH] nvme: drop WARN_ON() when processing ANA AEN
Date: Thu, 26 Jul 2018 12:57:02 +0200	[thread overview]
Message-ID: <20180726105702.80794-1-hare@suse.de> (raw)

We might be receiving ANA AENs at any time, so it might happen that
we're receiving an ANA AEN even before we have processed all ANA
information.
But this is nothing to worry about, and we can safely drop the
WARN_ON here.

Patch is relative to hchs nvme-ana tree.

Signed-off-by: Hannes Reinecke <hare at suse.com>
---
 drivers/nvme/host/core.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 39bdfe806d1b..3b96ace1f86d 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3382,10 +3382,11 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
 		break;
 #ifdef CONFIG_NVME_MULTIPATH
 	case NVME_AER_NOTICE_ANA:
-		if (WARN_ON_ONCE(!ctrl->ana_log_buf))
+		if (ctrl->ana_log_buf) {
+			queue_work(nvme_wq, &ctrl->ana_work);
 			break;
-		queue_work(nvme_wq, &ctrl->ana_work);
-		break;
+		}
+		dev_warn(ctrl->device, "ANA disabled, skipping AEN\n");
 #endif
 	default:
 		dev_warn(ctrl->device, "async event result %08x\n", result);
-- 
2.12.3

             reply	other threads:[~2018-07-26 10:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 10:57 Hannes Reinecke [this message]
2018-07-26 15:10 ` [PATCH] nvme: drop WARN_ON() when processing ANA AEN Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180726105702.80794-1-hare@suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.