All of lore.kernel.org
 help / color / mirror / Atom feed
* [lustre-devel] [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()
@ 2018-07-26 14:02 ` Jia-Ju Bai
  0 siblings, 0 replies; 6+ messages in thread
From: Jia-Ju Bai @ 2018-07-26 14:02 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, jsimmons, paf, namit
  Cc: lustre-devel, devel, linux-kernel

In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,

557. int ctx_refresh_timeout(...) {
 ??????????? .......
573. req->rq_cli_ctx->cc_ops->force_die(req->rq_cli_ctx, 0);
 ??????????? ......
575. }

For x86 kernel configuration, there is no assignment of the function 
pointer ".force_die" in the kernel code.
So calling the function pointer in line 573 may cause a null pointer 
dereference.


Best wishes,
Jia-Ju Bai

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()
@ 2018-07-26 14:02 ` Jia-Ju Bai
  0 siblings, 0 replies; 6+ messages in thread
From: Jia-Ju Bai @ 2018-07-26 14:02 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, jsimmons, paf, namit
  Cc: lustre-devel, devel, linux-kernel

In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,

557. int ctx_refresh_timeout(...) {
             .......
573. req->rq_cli_ctx->cc_ops->force_die(req->rq_cli_ctx, 0);
             ......
575. }

For x86 kernel configuration, there is no assignment of the function 
pointer ".force_die" in the kernel code.
So calling the function pointer in line 573 may cause a null pointer 
dereference.


Best wishes,
Jia-Ju Bai

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [lustre-devel] [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()
  2018-07-26 14:02 ` Jia-Ju Bai
@ 2018-07-26 14:12   ` Greg KH
  -1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-07-26 14:12 UTC (permalink / raw)
  To: Jia-Ju Bai
  Cc: oleg.drokin, andreas.dilger, jsimmons, paf, namit, devel,
	linux-kernel, lustre-devel

On Thu, Jul 26, 2018 at 10:02:22PM +0800, Jia-Ju Bai wrote:
> In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,

Please look at the 4.18-rc6 release for this file.

In short, nothing to worry about anymore :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()
@ 2018-07-26 14:12   ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-07-26 14:12 UTC (permalink / raw)
  To: Jia-Ju Bai
  Cc: oleg.drokin, andreas.dilger, jsimmons, paf, namit, devel,
	linux-kernel, lustre-devel

On Thu, Jul 26, 2018 at 10:02:22PM +0800, Jia-Ju Bai wrote:
> In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,

Please look at the 4.18-rc6 release for this file.

In short, nothing to worry about anymore :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [lustre-devel] [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()
  2018-07-26 14:12   ` Greg KH
@ 2018-07-26 14:18     ` Jia-Ju Bai
  -1 siblings, 0 replies; 6+ messages in thread
From: Jia-Ju Bai @ 2018-07-26 14:18 UTC (permalink / raw)
  To: Greg KH
  Cc: oleg.drokin, andreas.dilger, jsimmons, paf, namit, devel,
	linux-kernel, lustre-devel



On 2018/7/26 22:12, Greg KH wrote:
> On Thu, Jul 26, 2018 at 10:02:22PM +0800, Jia-Ju Bai wrote:
>> In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,
> Please look at the 4.18-rc6 release for this file.
>
> In short, nothing to worry about anymore :)

Looks good now :)


Best wishes,
Jia-Ju Bai

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()
@ 2018-07-26 14:18     ` Jia-Ju Bai
  0 siblings, 0 replies; 6+ messages in thread
From: Jia-Ju Bai @ 2018-07-26 14:18 UTC (permalink / raw)
  To: Greg KH
  Cc: oleg.drokin, andreas.dilger, jsimmons, paf, namit, devel,
	linux-kernel, lustre-devel



On 2018/7/26 22:12, Greg KH wrote:
> On Thu, Jul 26, 2018 at 10:02:22PM +0800, Jia-Ju Bai wrote:
>> In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,
> Please look at the 4.18-rc6 release for this file.
>
> In short, nothing to worry about anymore :)

Looks good now :)


Best wishes,
Jia-Ju Bai

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-07-26 14:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26 14:02 [lustre-devel] [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout() Jia-Ju Bai
2018-07-26 14:02 ` Jia-Ju Bai
2018-07-26 14:12 ` [lustre-devel] " Greg KH
2018-07-26 14:12   ` Greg KH
2018-07-26 14:18   ` [lustre-devel] " Jia-Ju Bai
2018-07-26 14:18     ` Jia-Ju Bai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.