All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/lvm2: Fix runtime crash when using uclibc
Date: Thu, 26 Jul 2018 15:42:23 +0200	[thread overview]
Message-ID: <20180726154223.390beed1@windsurf> (raw)
In-Reply-To: <20180726131023.28695-1-m.niestroj@grinn-global.com>

Hello,

Thanks for this new iteration.

On Thu, 26 Jul 2018 15:10:22 +0200, Marcin Niestroj wrote:

> + configure                 | 32 ++++++++++++++++++++++++++++++--

I missed that in the review of the previous version. Is there a reason
to patch the configure script itself? In Buildroot, our general rule is
to not patch configure, but instead patch configure.ac and use
<pkg>_AUTORECONF = YES to regenerate the configure script.

Is there a reason to not follow this rule in this specific situation ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-07-26 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 13:10 [Buildroot] [PATCH v2 1/2] package/lvm2: Fix runtime crash when using uclibc Marcin Niestroj
2018-07-26 13:10 ` [Buildroot] [PATCH v2 2/2] package/lvm2: bump version to 2.02.180 Marcin Niestroj
2018-07-26 15:57   ` Baruch Siach
2018-07-26 13:42 ` Thomas Petazzoni [this message]
2018-07-26 13:54   ` [Buildroot] [PATCH v2 1/2] package/lvm2: Fix runtime crash when using uclibc Marcin Niestroj
2018-07-26 14:12     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180726154223.390beed1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.