From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH v3 00/23] Add multi-channel support to Armada thermal driver Date: Thu, 26 Jul 2018 15:14:24 -0700 Message-ID: <20180726221423.GA3569@localhost.localdomain> References: <20180716144206.30985-1-miquel.raynal@bootlin.com> <20180718172849.30b7cec0@xps13> <20180725095222.054f1e80@xps13> <1532570441.2358.27.camel@intel.com> <20180726211442.GB3487@localhost.localdomain> <20180726213517.GA15690@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180726213517.GA15690@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Zhang Rui Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Maxime Chevallier , Nadav Haklai , David Sniatkiwicz , Rob Herring , Thomas Petazzoni , Miquel Raynal , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org T24gVGh1LCBKdWwgMjYsIDIwMTggYXQgMDI6MzU6MThQTSAtMDcwMCwgRWR1YXJkbyBWYWxlbnRp biB3cm90ZToKPiBPbiBUaHUsIEp1bCAyNiwgMjAxOCBhdCAwMjoxNDo0M1BNIC0wNzAwLCBFZHVh cmRvIFZhbGVudGluIHdyb3RlOgo+ID4gSGVsbG8sCj4gPiAKPiA+IE9uIFRodSwgSnVsIDI2LCAy MDE4IGF0IDEwOjAwOjQxQU0gKzA4MDAsIFpoYW5nIFJ1aSB3cm90ZToKPiA+ID4gT24g5LiJLCAy MDE4LTA3LTI1IGF0IDA5OjUyICswMjAwLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ID4gPiA+IEhp IEVkdWFyZG8sIFpoYW5nLAo+ID4gPiA+IAo+ID4gPiA+IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5y YXluYWxAYm9vdGxpbi5jb20+IHdyb3RlIG9uIFdlZCwgMTggSnVsIDIwMTgKPiA+ID4gPiAxNzoy ODo0OSArMDIwMDoKPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gSGkgRWR1YXJkbywKPiA+ ID4gPiA+IAo+ID4gPiA+ID4gTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNv bT4gd3JvdGUgb24gTW9uLCAxNiBKdWwgMjAxOAo+ID4gPiA+ID4gMTY6NDE6NDMgKzAyMDA6Cj4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoZSBvbmx5IGNhcGFiaWxpdHkgb2Yg dGhlIEFybWFkYSB0aGVybWFsIGRyaXZlciBpcyBjdXJyZW50bHkKPiA+ID4gPiA+ID4ganVzdCB0 bwo+ID4gPiA+ID4gPiByZWFkIG9uZSBzZW5zb3IgKHRoZSBkZWZhdWx0IG9uZSkgcGVyIEFQIGFu ZCBvbmUgcGVyIENQLgo+ID4gPiA+ID4gPiBBY3R1YWxseSwKPiA+ID4gPiA+ID4gdGhlcmUgaXMg b25lIHNlbnNvciBwZXIgY29yZSBpbiB0aGUgQVA4MDYgcGx1cyBvbmUgc2Vuc29yIGluIHRoZQo+ ID4gPiA+ID4gPiB0aGVybWFsIElQIGl0c2VsZi4gVGhlIENQMTEwIGp1c3QgZmVhdHVyZXMgb25l IHRoZXJtYWwgc2Vuc29yIGluCj4gPiA+ID4gPiA+IGl0cwo+ID4gPiA+ID4gPiBvd24gdGhlcm1h bCBJUC4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoaXMgc2VyaWVzIGZpcnN0IGltcHJvdmVz IHRoZSByZWFkYWJpbGl0eSBvZiB0aGlzIGRyaXZlciwgdGhlbgo+ID4gPiA+ID4gPiBhZGRzCj4g PiA+ID4gPiA+IHN1cHBvcnQgZm9yIG11bHRpLWNoYW5uZWwgdGhlcm1hbCBJUHMuIFRoZSBiaW5k aW5ncyBhbmQgdGhlCj4gPiA+ID4gPiA+IGRldmljZS10cmVlcyBhcmUgdXBkYXRlZCBhY2NvcmRp bmdseS4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoYW5rIHlvdSwKPiA+ID4gPiA+ID4gTWlx dcOobMKgwqAKPiA+ID4gPiA+IEkga25vdyBJIHNlbnQgdGhpcyBzZXJpZXMgb24gbW9uZGF5IGJ1 dCB0aGVyZSB3YXMgYWxtb3N0IG5vIGNoYW5nZQo+ID4gPiA+ID4gb24KPiA+ID4gPiA+IGl0IChz ZWUgYmVsb3cpLCBkbyB5b3UgdGhpbmsgeW91IHdpbGwgaGF2ZSB0aGUgdGltZSB0byBsb29rIGF0 IGl0Cj4gPiA+ID4gPiBiZWZvcmUgaXQncyB0b28gbGF0ZSBmb3IgdGhlIG1lcmdlIHdpbmRvdz8K PiA+ID4gPiBJIGtub3cgYSBsaXR0bGUgYml0IHdoYXQgaXQgaXMgdG8gYmUgb24gdGhlIG1haW50 YWluZXIgc2lkZSBvZiBhCj4gPiA+ID4gc3Vic3lzdGVtIGJ1dCB0aGVzZSBjaGFuZ2VzIGFyZSBs YXlpbmcgc2luY2UgQXByaWwsIDIxc3QgYW5kIEkgcmVhbGx5Cj4gPiA+ID4gZXhwZWN0IHRvIGdl dCB0aGVtIG1lcmdlZC4gWmhhbmcsIGFzIEVkdWFyZG8gc2VlbXMgdG8gYmUgb3ZlcmxvYWRlZAo+ ID4gPiA+IHRoaXMgcmVsZWFzZSwgY291bGQgeW91IHBsZWFzZSB0YWtlIHRoZSBzZXJpZXM/Cj4g PiA+ID4gCj4gPiA+ID4gT2YgY291cnNlIGlmIHRoZXJlIGFyZSB0aGluZ3MgdG8gYWRkcmVzcyBJ J2xsIGJlIGhhcHB5IHRvIGRvIHNvLgo+ID4gPiA+IAo+ID4gPiBJIGhhZCBhIHN5bmMgd2l0aCBF ZHVhcmRvIGR1cmluZyBsYXN0IG1lcmdlIHdpbmRvdywgYW5kIHdlIGFncmVlZCB0bwo+ID4gPiBz ZW5kIHNlcGFyYXRlIGdpdCBwdWxsIHJlcXVlc3RzIHRvIExpbnVzIHNpbmNlIHRoaXMgcmVsZWFz ZSBhbmQgc2VlIGhvdwo+ID4gPiBpdCB3b3Jrcy4KPiA+ID4gVGhpcyBtZWFucyB0aGF0IGFsbCB0 aGUgc29jIHRoZXJtYWwgZHJpdmVyIHBhdGNoZXMgc2hvdWxkIGdvIHRvCj4gPiA+IEVkdWFyZG8n IHRyZWUgYW5kIHRoZW4gTGludXMnIHRyZWUgZGlyZWN0bHkuCj4gPiA+IAo+ID4gPiBBbnl3YXks IGxldCdzIHBpbmcgRWR1YXJkbyBhbmQgc2VlIGlmIGhlIGNhbiByZXZpZXcvdGFrZSB0aGUgcGF0 Y2hlcy4KPiA+IAo+ID4gU29ycnkgZmVsbG93cywgYnV0IEkgd2FzIG9mZiBjYW1waW5nIGluIGEg cGxhY2Ugd2l0aCBubyBlbGVjdHJpY2l0eS9ubwo+ID4gaW50ZXJuZXQuIEkgbG9va2VkIGF0IHRo aXMgc2VyaWVzIGJlZm9yZSwgYW5kIEkgZG8gbm90IHJlbWVtYmVyIGFueXRoaW5nCj4gPiB0aGF0 IGNvdWxkIGJsb2NrIGl0IHRvIGdvLiBMZXQgbWUgcmVzdGFydCBvbiB3b3JraW5nIG9uIGl0Lgo+ IAo+IExldCBtZSB0YWtlIHRoYXQgYmFjay4gSSBnb3Qgc29tZSBjb21waWxhdGlvbiBlcnJvci4K CgpHaXZlbiB0aGF0IEkgbGV0IHRoaXMgb25lIGZhbGwgaW50byB0aGUgY3JhY2tzIGFuZCB0aGF0 IHRoZXNlIGFyZSBtaW5vcgppc3N1ZXMsIEkgZml4ZWQgdGhlbSBtYW51YWxseSwgYW5kIGFwcGxp ZWQgdXAgdG8gcGF0Y2ggMTkuIEJ1dCBuZXh0IGF0CmxlYXN0IGNvbXBpbGUgdGVzdCB5b3VyIHNl cmllcyBhbmQgcnVuIGNoZWNrcGF0Y2ggb24gdGhlbS4KClBhdGNoZXMgMjAtMjMgbmVlZCB0byBn byB2aWEgeW91ciBhcmNoIHRyZWUuCgo+IAo+ID4gCj4gPiA+IAo+ID4gPiB0aGFua3MsCj4gPiA+ IHJ1aQo+ID4gPiA+IFRoYW5rcywKPiA+ID4gPiBNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: edubezval@gmail.com (Eduardo Valentin) Date: Thu, 26 Jul 2018 15:14:24 -0700 Subject: [PATCH v3 00/23] Add multi-channel support to Armada thermal driver In-Reply-To: <20180726213517.GA15690@localhost.localdomain> References: <20180716144206.30985-1-miquel.raynal@bootlin.com> <20180718172849.30b7cec0@xps13> <20180725095222.054f1e80@xps13> <1532570441.2358.27.camel@intel.com> <20180726211442.GB3487@localhost.localdomain> <20180726213517.GA15690@localhost.localdomain> Message-ID: <20180726221423.GA3569@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jul 26, 2018 at 02:35:18PM -0700, Eduardo Valentin wrote: > On Thu, Jul 26, 2018 at 02:14:43PM -0700, Eduardo Valentin wrote: > > Hello, > > > > On Thu, Jul 26, 2018 at 10:00:41AM +0800, Zhang Rui wrote: > > > On ?, 2018-07-25 at 09:52 +0200, Miquel Raynal wrote: > > > > Hi Eduardo, Zhang, > > > > > > > > Miquel Raynal wrote on Wed, 18 Jul 2018 > > > > 17:28:49 +0200: > > > > > > > > > > > > > > Hi Eduardo, > > > > > > > > > > Miquel Raynal wrote on Mon, 16 Jul 2018 > > > > > 16:41:43 +0200: > > > > > > > > > > > > > > > > > The only capability of the Armada thermal driver is currently > > > > > > just to > > > > > > read one sensor (the default one) per AP and one per CP. > > > > > > Actually, > > > > > > there is one sensor per core in the AP806 plus one sensor in the > > > > > > thermal IP itself. The CP110 just features one thermal sensor in > > > > > > its > > > > > > own thermal IP. > > > > > > > > > > > > This series first improves the readability of this driver, then > > > > > > adds > > > > > > support for multi-channel thermal IPs. The bindings and the > > > > > > device-trees are updated accordingly. > > > > > > > > > > > > Thank you, > > > > > > Miqu?l?? > > > > > I know I sent this series on monday but there was almost no change > > > > > on > > > > > it (see below), do you think you will have the time to look at it > > > > > before it's too late for the merge window? > > > > I know a little bit what it is to be on the maintainer side of a > > > > subsystem but these changes are laying since April, 21st and I really > > > > expect to get them merged. Zhang, as Eduardo seems to be overloaded > > > > this release, could you please take the series? > > > > > > > > Of course if there are things to address I'll be happy to do so. > > > > > > > I had a sync with Eduardo during last merge window, and we agreed to > > > send separate git pull requests to Linus since this release and see how > > > it works. > > > This means that all the soc thermal driver patches should go to > > > Eduardo' tree and then Linus' tree directly. > > > > > > Anyway, let's ping Eduardo and see if he can review/take the patches. > > > > Sorry fellows, but I was off camping in a place with no electricity/no > > internet. I looked at this series before, and I do not remember anything > > that could block it to go. Let me restart on working on it. > > Let me take that back. I got some compilation error. Given that I let this one fall into the cracks and that these are minor issues, I fixed them manually, and applied up to patch 19. But next at least compile test your series and run checkpatch on them. Patches 20-23 need to go via your arch tree. > > > > > > > > > thanks, > > > rui > > > > Thanks, > > > > Miqu?l