From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v3 00/23] Add multi-channel support to Armada thermal driver Date: Fri, 27 Jul 2018 00:59:28 +0200 Message-ID: <20180727005928.6bbe021f@xps13> References: <20180716144206.30985-1-miquel.raynal@bootlin.com> <20180718172849.30b7cec0@xps13> <20180725095222.054f1e80@xps13> <1532570441.2358.27.camel@intel.com> <20180726211442.GB3487@localhost.localdomain> <20180726213517.GA15690@localhost.localdomain> <20180726221423.GA3569@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180726221423.GA3569@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Eduardo Valentin Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Maxime Chevallier , Nadav Haklai , David Sniatkiwicz , Rob Herring , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgRWR1YXJkbywKCkVkdWFyZG8gVmFsZW50aW4gPGVkdWJlenZhbEBnbWFpbC5jb20+IHdyb3Rl IG9uIFRodSwgMjYgSnVsIDIwMTgKMTU6MTQ6MjQgLTA3MDA6Cgo+IE9uIFRodSwgSnVsIDI2LCAy MDE4IGF0IDAyOjM1OjE4UE0gLTA3MDAsIEVkdWFyZG8gVmFsZW50aW4gd3JvdGU6Cj4gPiBPbiBU aHUsIEp1bCAyNiwgMjAxOCBhdCAwMjoxNDo0M1BNIC0wNzAwLCBFZHVhcmRvIFZhbGVudGluIHdy b3RlOiAgCj4gPiA+IEhlbGxvLAo+ID4gPiAKPiA+ID4gT24gVGh1LCBKdWwgMjYsIDIwMTggYXQg MTA6MDA6NDFBTSArMDgwMCwgWmhhbmcgUnVpIHdyb3RlOiAgCj4gPiA+ID4gT24g5LiJLCAyMDE4 LTA3LTI1IGF0IDA5OjUyICswMjAwLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPiA+ID4gPiBI aSBFZHVhcmRvLCBaaGFuZywKPiA+ID4gPiA+IAo+ID4gPiA+ID4gTWlxdWVsIFJheW5hbCA8bWlx dWVsLnJheW5hbEBib290bGluLmNvbT4gd3JvdGUgb24gV2VkLCAxOCBKdWwgMjAxOAo+ID4gPiA+ ID4gMTc6Mjg6NDkgKzAyMDA6Cj4gPiA+ID4gPiAgIAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g SGkgRWR1YXJkbywKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IE1pcXVlbCBSYXluYWwgPG1pcXVl bC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3RlIG9uIE1vbiwgMTYgSnVsIDIwMTgKPiA+ID4gPiA+ ID4gMTY6NDE6NDMgKzAyMDA6Cj4gPiA+ID4gPiA+ICAgCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4g PiA+ID4gVGhlIG9ubHkgY2FwYWJpbGl0eSBvZiB0aGUgQXJtYWRhIHRoZXJtYWwgZHJpdmVyIGlz IGN1cnJlbnRseQo+ID4gPiA+ID4gPiA+IGp1c3QgdG8KPiA+ID4gPiA+ID4gPiByZWFkIG9uZSBz ZW5zb3IgKHRoZSBkZWZhdWx0IG9uZSkgcGVyIEFQIGFuZCBvbmUgcGVyIENQLgo+ID4gPiA+ID4g PiA+IEFjdHVhbGx5LAo+ID4gPiA+ID4gPiA+IHRoZXJlIGlzIG9uZSBzZW5zb3IgcGVyIGNvcmUg aW4gdGhlIEFQODA2IHBsdXMgb25lIHNlbnNvciBpbiB0aGUKPiA+ID4gPiA+ID4gPiB0aGVybWFs IElQIGl0c2VsZi4gVGhlIENQMTEwIGp1c3QgZmVhdHVyZXMgb25lIHRoZXJtYWwgc2Vuc29yIGlu Cj4gPiA+ID4gPiA+ID4gaXRzCj4gPiA+ID4gPiA+ID4gb3duIHRoZXJtYWwgSVAuCj4gPiA+ID4g PiA+ID4gCj4gPiA+ID4gPiA+ID4gVGhpcyBzZXJpZXMgZmlyc3QgaW1wcm92ZXMgdGhlIHJlYWRh YmlsaXR5IG9mIHRoaXMgZHJpdmVyLCB0aGVuCj4gPiA+ID4gPiA+ID4gYWRkcwo+ID4gPiA+ID4g PiA+IHN1cHBvcnQgZm9yIG11bHRpLWNoYW5uZWwgdGhlcm1hbCBJUHMuIFRoZSBiaW5kaW5ncyBh bmQgdGhlCj4gPiA+ID4gPiA+ID4gZGV2aWNlLXRyZWVzIGFyZSB1cGRhdGVkIGFjY29yZGluZ2x5 Lgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IFRoYW5rIHlvdSwKPiA+ID4gPiA+ID4gPiBN aXF1w6hswqDCoCAgCj4gPiA+ID4gPiA+IEkga25vdyBJIHNlbnQgdGhpcyBzZXJpZXMgb24gbW9u ZGF5IGJ1dCB0aGVyZSB3YXMgYWxtb3N0IG5vIGNoYW5nZQo+ID4gPiA+ID4gPiBvbgo+ID4gPiA+ ID4gPiBpdCAoc2VlIGJlbG93KSwgZG8geW91IHRoaW5rIHlvdSB3aWxsIGhhdmUgdGhlIHRpbWUg dG8gbG9vayBhdCBpdAo+ID4gPiA+ID4gPiBiZWZvcmUgaXQncyB0b28gbGF0ZSBmb3IgdGhlIG1l cmdlIHdpbmRvdz8gIAo+ID4gPiA+ID4gSSBrbm93IGEgbGl0dGxlIGJpdCB3aGF0IGl0IGlzIHRv IGJlIG9uIHRoZSBtYWludGFpbmVyIHNpZGUgb2YgYQo+ID4gPiA+ID4gc3Vic3lzdGVtIGJ1dCB0 aGVzZSBjaGFuZ2VzIGFyZSBsYXlpbmcgc2luY2UgQXByaWwsIDIxc3QgYW5kIEkgcmVhbGx5Cj4g PiA+ID4gPiBleHBlY3QgdG8gZ2V0IHRoZW0gbWVyZ2VkLiBaaGFuZywgYXMgRWR1YXJkbyBzZWVt cyB0byBiZSBvdmVybG9hZGVkCj4gPiA+ID4gPiB0aGlzIHJlbGVhc2UsIGNvdWxkIHlvdSBwbGVh c2UgdGFrZSB0aGUgc2VyaWVzPwo+ID4gPiA+ID4gCj4gPiA+ID4gPiBPZiBjb3Vyc2UgaWYgdGhl cmUgYXJlIHRoaW5ncyB0byBhZGRyZXNzIEknbGwgYmUgaGFwcHkgdG8gZG8gc28uCj4gPiA+ID4g PiAgIAo+ID4gPiA+IEkgaGFkIGEgc3luYyB3aXRoIEVkdWFyZG8gZHVyaW5nIGxhc3QgbWVyZ2Ug d2luZG93LCBhbmQgd2UgYWdyZWVkIHRvCj4gPiA+ID4gc2VuZCBzZXBhcmF0ZSBnaXQgcHVsbCBy ZXF1ZXN0cyB0byBMaW51cyBzaW5jZSB0aGlzIHJlbGVhc2UgYW5kIHNlZSBob3cKPiA+ID4gPiBp dCB3b3Jrcy4KPiA+ID4gPiBUaGlzIG1lYW5zIHRoYXQgYWxsIHRoZSBzb2MgdGhlcm1hbCBkcml2 ZXIgcGF0Y2hlcyBzaG91bGQgZ28gdG8KPiA+ID4gPiBFZHVhcmRvJyB0cmVlIGFuZCB0aGVuIExp bnVzJyB0cmVlIGRpcmVjdGx5Lgo+ID4gPiA+IAo+ID4gPiA+IEFueXdheSwgbGV0J3MgcGluZyBF ZHVhcmRvIGFuZCBzZWUgaWYgaGUgY2FuIHJldmlldy90YWtlIHRoZSBwYXRjaGVzLiAgCj4gPiA+ IAo+ID4gPiBTb3JyeSBmZWxsb3dzLCBidXQgSSB3YXMgb2ZmIGNhbXBpbmcgaW4gYSBwbGFjZSB3 aXRoIG5vIGVsZWN0cmljaXR5L25vCj4gPiA+IGludGVybmV0LiBJIGxvb2tlZCBhdCB0aGlzIHNl cmllcyBiZWZvcmUsIGFuZCBJIGRvIG5vdCByZW1lbWJlciBhbnl0aGluZwo+ID4gPiB0aGF0IGNv dWxkIGJsb2NrIGl0IHRvIGdvLiBMZXQgbWUgcmVzdGFydCBvbiB3b3JraW5nIG9uIGl0LiAgCgpO byBwcm9ibGVtLgoKPiA+IAo+ID4gTGV0IG1lIHRha2UgdGhhdCBiYWNrLiBJIGdvdCBzb21lIGNv bXBpbGF0aW9uIGVycm9yLiAgCj4gCj4gCj4gR2l2ZW4gdGhhdCBJIGxldCB0aGlzIG9uZSBmYWxs IGludG8gdGhlIGNyYWNrcyBhbmQgdGhhdCB0aGVzZSBhcmUgbWlub3IKPiBpc3N1ZXMsIEkgZml4 ZWQgdGhlbSBtYW51YWxseSwgYW5kIGFwcGxpZWQgdXAgdG8gcGF0Y2ggMTkuIEJ1dCBuZXh0IGF0 Cj4gbGVhc3QgY29tcGlsZSB0ZXN0IHlvdXIgc2VyaWVzIGFuZCBydW4gY2hlY2twYXRjaCBvbiB0 aGVtLgoKSSB3YXMgcmVhbGx5IHN1cnByaXNlZCBvZiB5b3VyIHJlbWFyayBidXQgaW5kZWVkIHRo ZXJlIHdhcyBhIGJ1aWxkCmlzc3VlIGluIHRoZSBtaWRkbGUgb2YgdGhlIHNlcmllcyB0aGF0IEkg ZGlkIG5vdCBzZWUgYmVjYXVzZSBJIGFsd2F5cwp0ZXN0IHdpdGggYSBsYXN0IHBhdGNoIGZpeGlu ZyBpdCAodGhpcyBwYXRjaCBhZGRzIGludGVycnVwdCBzdXBwb3J0LCBJCnBsYW4gdG8gc2VuZCBp dCBmb3IgdGhlIG5leHQgcmVsZWFzZSkuIEknbSB2ZXJ5IHNvcnJ5IGZvciB0aGlzCm1pc3Rha2Us IHRoYW5rcyBmb3IgZml4aW5nIGl0IGJ5IHlvdXJzZWxmLgoKPiAKPiBQYXRjaGVzIDIwLTIzIG5l ZWQgdG8gZ28gdmlhIHlvdXIgYXJjaCB0cmVlLgoKU3VyZSwgdGhleSB3aWxsIGVudGVyIGluIHRo ZSBuZXh0IHJlbGVhc2Ugbm93LgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Fri, 27 Jul 2018 00:59:28 +0200 Subject: [PATCH v3 00/23] Add multi-channel support to Armada thermal driver In-Reply-To: <20180726221423.GA3569@localhost.localdomain> References: <20180716144206.30985-1-miquel.raynal@bootlin.com> <20180718172849.30b7cec0@xps13> <20180725095222.054f1e80@xps13> <1532570441.2358.27.camel@intel.com> <20180726211442.GB3487@localhost.localdomain> <20180726213517.GA15690@localhost.localdomain> <20180726221423.GA3569@localhost.localdomain> Message-ID: <20180727005928.6bbe021f@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Eduardo, Eduardo Valentin wrote on Thu, 26 Jul 2018 15:14:24 -0700: > On Thu, Jul 26, 2018 at 02:35:18PM -0700, Eduardo Valentin wrote: > > On Thu, Jul 26, 2018 at 02:14:43PM -0700, Eduardo Valentin wrote: > > > Hello, > > > > > > On Thu, Jul 26, 2018 at 10:00:41AM +0800, Zhang Rui wrote: > > > > On ?, 2018-07-25 at 09:52 +0200, Miquel Raynal wrote: > > > > > Hi Eduardo, Zhang, > > > > > > > > > > Miquel Raynal wrote on Wed, 18 Jul 2018 > > > > > 17:28:49 +0200: > > > > > > > > > > > > > > > > > Hi Eduardo, > > > > > > > > > > > > Miquel Raynal wrote on Mon, 16 Jul 2018 > > > > > > 16:41:43 +0200: > > > > > > > > > > > > > > > > > > > > The only capability of the Armada thermal driver is currently > > > > > > > just to > > > > > > > read one sensor (the default one) per AP and one per CP. > > > > > > > Actually, > > > > > > > there is one sensor per core in the AP806 plus one sensor in the > > > > > > > thermal IP itself. The CP110 just features one thermal sensor in > > > > > > > its > > > > > > > own thermal IP. > > > > > > > > > > > > > > This series first improves the readability of this driver, then > > > > > > > adds > > > > > > > support for multi-channel thermal IPs. The bindings and the > > > > > > > device-trees are updated accordingly. > > > > > > > > > > > > > > Thank you, > > > > > > > Miqu?l?? > > > > > > I know I sent this series on monday but there was almost no change > > > > > > on > > > > > > it (see below), do you think you will have the time to look at it > > > > > > before it's too late for the merge window? > > > > > I know a little bit what it is to be on the maintainer side of a > > > > > subsystem but these changes are laying since April, 21st and I really > > > > > expect to get them merged. Zhang, as Eduardo seems to be overloaded > > > > > this release, could you please take the series? > > > > > > > > > > Of course if there are things to address I'll be happy to do so. > > > > > > > > > I had a sync with Eduardo during last merge window, and we agreed to > > > > send separate git pull requests to Linus since this release and see how > > > > it works. > > > > This means that all the soc thermal driver patches should go to > > > > Eduardo' tree and then Linus' tree directly. > > > > > > > > Anyway, let's ping Eduardo and see if he can review/take the patches. > > > > > > Sorry fellows, but I was off camping in a place with no electricity/no > > > internet. I looked at this series before, and I do not remember anything > > > that could block it to go. Let me restart on working on it. No problem. > > > > Let me take that back. I got some compilation error. > > > Given that I let this one fall into the cracks and that these are minor > issues, I fixed them manually, and applied up to patch 19. But next at > least compile test your series and run checkpatch on them. I was really surprised of your remark but indeed there was a build issue in the middle of the series that I did not see because I always test with a last patch fixing it (this patch adds interrupt support, I plan to send it for the next release). I'm very sorry for this mistake, thanks for fixing it by yourself. > > Patches 20-23 need to go via your arch tree. Sure, they will enter in the next release now. Thanks, Miqu?l