All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Stable <stable@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [PATCH] net : sched: cls_api: deal with egdev path only if needed
Date: Fri, 27 Jul 2018 08:36:50 +0200	[thread overview]
Message-ID: <20180727063650.GC28872@kroah.com> (raw)
In-Reply-To: <CAJ3xEMgVfo26WTfvPNJv++J9a=mxexBpfvcX-_69MaaQffrYRQ@mail.gmail.com>

On Thu, Jul 26, 2018 at 08:46:22PM +0300, Or Gerlitz wrote:
> On Thu, Jul 26, 2018 at 8:45 PM, Or Gerlitz <ogerlitz@mellanox.com> wrote:
> > [ Upstream commit f8f4bef322e4600c5856911c7a632c0e3da920d6 ]
> >
> > When dealing with ingress rule on a netdev, if we did fine through the
> > conventional path, there's no need to continue into the egdev route,
> > and we can stop right there.
> >
> > Not doing so may cause a 2nd rule to be added by the cls api layer
> > with the ingress being the egdev.
> >
> > For example, under sriov switchdev scheme, a user rule of VFR A --> VFR B
> > will end up with two HW rules (1) VF A --> VF B and (2) uplink --> VF B
> >
> > Fixes: 208c0f4b5237 ('net: sched: use tc_setup_cb_call to call per-block callbacks')
> > Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >
> > Hi Greg,
> >
> > The commit that introduced the problem dates to 4.15 and the fix made
> > on 4.17. I see the fix was pushed to 4.16-stable but not to 4.15-stable,
> > so sending it now.
> 
> Sorry for not marking it on the subject line, but this is  for 4.15-stable

4.15 is long end-of-life, sorry, there's nothing I can do for that
kernel anymore.  Please always look at the front page of kernel.org for
what kernels are still "alive" when doing backports so you don't end up
doing work for no reason.

sorry,

greg k-h

  reply	other threads:[~2018-07-27  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 17:45 [PATCH] net : sched: cls_api: deal with egdev path only if needed Or Gerlitz
2018-07-26 17:46 ` Or Gerlitz
2018-07-27  6:36   ` Greg KH [this message]
2018-07-27  6:42     ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727063650.GC28872@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=gerlitz.or@gmail.com \
    --cc=ogerlitz@mellanox.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.