From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/uboot-tools: version.h collision
Date: Fri, 27 Jul 2018 09:03:47 +0200 [thread overview]
Message-ID: <20180727090347.2b0de571@windsurf> (raw)
In-Reply-To: <20180727035044.4313-1-matthew.weber@rockwellcollins.com>
Hello,
On Thu, 26 Jul 2018 22:50:44 -0500, Matt Weber wrote:
> On some systems the host system or even the cross sysroot can
> contain a version.h. This leads to the wrong file being picked
> up and a PLAIN_VERSION undefined error.
>
> This workaround symlinks the version.h into the tool folder to
> allow reordering of search folders.
>
> Fixes
> http://autobuild.buildroot.net/results/770/7702d5df36a6532aafdbe6e9e62709bbfa058b54/build-end.log
> http://autobuild.buildroot.net/results/e34/e3401027d2fb3ce565ca9e2456a427afd3610a87/build-end.log
> ... additional can be found with these queries ...
> http://autobuild.buildroot.net/?reason=uboot-tools-2018.03
> http://autobuild.buildroot.net/?reason=uboot-tools-2018.05
>
> Upstream: https://lists.denx.de/pipermail/u-boot/2018-July/336283.html
>
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
This issue has already been fixed. It was btrfs-progs that was
installing a version.h header directly in usr/include. It has been
fixed by:
https://git.buildroot.org/buildroot/commit/package/btrfs-progs?id=83b40e1ea2e3ce046d7db442b01c3bfe52886ce8
I agree it is nice to fix it properly upstream so that the presence of
a header with a conflicting name doesn't confuse U-Boot, but I don't
think it's worth having this patch in Buildroot since the problem no
longer occurs.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-27 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 3:50 [Buildroot] [PATCH] package/uboot-tools: version.h collision Matt Weber
2018-07-27 7:03 ` Thomas Petazzoni [this message]
2018-07-27 13:46 ` Matthew Weber
2018-07-27 14:00 ` Thomas Petazzoni
2018-07-27 14:14 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727090347.2b0de571@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.