From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v3 01/23] thermal: armada: add a function that sanitizes the thermal zone name Date: Fri, 27 Jul 2018 13:52:30 +0200 Message-ID: <20180727135230.3c7102c7@xps13> References: <20180716144206.30985-1-miquel.raynal@bootlin.com> <20180716144206.30985-2-miquel.raynal@bootlin.com> <84f97022-a470-f314-ee75-e5afb733bea5@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <84f97022-a470-f314-ee75-e5afb733bea5@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Daniel Lezcano Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Rob Herring , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgRGFuaWVsLAoKRGFuaWVsIExlemNhbm8gPGRhbmllbC5sZXpjYW5vQGxpbmFyby5vcmc+IHdy b3RlIG9uIEZyaSwgMjcgSnVsIDIwMTgKMTM6MzQ6MTkgKzAyMDA6Cgo+IE9uIDE2LzA3LzIwMTgg MTY6NDEsIE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBUaGVybWFsIHpvbmUgbmFtZXMgbXVzdCBm b2xsb3cgY2VydGFpbiBydWxlcyBpbXBvc2VkIGJ5IHRoZSBmcmFtZXdvcmsuCj4gPiBUaGV5IGFy ZSBsaW1pdGVkIGluIGxlbmd0aCBhbmQgc2hhbGwgbm90IGhhdmUgYW55IGh5cGhlbiAnLScuCj4g PiAKPiA+IFRoaXMgaXMgZG9uZSBpbiBhIHNlcGFyYXRlIGZ1bmN0aW9uIGZvciBmdXR1cmUgdXNl IGluIGFub3RoZXIgbG9jYXRpb24uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXlu YWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+ICAKPiAKPiBXaHkgZG8geW91IGhhdmUgdG8g cHJvdmlkZSBhIGZ1bmN0aW9uIHRvIHRlc3QgdGhhdD8KPiAKPiBMb2dpY2FsbHksIHRoZSBvbmUg d2hvIGRpZCB0aGUgY2hhbmdlIHRvIGFkZCBhIHRoZXJtYWwgbmFtZSwgc2hvdWxkCj4gY2hlY2sg aXRzIGNvZGUgd29ya3MuIFdpdGhvdXQgYSBwcm9wZXIgbmFtZSB0aGF0IHdvbid0IHdvcmsuCgpX aGF0IGRvIHlvdSBtZWFuICJ0aGUgb25lIHdobyBkaWQgdGhlIGNoYW5nZSI/CkkgdGhpbmsgdGhl IHRoZXJtYWwgY29yZSBzaG91bGQgbm90IGNhcmUgdGhhdCBtdWNoIHRvIHdoYXQgaXMgZ2l2ZW4g YXMKbmFtZSBhbmQgc2hvdWxkIHByb2JhYmx5IG5vdCBiZSBzbyBzdHJpY3QuCgpBbHNvLCBJIGRv bid0IGNob29zZSB3aGF0IGRldl9uYW1lKCkgcmV0dXJucywgaXQncyBpbiB0aGUgZGV2aWNlIHRy ZWUKYW5kIHRoZSBkZXZpY2UgdHJlZSBkbyBub3QgY2FyZSBhYm91dCB0aGUgaW1wbGVtZW50YXRp b24sIGl0J3MganVzdCBhCmRlc2NyaXB0aXZlIGZpbGUuCgo+IAo+IFNvIHRoaXMgZnVuY3Rpb24g aXMgdGVzdGluZyBzb21ldGhpbmcgd2hpY2ggc2hvdWxkIGJlIGFscmVhZHkgdGVzdGVkLCBubz8K CkkgZG9uJ3QgdGhpbmsgaXQgaXMuIFdpdGhvdXQgdGhpcyBmdW5jdGlvbiB0aGUgcHJvYmUgd2ls bCBzaW1wbHkgZmFpbC4KClRoZSBleHBsYW5hdGlvbiBvZiB3aGF0IGZhaWxzIGlzIGluIHRoZSBj b2RlOgoKPiA+ICsJCS8qCj4gPiArCQkgKiBXaGVuIGluc2lkZSBhIHN5c3RlbSBjb250cm9sbGVy LCB0aGUgZGV2aWNlIG5hbWUgaGFzIHRoZQo+ID4gKwkJICogZm9ybTogZjA2ZjgwMDAuc3lzdGVt LWNvbnRyb2xsZXI6YXAtdGhlcm1hbCBzbyBzdHJpcHBpbmcKPiA+ICsJCSAqIGFmdGVyIHRoZSAn Oicgc2hvdWxkIGdpdmUgdXMgYSBzaG9ydGVyIGJ1dCBtZWFuaW5nZnVsIG5hbWUuCj4gPiArCQkg Ki8KPiA+ICsJCW5hbWUgPSBzdHJyY2hyKG5hbWUsICc6Jyk7Cj4gPiArCQlpZiAoIW5hbWUpCj4g PiArCQkJbmFtZSA9ICJhcm1hZGFfdGhlcm1hbCI7Cj4gPiArCQllbHNlCj4gPiArCQkJbmFtZSsr OwoKWy4uLl0KCj4gPiArCj4gPiArCS8qIFRoZW4gY2hlY2sgdGhlcmUgYXJlIG5vICctJyBvciBo d21vbiBjb3JlIHdpbGwgY29tcGxhaW4gKi8KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Fri, 27 Jul 2018 13:52:30 +0200 Subject: [PATCH v3 01/23] thermal: armada: add a function that sanitizes the thermal zone name In-Reply-To: <84f97022-a470-f314-ee75-e5afb733bea5@linaro.org> References: <20180716144206.30985-1-miquel.raynal@bootlin.com> <20180716144206.30985-2-miquel.raynal@bootlin.com> <84f97022-a470-f314-ee75-e5afb733bea5@linaro.org> Message-ID: <20180727135230.3c7102c7@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Daniel, Daniel Lezcano wrote on Fri, 27 Jul 2018 13:34:19 +0200: > On 16/07/2018 16:41, Miquel Raynal wrote: > > Thermal zone names must follow certain rules imposed by the framework. > > They are limited in length and shall not have any hyphen '-'. > > > > This is done in a separate function for future use in another location. > > > > Signed-off-by: Miquel Raynal > > Why do you have to provide a function to test that? > > Logically, the one who did the change to add a thermal name, should > check its code works. Without a proper name that won't work. What do you mean "the one who did the change"? I think the thermal core should not care that much to what is given as name and should probably not be so strict. Also, I don't choose what dev_name() returns, it's in the device tree and the device tree do not care about the implementation, it's just a descriptive file. > > So this function is testing something which should be already tested, no? I don't think it is. Without this function the probe will simply fail. The explanation of what fails is in the code: > > + /* > > + * When inside a system controller, the device name has the > > + * form: f06f8000.system-controller:ap-thermal so stripping > > + * after the ':' should give us a shorter but meaningful name. > > + */ > > + name = strrchr(name, ':'); > > + if (!name) > > + name = "armada_thermal"; > > + else > > + name++; [...] > > + > > + /* Then check there are no '-' or hwmon core will complain */ Thanks, Miqu?l