From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: sh: remove unused variable rtc_dev
Date: Fri, 27 Jul 2018 17:28:18 +0200 [thread overview]
Message-ID: <20180727152818.GE7701@piout.net> (raw)
In-Reply-To: <20180727151015.3930-1-anders.roxell@linaro.org>
On 27/07/2018 17:10:15+0200, Anders Roxell wrote:
> When building rtc-sh, rtc_dev isn't used in function __sh_rtc_periodic.
> drivers/rtc/rtc-sh.c: In function ‘__sh_rtc_periodic’:
> drivers/rtc/rtc-sh.c:146:21: warning: unused variable ‘rtc_dev’ [-Wunused-variable]
> struct rtc_device *rtc_dev = rtc->rtc_dev;
> ^~~~~~~
> Remove the declaration of rtc_dev to dispose the warning.
>
> Fixes: ec623ff014c4 ("rtc: sh: remove dead code")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/rtc/rtc-sh.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks.
It is weird that kbuild didn't complain about it though.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-07-27 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 15:10 [PATCH] rtc: sh: remove unused variable rtc_dev Anders Roxell
2018-07-27 15:28 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727152818.GE7701@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=anders.roxell@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.