* [PATCH] rtc: sh: remove unused variable rtc_dev
@ 2018-07-27 15:10 Anders Roxell
2018-07-27 15:28 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Anders Roxell @ 2018-07-27 15:10 UTC (permalink / raw)
To: alexandre.belloni, a.zummo; +Cc: linux-rtc, linux-kernel, Anders Roxell
When building rtc-sh, rtc_dev isn't used in function __sh_rtc_periodic.
drivers/rtc/rtc-sh.c: In function ‘__sh_rtc_periodic’:
drivers/rtc/rtc-sh.c:146:21: warning: unused variable ‘rtc_dev’ [-Wunused-variable]
struct rtc_device *rtc_dev = rtc->rtc_dev;
^~~~~~~
Remove the declaration of rtc_dev to dispose the warning.
Fixes: ec623ff014c4 ("rtc: sh: remove dead code")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/rtc/rtc-sh.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index 25ec6a937858..51ba414798a8 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -143,7 +143,6 @@ static int __sh_rtc_alarm(struct sh_rtc *rtc)
static int __sh_rtc_periodic(struct sh_rtc *rtc)
{
- struct rtc_device *rtc_dev = rtc->rtc_dev;
unsigned int tmp, pending;
tmp = readb(rtc->regbase + RCR2);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rtc: sh: remove unused variable rtc_dev
2018-07-27 15:10 [PATCH] rtc: sh: remove unused variable rtc_dev Anders Roxell
@ 2018-07-27 15:28 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2018-07-27 15:28 UTC (permalink / raw)
To: Anders Roxell; +Cc: a.zummo, linux-rtc, linux-kernel
On 27/07/2018 17:10:15+0200, Anders Roxell wrote:
> When building rtc-sh, rtc_dev isn't used in function __sh_rtc_periodic.
> drivers/rtc/rtc-sh.c: In function ‘__sh_rtc_periodic’:
> drivers/rtc/rtc-sh.c:146:21: warning: unused variable ‘rtc_dev’ [-Wunused-variable]
> struct rtc_device *rtc_dev = rtc->rtc_dev;
> ^~~~~~~
> Remove the declaration of rtc_dev to dispose the warning.
>
> Fixes: ec623ff014c4 ("rtc: sh: remove dead code")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/rtc/rtc-sh.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks.
It is weird that kbuild didn't complain about it though.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-27 16:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-27 15:10 [PATCH] rtc: sh: remove unused variable rtc_dev Anders Roxell
2018-07-27 15:28 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.