Re: [Qemu-devel] [PATCH for-3.0 1/3] block/qapi: Add 'qdev' field to query-blockstats result

[Kevin Wolf <kwolf@redhat.com>]

Am 27.07.2018 um 17:07 hat Eric Blake geschrieben:
> On 07/27/2018 09:15 AM, Kevin Wolf wrote:
> > Like for query-block, the client needs to identify which BlockBackend
> > the returned data is for. Anonymous BlockBackends are identified by the
> > device model they are attached to. Add a 'qdev' field that contains the
> > qdev ID or QOM path of the attached device model.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> 
> > @@ -879,7 +882,7 @@
> >   # Since: 0.14.0
> >   ##
> >   { 'struct': 'BlockStats',
> > -  'data': {'*device': 'str', '*node-name': 'str',
> > +  'data': {'*device': 'str', '*qdev': 'str', '*node-name': 'str',
> >              'stats': 'BlockDeviceStats',
> >              '*parent': 'BlockStats',
> >              '*backing': 'BlockStats'} }
> 
> Can we also update the example under query-blockstats a few lines later to
> show the added field?

I'll add the qdev field, but the example is hopelessly outdated anyway.
Sounds like something for another patch.

> At any rate, it looks helpful. Although this is borderline new feature, it
> resolves a need identified in libvirt using -blockdev, and so I can live
> with it as a 3.0 bugfix.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks.

Kevin