diff for duplicates of <201807271704468308230@163.com> diff --git a/a/1.txt b/N1/1.txt index 8affd70..5f3e550 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -24,9 +24,6 @@ Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> drivers/net/usb/sr9700.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- -2.17.0 - diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index 2d316c1b851b..6ac232e52bf7 100644 --- a/drivers/net/usb/sr9700.c @@ -40,3 +37,5 @@ sr_write_reg(dev, SR_PRR, PRR_PHY_RST); sr_write_reg(dev, SR_PRR, 0); /* at least 1ms, here 2ms for reading right register */ udelay(2 * 1000); +-- +2.17.0 diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..96de6c4 --- /dev/null +++ b/N1/2.bin @@ -0,0 +1,32 @@ +<html><head><meta http-equiv="content-type" content="text/html; charset=us-ascii"><style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; font-family: ????; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><body> +<div><span></span>Dear Jia-Ju Bai :</div><div><br></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"> </span><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"> </span><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"> OK.</span></div><div><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"><br></span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"> </span><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"> </span><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"> the patch is ok.</span></div> +<div><br></div><hr style="WIDTH: 210px; HEIGHT: 1px" color="#b5c4df" size="1" align="left"> +<div><span><div style="MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt"><div>liujunliang_ljl@163.com</div></div></span></div> +<blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;"><div> </div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"><div style="PADDING-RIGHT: 8px; PADDING-LEFT: 8px; FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PADDING-BOTTOM: 8px; PADDING-TOP: 8px"><div><b>From:</b> <a href="mailto:baijiaju1990@gmail.com">Jia-Ju Bai</a></div><div><b>Date:</b> 2018-07-27 16:41</div><div><b>To:</b> <a href="mailto:liujunliang_ljl@163.com">liujunliang_ljl</a></div><div><b>CC:</b> <a href="mailto:linux-usb@vger.kernel.org">linux-usb</a>; <a href="mailto:netdev@vger.kernel.org">netdev</a>; <a href="mailto:linux-kernel@vger.kernel.org">linux-kernel</a>; <a href="mailto:baijiaju1990@gmail.com">Jia-Ju Bai</a></div><div><b>Subject:</b> [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()</div></div></div><div><div>sr9700_bind() is never called in atomic context.</div> +<div>It calls mdelay() to busily wait, which is not necessary.</div> +<div>mdelay() can be replaced with msleep().</div> +<div> </div> +<div>This is found by a static analysis tool named DCNS written by myself.</div> +<div> </div> +<div>Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com></div> +<div>---</div> +<div> drivers/net/usb/sr9700.c | 2 +-</div> +<div> 1 file changed, 1 insertion(+), 1 deletion(-)</div> +<div> </div> +<div>diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c</div> +<div>index 2d316c1b851b..6ac232e52bf7 100644</div> +<div>--- a/drivers/net/usb/sr9700.c</div> +<div>+++ b/drivers/net/usb/sr9700.c</div> +<div>@@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf)</div> +<div> /* power up and reset phy */</div> +<div> sr_write_reg(dev, SR_PRR, PRR_PHY_RST);</div> +<div> /* at least 10ms, here 20ms for safe */</div> +<div>- mdelay(20);</div> +<div>+ msleep(20);</div> +<div> sr_write_reg(dev, SR_PRR, 0);</div> +<div> /* at least 1ms, here 2ms for reading right register */</div> +<div> udelay(2 * 1000);</div> +<div>-- </div> +<div>2.17.0</div> +</div></blockquote> +</body></html> diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..75e5025 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: text/html; + charset="us-ascii" +Content-Transfer-Encoding: quoted-printable diff --git a/a/content_digest b/N1/content_digest index 4e7888d..0435000 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,11 +1,13 @@ + "ref\020180727084104.29726-1-baijiaju1990@gmail.com\0" "From\0liujunliang_ljl@163.com <liujunliang_ljl@163.com>\0" - "Subject\0net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()\0" + "Subject\0Re: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()\0" "Date\0Fri, 27 Jul 2018 17:04:48 +0800\0" "To\0Jia-Ju Bai <baijiaju1990@gmail.com>\0" "Cc\0linux-usb <linux-usb@vger.kernel.org>" netdev <netdev@vger.kernel.org> - " linux-kernel <linux-kernel@vger.kernel.org>\0" - "\00:1\0" + linux-kernel <linux-kernel@vger.kernel.org> + " Jia-Ju Bai <baijiaju1990@gmail.com>\0" + "\01:1\0" "b\0" "Dear Jia-Ju Bai :\n" "\n" @@ -33,9 +35,6 @@ "drivers/net/usb/sr9700.c | 2 +-\n" "1 file changed, 1 insertion(+), 1 deletion(-)\n" " \n" - "-- \n" - "2.17.0\n" - "\n" "diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c\n" "index 2d316c1b851b..6ac232e52bf7 100644\n" "--- a/drivers/net/usb/sr9700.c\n" @@ -48,6 +47,42 @@ "+ msleep(20);\n" "sr_write_reg(dev, SR_PRR, 0);\n" "/* at least 1ms, here 2ms for reading right register */\n" - udelay(2 * 1000); + "udelay(2 * 1000);\n" + "-- \n" + 2.17.0 + "\01:2\0" + "b\0" + "<html><head><meta http-equiv=\"content-type\" content=\"text/html; charset=us-ascii\"><style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; font-family: ????; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><body>\r\n" + "<div><span></span>Dear Jia-Ju Bai :</div><div><br></div><div><span style=\"color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);\"> </span><span style=\"background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;\"> </span><span style=\"background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;\"> OK.</span></div><div><span style=\"background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;\"><br></span></div><div><span style=\"color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);\"> </span><span style=\"background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;\"> </span><span style=\"background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;\"> the patch is ok.</span></div>\r\n" + "<div><br></div><hr style=\"WIDTH: 210px; HEIGHT: 1px\" color=\"#b5c4df\" size=\"1\" align=\"left\">\r\n" + "<div><span><div style=\"MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt\"><div>liujunliang_ljl@163.com</div></div></span></div>\r\n" + "<blockquote style=\"margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;\"><div> </div><div style=\"border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm\"><div style=\"PADDING-RIGHT: 8px; PADDING-LEFT: 8px; FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PADDING-BOTTOM: 8px; PADDING-TOP: 8px\"><div><b>From:</b> <a href=\"mailto:baijiaju1990@gmail.com\">Jia-Ju Bai</a></div><div><b>Date:</b> 2018-07-27 16:41</div><div><b>To:</b> <a href=\"mailto:liujunliang_ljl@163.com\">liujunliang_ljl</a></div><div><b>CC:</b> <a href=\"mailto:linux-usb@vger.kernel.org\">linux-usb</a>; <a href=\"mailto:netdev@vger.kernel.org\">netdev</a>; <a href=\"mailto:linux-kernel@vger.kernel.org\">linux-kernel</a>; <a href=\"mailto:baijiaju1990@gmail.com\">Jia-Ju Bai</a></div><div><b>Subject:</b> [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()</div></div></div><div><div>sr9700_bind() is never called in atomic context.</div>\r\n" + "<div>It calls mdelay() to busily wait, which is not necessary.</div>\r\n" + "<div>mdelay() can be replaced with msleep().</div>\r\n" + "<div> </div>\r\n" + "<div>This is found by a static analysis tool named DCNS written by myself.</div>\r\n" + "<div> </div>\r\n" + "<div>Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com></div>\r\n" + "<div>---</div>\r\n" + "<div> drivers/net/usb/sr9700.c | 2 +-</div>\r\n" + "<div> 1 file changed, 1 insertion(+), 1 deletion(-)</div>\r\n" + "<div> </div>\r\n" + "<div>diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c</div>\r\n" + "<div>index 2d316c1b851b..6ac232e52bf7 100644</div>\r\n" + "<div>--- a/drivers/net/usb/sr9700.c</div>\r\n" + "<div>+++ b/drivers/net/usb/sr9700.c</div>\r\n" + "<div>@@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf)</div>\r\n" + "<div> \t/* power up and reset phy */</div>\r\n" + "<div> \tsr_write_reg(dev, SR_PRR, PRR_PHY_RST);</div>\r\n" + "<div> \t/* at least 10ms, here 20ms for safe */</div>\r\n" + "<div>-\tmdelay(20);</div>\r\n" + "<div>+\tmsleep(20);</div>\r\n" + "<div> \tsr_write_reg(dev, SR_PRR, 0);</div>\r\n" + "<div> \t/* at least 1ms, here 2ms for reading right register */</div>\r\n" + "<div> \tudelay(2 * 1000);</div>\r\n" + "<div>-- </div>\r\n" + "<div>2.17.0</div>\r\n" + "</div></blockquote>\r\n" + </body></html> -bd660044e91b0698952cdf9557db212855c06132d97f52784e1a395207f99f12 +2370838511a0e0cd3f6ad0a7fe4557e3501f6dc2b7df3226f974b067ec250820
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.