From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 3/5] drm/vc4: Use drm_atomic_helper_check_plane_state() to simplify the logic Date: Fri, 27 Jul 2018 22:54:49 +0200 Message-ID: <20180727225449.30f03175@bbrezillon> References: <20180725153209.14366-1-boris.brezillon@bootlin.com> <20180725153209.14366-4-boris.brezillon@bootlin.com> <87effo1kjz.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B9186E24A for ; Fri, 27 Jul 2018 20:54:51 +0000 (UTC) In-Reply-To: <87effo1kjz.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNyBKdWwgMjAxOCAxMzozODowOCAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxp bi5jb20+IHdyaXRlczoKPiAKPiA+IEZyb206IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+ Cj4gPgo+ID4gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVfc3RhdGUoKSB0YWtlcyBjYXJl IG9mIGNoZWNraW5nIHRoZQo+ID4gc2NhbGluZyBjYXBhYmlsaXRpZXMgYW5kIGNhbGN1bGF0aW5n IHRoZSBjbGlwcGVkIFgvWSBvZmZzZXRzIGZvciB1cy4KPiA+Cj4gPiBSZWx5IG9uIHRoaXMgZnVu Y3Rpb24gaW5zdGVhZCBvZiBvcGVuLWNvZGluZyB0aGUgbG9naWMuIFdoaWxlIGF0IGl0LCB3ZQo+ ID4gZ2V0IHJpZCBvZiBhIGZldyBmaWVsZHMgaW4gdmM0X3BsYW5lX3N0YXRlIHRoYXQgY2FuIGJl IGVhc2lseSBleHRyYWN0ZWQKPiA+IGZyb20gZHJtX3BsYW5lX3N0YXRlLgo+ID4KPiA+IEluY2lk ZW50YWxseSwgaXQgc2VlbXMgdG8gZml4IGEgcHJvYmxlbSB3ZSBoYWQgd2l0aCBuZWdhdGl2ZSBY L1kKPiA+IHBvc2l0aW9uaW5nIG9mIFlVViBwbGFuZXMuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTog RXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJy ZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVy cy9ncHUvZHJtL3ZjNC92YzRfZHJ2LmggICB8ICAgOSAtLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS92 YzQvdmM0X3BsYW5lLmMgfCAyMTAgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTExIGluc2VydGlvbnMoKyksIDEwOCBkZWxldGlv bnMoLSkgIAo+IAo+IEkgZmVlbCBsaWtlIHlvdSBvdWdodCB0byBncmFiIGF1dGhvcnNoaXAgb2Yg dGhpcyBwYXRjaCAtLSB5b3UndmUgbWFkZSBhCj4gYnVuY2ggb2YgZ29vZCBjaGFuZ2VzIHNpbmNl IG15IFdJUCBwYXRjaC4KPiAKPiA+ICAJaWYgKG51bV9wbGFuZXMgPiAxKSB7Cj4gPiAtCQl2YzRf c3RhdGUtPmlzX3l1diA9IHRydWU7Cj4gPiAtCj4gPiAtCQloX3N1YnNhbXBsZSA9IGRybV9mb3Jt YXRfaG9yel9jaHJvbWFfc3Vic2FtcGxpbmcoZm9ybWF0KTsKPiA+IC0JCXZfc3Vic2FtcGxlID0g ZHJtX2Zvcm1hdF92ZXJ0X2Nocm9tYV9zdWJzYW1wbGluZyhmb3JtYXQpOwo+ID4gLQkJdmM0X3N0 YXRlLT5zcmNfd1sxXSA9IHZjNF9zdGF0ZS0+c3JjX3dbMF0gLyBoX3N1YnNhbXBsZTsKPiA+IC0J CXZjNF9zdGF0ZS0+c3JjX2hbMV0gPSB2YzRfc3RhdGUtPnNyY19oWzBdIC8gdl9zdWJzYW1wbGU7 Cj4gPiArCQlzcmNfdyAvPSBoX3N1YnNhbXBsZTsKPiA+ICsJCXNyY19oIC89IHZfc3Vic2FtcGxl OyAgCj4gCj4gSSdtIGEgbGl0dGxlIG5lcnZvdXMgYWJvdXQgbGVhdmluZyBzcmNfdy9zcmNfaCBk aXZpZGVkIGFmdGVyIHRoaXMgYmxvY2ssCj4gaW4gY2FzZSB3ZSBlbmQgdXAgdXNpbmcgdGhlbSBp biBzb21lIG90aGVyIGNhbGN1bGF0aW9uIGluIGEgbGF0ZXIKPiBjaGFuZ2UuICBDb3VsZCB3ZSBq dXN0IG1vdmUgdGhlIGRpdmlkZSBpbnRvIHRoZSB2YzRfZ2V0X3NjYWxpbmdfbW9kZSgpCj4gY2Fs bD8KPiAKPiBJbiBnZW5lcmFsLCBJJ20gbm90IGVudGh1c2lhc3RpYyBhYm91dCBoYXZpbmcgc3Jj X3cgY29tcHV0YXRpb25zIGluIDUKPiBwbGFjZXMgbm93LiAgV2FzIGtlZXBpbmcgaXQgaW4gdGhl IHZjNCBzdGF0ZSB0aGF0IG11Y2ggb2YgYSBwcm9ibGVtPwoKTm8gc3Ryb25nIG9iamVjdGlvbiB0 byBrZWVwaW5nIC0+c3JjX3toLHd9W10gYXJyYXlzIGluIHZjNF9wbGFuZV9zdGF0ZS4KCj4gCj4g SSdtIG5vdCBzYXlpbmcgbm8sIGJ1dCBjb3B5LWFuZC1wYXN0ZSBvZiB0aGVzZSBraW5kcyBvZiBj YWxjdWxhdGlvbnMgYXJlCj4gYWxzbyBhIGZyZXF1ZW50IHNvdXJjZSBvZiBidWdzIHdoZW4geW91 IG1pc3MgYSB4LT55IG9yIHctPmggY2hhbmdlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==