From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH 4/5] drm/vc4: Move ->offsets[] adjustment out of
 setup_clipping_and_scaling()
Date: Fri, 27 Jul 2018 22:55:38 +0200
Message-ID: <20180727225538.5b5ab810@bbrezillon>
References: <20180725153209.14366-1-boris.brezillon@bootlin.com>
 <20180725153209.14366-5-boris.brezillon@bootlin.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7D88C89DAB
 for <dri-devel@lists.freedesktop.org>; Fri, 27 Jul 2018 20:55:39 +0000 (UTC)
In-Reply-To: <20180725153209.14366-5-boris.brezillon@bootlin.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCAyNSBKdWwgMjAxOCAxNzozMjowOCArMDIwMApCb3JpcyBCcmV6aWxsb24gPGJvcmlz
LmJyZXppbGxvbkBib290bGluLmNvbT4gd3JvdGU6Cgo+IEZyb206IEVyaWMgQW5ob2x0IDxlcmlj
QGFuaG9sdC5uZXQ+Cj4gCj4gVGhlIG9mZnNldCBhZGp1c3RtZW50IGRlcGVuZHMgb24gdGhlIGZy
YW1lYnVmZmVyIG1vZGlmaWVkLCBzbyBsZXQncwoKCQkJCQkJICAgXiBtb2RpZmllcgoKPiBqdXN0
IG1vdmUgdGhpcyBvcGVyYXRpb24gaW4gdGhlIERSTV9GT1JNQVRfTU9EX0xJTkVBUiBjYXNlIGlu
c2lkZQo+IHZjNF9wbGFuZV9tb2RlX3NldCgpLgo+IAo+IFRoaXMgd2UnbGwgYmUgYWJsZSB0byBm
aXggb2Zmc2V0IGNhbGN1bGF0aW9uIGZvcgoKXiBUaGFua3MgdG8gdGhpcywgd2UnbGwgLi4uCgo+
IERSTV9GT1JNQVRfTU9EX0JST0FEQ09NX1ZDNF9UX1RJTEVEIGFuZCBEUk1fRk9STUFUX01PRF9C
Uk9BRENPTV9TQU5EWFhYLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEVyaWMgQW5ob2x0IDxlcmljQGFu
aG9sdC5uZXQ+Cj4gU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxs
b25AYm9vdGxpbi5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMg
fCAyMyArKysrKysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0
aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L3ZjNC92YzRfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMKPiBpbmRl
eCAzOWUxZmEzYTg0NjYuLjJiOGJhMWM0MTJiZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vdmM0L3ZjNF9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUu
Ywo+IEBAIC0zNTQsMTQgKzM1NCw2IEBAIHN0YXRpYyBpbnQgdmM0X3BsYW5lX3NldHVwX2NsaXBw
aW5nX2FuZF9zY2FsaW5nKHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ICAJCXZjNF9z
dGF0ZS0+eV9zY2FsaW5nWzFdID0gVkM0X1NDQUxJTkdfTk9ORTsKPiAgCX0KPiAgCj4gLQkvKiBB
ZGp1c3QgdGhlIGJhc2UgcG9pbnRlciB0byB0aGUgZmlyc3QgcGl4ZWwgdG8gYmUgc2Nhbm5lZCBv
dXQuICovCj4gLQlmb3IgKGkgPSAwOyBpIDwgbnVtX3BsYW5lczsgaSsrKSB7Cj4gLQkJdmM0X3N0
YXRlLT5vZmZzZXRzW2ldICs9IChzcmNfeSAvIChpID8gdl9zdWJzYW1wbGUgOiAxKSkgKgo+IC0J
CQkJCSBmYi0+cGl0Y2hlc1tpXTsKPiAtCQl2YzRfc3RhdGUtPm9mZnNldHNbaV0gKz0gKHNyY194
IC8gKGkgPyBoX3N1YnNhbXBsZSA6IDEpKSAqCj4gLQkJCQkJIGZiLT5mb3JtYXQtPmNwcFtpXTsK
PiAtCX0KPiAtCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiBAQCAtNDc2LDYgKzQ2OCw3IEBAIHN0
YXRpYyBpbnQgdmM0X3BsYW5lX21vZGVfc2V0KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJ
dTY0IGJhc2VfZm9ybWF0X21vZCA9IGZvdXJjY19tb2RfYnJvYWRjb21fbW9kKGZiLT5tb2RpZmll
cik7Cj4gIAlpbnQgbnVtX3BsYW5lcyA9IGRybV9mb3JtYXRfbnVtX3BsYW5lcyhmb3JtYXQtPmRy
bSk7Cj4gIAl1MzIgc3JjX3gsIHNyY195LCBjcnRjX2gsIGNydGNfdywgc3JjX2gsIHNyY193Owo+
ICsJdTMyIGhfc3Vic2FtcGxlLCB2X3N1YnNhbXBsZTsKPiAgCWJvb2wgbWl4X3BsYW5lX2FscGhh
Owo+ICAJYm9vbCBjb3ZlcnNfc2NyZWVuOwo+ICAJdTMyIHNjbDAsIHNjbDEsIHBpdGNoMDsKPiBA
QCAtNTI3LDExICs1MjAsMjUgQEAgc3RhdGljIGludCB2YzRfcGxhbmVfbW9kZV9zZXQoc3RydWN0
IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlzcmNfeSA9IHN0YXRlLT5zcmMueTEgPj4gMTY7Cj4gIAlz
cmNfdyA9IChzdGF0ZS0+c3JjLngyIC0gc3RhdGUtPnNyYy54MSkgPj4gMTY7Cj4gIAlzcmNfaCA9
IChzdGF0ZS0+c3JjLnkyIC0gc3RhdGUtPnNyYy55MSkgPj4gMTY7Cj4gKwloX3N1YnNhbXBsZSA9
IGRybV9mb3JtYXRfaG9yel9jaHJvbWFfc3Vic2FtcGxpbmcoZm9ybWF0LT5kcm0pOwo+ICsJdl9z
dWJzYW1wbGUgPSBkcm1fZm9ybWF0X3ZlcnRfY2hyb21hX3N1YnNhbXBsaW5nKGZvcm1hdC0+ZHJt
KTsKPiAgCj4gIAlzd2l0Y2ggKGJhc2VfZm9ybWF0X21vZCkgewo+ICAJY2FzZSBEUk1fRk9STUFU
X01PRF9MSU5FQVI6Cj4gIAkJdGlsaW5nID0gU0NBTEVSX0NUTDBfVElMSU5HX0xJTkVBUjsKPiAg
CQlwaXRjaDAgPSBWQzRfU0VUX0ZJRUxEKGZiLT5waXRjaGVzWzBdLCBTQ0FMRVJfU1JDX1BJVENI
KTsKPiArCj4gKwkJLyogQWRqdXN0IHRoZSBiYXNlIHBvaW50ZXIgdG8gdGhlIGZpcnN0IHBpeGVs
IHRvIGJlIHNjYW5uZWQKPiArCQkgKiBvdXQuCj4gKwkJICovCj4gKwkJZm9yIChpID0gMDsgaSA8
IG51bV9wbGFuZXM7IGkrKykgewo+ICsJCQl2YzRfc3RhdGUtPm9mZnNldHNbaV0gKz0gc3JjX3kg
Lwo+ICsJCQkJCQkgKGkgPyB2X3N1YnNhbXBsZSA6IDEpICoKPiArCQkJCQkJIGZiLT5waXRjaGVz
W2ldOwo+ICsJCQl2YzRfc3RhdGUtPm9mZnNldHNbaV0gKz0gc3JjX3ggLwo+ICsJCQkJCQkgKGkg
PyBoX3N1YnNhbXBsZSA6IDEpICoKPiArCQkJCQkJIGZiLT5mb3JtYXQtPmNwcFtpXTsKPiArCQl9
Cj4gIAkJYnJlYWs7Cj4gIAo+ICAJY2FzZSBEUk1fRk9STUFUX01PRF9CUk9BRENPTV9WQzRfVF9U
SUxFRDogewoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==