From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 5/5] drm/vc4: Fix negative X/Y positioning of planes using T_TILES modifier Date: Fri, 27 Jul 2018 22:59:30 +0200 Message-ID: <20180727225930.2a632f85@bbrezillon> References: <20180725153209.14366-1-boris.brezillon@bootlin.com> <20180725153209.14366-6-boris.brezillon@bootlin.com> <87bmas1k60.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id D864A89C08 for ; Fri, 27 Jul 2018 20:59:31 +0000 (UTC) In-Reply-To: <87bmas1k60.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNyBKdWwgMjAxOCAxMzo0NjozMSAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxp bi5jb20+IHdyaXRlczoKPiAKPiA+IEZyb206IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+ Cj4gPgo+ID4gWC9ZIHBvc2l0aW9uaW5nIG9mIFQtZm9ybWF0IGJ1ZmZlcnMgaXMgcXVpdGUgdHJp Y2t5IGFuZCB0aGUgY3VycmVudAo+ID4gaW1wbGVtZW50YXRpb24gd2FzIGZhaWxpbmcgdG8gcG9z aXRpb24gYSBwbGFuZSB1c2luZyB0aGlzIGZvcm1hdAo+ID4gY29ycmVjdGx5IHdoZW4gdGhlIFgs IFkgb3IgYm90aCBYIGFuZCBZIG9mZnNldHMgd2VyZSBuZWdhdGl2ZS4gIAo+IAo+IFdhaXQsIHdl cmUgdGhpbmdzIHdvcmtpbmcgZm9yIHlvdSB3aXRoIGV2ZW4gcG9zdGl2aWUgWC9ZIG9mZnNldHMg b24gVD8KPiBCZWNhdXNlIGl0IHdhc24ndCBmb3IgbWUsIGFuZCBJIHRoaW5rIHRoZSB0aWxlX2hf bWFzayBjaGFuZ2UgaXMKPiBpbXBvcnRhbnQgZm9yIG1ha2luZyBwb3NpdGl2ZSB3b3JrLgoKTm90 IHNvIHN1cmUuIEkndmUgZG9uZSBzbyBtYW55IHRlc3RzIHRoYXQgSSBkb24ndCByZW1lbWJlciB3 aGljaCBleGFjdApzZXR1cHMgd2VyZSB3b3JraW5nIGFuZCB3aGljaCBvbmVzIHdlcmUgbm90LiBJ J2xsIHRlc3QgYWdhaW4gYmVmb3JlCnNlbmRpbmcgdjIgYW5kIGFkanVzdCB0aGUgY29tbWl0IG1l c3NhZ2UgYWNjb3JkaW5nbHkuCgo+IAo+ID4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVy aWNAYW5ob2x0Lm5ldD4KPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMu YnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4gLS0tCj4gPiBIaSBFcmljLAo+ID4KPiA+IEkga2Vw dCB0aGUgU29CIGFuZCBhdXRob3JzaGlwIHNpbmNlIHlvdSdyZSB0aGUgb3JpZ2luYWwgYXV0aG9y LCBidXQKPiA+IEkgYWxzbyBzaWduaWZpY2FudGx5IHJld29ya2VkIHRoZSBjb2RlLCBzbyBJJ2Qg YmUgbW9yZSBjb25maWRlbnQgaWYgeW91Cj4gPiBjb3VsZCBoYXZlIGEgY2xvc2UgbG9vayBhdCB0 aGlzIGNvZGUuICAKPiAKPiBJIHRoaW5rIHlvdSBzaG91bGQgZGVmaW5pdGVseSBncmFiIGF1dGhv cnNoaXAgb24gdGhpcyBvbmUuICBZb3UgZGlkIHRoZQo+IHdvcmsgdG8gbWFrZSBpdCBhY3R1YWxs eSB3b3JrLgo+IAoKSSB3aWxsLiBUaGFua3MuCgo+ID4gQWxzbywgSSBpbnRlbnRpb25hbGx5IGRp ZCBub3QgYWRkIGEgRml4ZXMgYW5kIENjLXN0YWJsZSB0byB0aGlzIGNvbW1pdAo+ID4gYmVjYXVz ZSBpdCBkZXBlbmRzIG9uIGEgcmV3b3JrIHdlJ3ZlIGRvbmUgaW4KPiA+IHZjNF9wbGFuZV9zZXR1 cF9jbGlwcGluZ19hbmRfc2NhbGluZygpIHdoaWNoIGNhbm5vdCBiZSBlYXNpbHkKPiA+IGJhY2tw b3J0ZWQuCj4gPiBXaGF0IEkgY291bGQgZG8gdGhvdWdoIGlzIGFkZCBhIHBhdGNoIHRoYXQgcmVq ZWN0cyBhbGwgbmVnYXRpdmUKPiA+IGNydGNfe3gseX0uICAKPiAKPiBBZ3JlZWQuICBHaXZlbiB0 aGF0IHdlJ3JlIHRyeWluZyB0byBmaXggYSBidWcgdGhhdCBub2JvZHkgZWxzZSBoYXMKPiByZXBv cnRlZCB0byBtZSB5ZXQsIEkgdGhpbmsgd2UgY2FuIHNraXAgZGVhbGluZyB3aXRoIHRoaXMgZm9y IHN0YWJsZS4KPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMg fCA1MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ID4gIDEgZmls ZSBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJt L3ZjNC92YzRfcGxhbmUuYwo+ID4gaW5kZXggMmI4YmExYzQxMmJlLi5hZGU0N2MzZjY1ZDEgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jCj4gPiBAQCAtNTM5LDIyICs1MzksNTkgQEAg c3RhdGljIGludCB2YzRfcGxhbmVfbW9kZV9zZXQoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4g PiAgCQkJCQkJIChpID8gaF9zdWJzYW1wbGUgOiAxKSAqCj4gPiAgCQkJCQkJIGZiLT5mb3JtYXQt PmNwcFtpXTsKPiA+ICAJCX0KPiA+ICsKPiA+ICAJCWJyZWFrOwo+ID4gIAo+ID4gIAljYXNlIERS TV9GT1JNQVRfTU9EX0JST0FEQ09NX1ZDNF9UX1RJTEVEOiB7Cj4gPiAtCQkvKiBGb3IgVC10aWxl ZCwgdGhlIEZCIHBpdGNoIGlzICJob3cgbWFueSBieXRlcyBmcm9tCj4gPiAtCQkgKiBvbmUgcm93 IHRvIHRoZSBuZXh0LCBzdWNoIHRoYXQgcGl0Y2ggKiB0aWxlX2ggPT0KPiA+IC0JCSAqIHRpbGVf c2l6ZSAqIHRpbGVzX3Blcl9yb3cuIgo+ID4gLQkJICovCj4gPiAgCQl1MzIgdGlsZV9zaXplX3No aWZ0ID0gMTI7IC8qIFQgdGlsZXMgYXJlIDRrYiAqLwo+ID4gKwkJLyogV2hvbGUtdGlsZSBvZmZz ZXRzLCBtb3N0bHkgZm9yIHNldHRpbmcgdGhlIHBpdGNoLiAqLwo+ID4gKwkJdTMyIHRpbGVfd19z aGlmdCA9IGZiLT5mb3JtYXQtPmNwcFswXSA9PSAyID8gNiA6IDU7Cj4gPiAgCQl1MzIgdGlsZV9o X3NoaWZ0ID0gNTsgLyogMTYgYW5kIDMyYnBwIGFyZSAzMiBwaXhlbHMgaGlnaCAqLwo+ID4gKwkJ dTMyIHRpbGVfd19tYXNrID0gKDEgPDwgdGlsZV93X3NoaWZ0KSAtIDE7Cj4gPiArCQkvKiBUaGUg aGVpZ2h0IG1hc2sgb24gMzItYml0LXBlci1waXhlbCB0aWxlcyBpcyA2MywgaS5lLiAyCj4gPiAr CQkgKiB0aW1lcyB0aGUgaGVpZ2h0IChpbiBwaXhlbHMpIG9mIGEgNGsgdGlsZS4gSSBqdXN0IGFz c3VtZWQKPiA+ICsJCSAqIHRoaXMgaXMgYWxzbyB0cnVlIGZvciBvdGhlciBSR0IgZm9ybWF0cywg YnV0IG1heWJlIGl0J3Mgbm90Lgo+ID4gKwkJICovCj4gPiArCQl1MzIgdGlsZV9oX21hc2sgPSAo MiA8PCB0aWxlX2hfc2hpZnQpIC0gMTsgIAo+IAo+IE9ubHkgMiBhbmQgNC1ieXRlIGZvcm1hdHMg YXJlIHN1cHBvcnRlZCBmb3IgVCBmb3JtYXQsIGFuZCB0aWxlcyBhcmUgMzIKPiBwaXhlbHMgaGln aCBmb3IgYm90aCBvZiB0aG9zZS4KPiAKPiBPdGhlciB0aGFuIHRoYXQsCj4gCj4gUmV2aWV3ZWQt Ynk6IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+Cj4gCj4gSSBoYXZlIGEgY29tbWVudCBv biBwYXRjaCAzIEknZCBsaWtlIHRvIHNvcnQgb3V0LAoKSSdsbCBhZGRyZXNzIHRoYXQgb25lIGlu IHYyLgoKPiBidXQgb3RoZXIgdGhhbiB0aGF0Cj4gSSdtIHBsZWFzZWQgd2l0aCB0aGlzIHdob2xl IHNlcmllcy4gIFRoYW5rcyBmb3IgcGVyc2V2ZXJpbmcgb24gaXQhCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=