From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH for v4.19] drm_dp_cec.c: fix formatting typo: %pdH -> %phD Date: Sat, 28 Jul 2018 15:53:38 -0300 Message-ID: <20180728185338.GA14560@juma> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 428C76E0F4 for ; Sat, 28 Jul 2018 18:53:44 +0000 (UTC) Received: by mail-qt0-f193.google.com with SMTP id t5-v6so8380938qtn.3 for ; Sat, 28 Jul 2018 11:53:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: "dri-devel@lists.freedesktop.org" , Linux Media Mailing List List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMjQsIDIwMTggYXQgMDk6MjA6MjhQTSArMDIwMCwgSGFucyBWZXJrdWlsIHdy b3RlOgo+IFRoaXMgY2F1c2VkIGEga2VybmVsIG9vcHMgc2luY2UgJXBkSCBpbnRlcnByZXRlZCB0 aGUgcG9pbnRlcgo+IGFzIGEgc3RydWN0IGZpbGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogSGFucyBW ZXJrdWlsIDxoYW5zLnZlcmt1aWxAY2lzY28uY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2RwX2NlYy5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9jZWMu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfY2VjLmMKPiBpbmRleCA4N2I2N2NjMWVhNTguLmE2 Y2FjNDdmNjI0OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX2NlYy5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9jZWMuYwo+IEBAIC0xNTcsNyArMTU3LDcgQEAg c3RhdGljIHZvaWQgZHJtX2RwX2NlY19hZGFwX3N0YXR1cyhzdHJ1Y3QgY2VjX2FkYXB0ZXIgKmFk YXAsCj4gCj4gIAlpZiAoZHJtX2RwX3JlYWRfZGVzYyhhdXgsICZkZXNjLCB0cnVlKSkKPiAgCQly ZXR1cm47Cj4gLQlzZXFfcHJpbnRmKGZpbGUsICJPVUk6ICUqcGRIXG4iLAo+ICsJc2VxX3ByaW50 ZihmaWxlLCAiT1VJOiAlKnBoRFxuIiwKPiAgCQkgICAoaW50KXNpemVvZihpZC0+b3VpKSwgaWQt Pm91aSk7Cj4gIAlzZXFfcHJpbnRmKGZpbGUsICJJRDogJSpwRVxuIiwKPiAgCQkgICAoaW50KXN0 cm5sZW4oaWQtPmRldmljZV9pZCwgc2l6ZW9mKGlkLT5kZXZpY2VfaWQpKSwKCnB1c2hlZCB0byBk cm0tbWlzYy1uZXh0LWZpeGVzIGZvciA0LjE5LiBUaGFua3MuCgpHdXN0YXZvCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qt0-f194.google.com ([209.85.216.194]:40578 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730154AbeG1UVI (ORCPT ); Sat, 28 Jul 2018 16:21:08 -0400 Received: by mail-qt0-f194.google.com with SMTP id h4-v6so8369565qtj.7 for ; Sat, 28 Jul 2018 11:53:43 -0700 (PDT) Date: Sat, 28 Jul 2018 15:53:38 -0300 From: Gustavo Padovan To: Hans Verkuil Cc: Linux Media Mailing List , "dri-devel@lists.freedesktop.org" , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH for v4.19] drm_dp_cec.c: fix formatting typo: %pdH -> %phD Message-ID: <20180728185338.GA14560@juma> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Tue, Jul 24, 2018 at 09:20:28PM +0200, Hans Verkuil wrote: > This caused a kernel oops since %pdH interpreted the pointer > as a struct file. > > Signed-off-by: Hans Verkuil > --- > drivers/gpu/drm/drm_dp_cec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c > index 87b67cc1ea58..a6cac47f6248 100644 > --- a/drivers/gpu/drm/drm_dp_cec.c > +++ b/drivers/gpu/drm/drm_dp_cec.c > @@ -157,7 +157,7 @@ static void drm_dp_cec_adap_status(struct cec_adapter *adap, > > if (drm_dp_read_desc(aux, &desc, true)) > return; > - seq_printf(file, "OUI: %*pdH\n", > + seq_printf(file, "OUI: %*phD\n", > (int)sizeof(id->oui), id->oui); > seq_printf(file, "ID: %*pE\n", > (int)strnlen(id->device_id, sizeof(id->device_id)), pushed to drm-misc-next-fixes for 4.19. Thanks. Gustavo