From mboxrd@z Thu Jan 1 00:00:00 1970 From: leonro@mellanox.com (Leon Romanovsky) Date: Sun, 29 Jul 2018 23:22:30 +0300 Subject: [PATCH 3/4 v3] arc: fix data type errors in platform headers In-Reply-To: <0d2870ef-ae4c-d9a8-c894-c4f252fae7da@infradead.org> References: <15326613951079@infradead.org> <1532661395712@infradead.org> <20180729070113.GC7157@mtr-leonro.mtl.com> <0d2870ef-ae4c-d9a8-c894-c4f252fae7da@infradead.org> List-ID: Message-ID: <20180729202230.GR7157@mtr-leonro.mtl.com> To: linux-snps-arc@lists.infradead.org On Sun, Jul 29, 2018@11:10:51AM -0700, Randy Dunlap wrote: > On 07/29/2018 12:01 AM, Leon Romanovsky wrote: > > On Thu, Jul 26, 2018@08:16:35PM -0700, rd_dunlab wrote: > >> From: Randy Dunlap > >> > >> Add to fix build errors. > >> Both ctop.h and use u32 types and cause many > >> errors. > >> > >> Examples: > >> ../include/soc/nps/common.h:71:4: error: unknown type name 'u32' > >> u32 __reserved:20, cluster:4, core:4, thread:4; > >> ../include/soc/nps/common.h:76:3: error: unknown type name 'u32' > >> u32 value; > >> ../include/soc/nps/common.h:124:4: error: unknown type name 'u32' > >> u32 base:8, cl_x:4, cl_y:4, > >> ../include/soc/nps/common.h:127:3: error: unknown type name 'u32' > >> u32 value; > >> > >> ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32' > >> u32 gen:1, gdis:1, clk_gate_dis:1, asb:1, > >> ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32' > >> u32 value; > >> ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32' > >> u32 csa:22, dmsid:6, __reserved:3, cs:1; > >> ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32' > >> u32 value; > >> > >> Signed-off-by: Randy Dunlap > >> Cc: Vineet Gupta > >> Cc: linux-snps-arc at lists.infradead.org > >> Cc: Elad Kanfi > >> Cc: Leon Romanovsky > >> Cc: Ofer Levi > >> --- > >> v2: no change > >> > >> arch/arc/plat-eznps/include/plat/ctop.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> --- linux-next-20180723.orig/arch/arc/plat-eznps/include/plat/ctop.h > >> +++ linux-next-20180723/arch/arc/plat-eznps/include/plat/ctop.h > >> @@ -21,6 +21,7 @@ > >> #error "Incorrect ctop.h include" > >> #endif > >> > >> +#include > > > > I'm not familiar with arch/* code, so maybe my question will sound > > naive., but why "asm-generic/types.h" and not "linux/types.h"? > > Nope, good question. That works and should be preferred. > > Please use the new patch below. > > -- > > From: Randy Dunlap > > Add to fix build errors. > Both ctop.h and use u32 types and cause many > errors. > > Examples: > ../include/soc/nps/common.h:71:4: error: unknown type name 'u32' > u32 __reserved:20, cluster:4, core:4, thread:4; > ../include/soc/nps/common.h:76:3: error: unknown type name 'u32' > u32 value; > ../include/soc/nps/common.h:124:4: error: unknown type name 'u32' > u32 base:8, cl_x:4, cl_y:4, > ../include/soc/nps/common.h:127:3: error: unknown type name 'u32' > u32 value; > > ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32' > u32 gen:1, gdis:1, clk_gate_dis:1, asb:1, > ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32' > u32 value; > ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32' > u32 csa:22, dmsid:6, __reserved:3, cs:1; > ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32' > u32 value; > > Signed-off-by: Randy Dunlap > Cc: Vineet Gupta > Cc: linux-snps-arc at lists.infradead.org > Cc: Elad Kanfi > Cc: Leon Romanovsky > Cc: Ofer Levi > --- > v2: no change > v3: use instead of > > arch/arc/plat-eznps/include/plat/ctop.h | 1 + > 1 file changed, 1 insertion(+) > Thanks, Reviewed-by: Leon Romanovsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9B9C46461 for ; Sun, 29 Jul 2018 20:22:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1FD620857 for ; Sun, 29 Jul 2018 20:22:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="W/aI4kG/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1FD620857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729076AbeG2Vy1 (ORCPT ); Sun, 29 Jul 2018 17:54:27 -0400 Received: from mail-eopbgr70059.outbound.protection.outlook.com ([40.107.7.59]:9993 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726832AbeG2Vy1 (ORCPT ); Sun, 29 Jul 2018 17:54:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d1pjnRjGyTcYUWkxRm8zws4suFOMnWUSNeDk/V/f4CM=; b=W/aI4kG/w+/cJl1BZQ7Dj6Vs9w9If08k32EN+2FIgbg4193OBcFOossRD2LrOYhFwykMsHis9VZJ/8ZMig3hhphrjewKUf7JxGmUC07FB/Q4WIg79P4jySV+/VipU3MKCZ0BTnoWR/4msVAZin7XNmF4Q6FKB01gneisTvUWdXU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; Received: from localhost (213.57.183.250) by VI1PR0501MB2703.eurprd05.prod.outlook.com (2603:10a6:800:a2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.17; Sun, 29 Jul 2018 20:22:39 +0000 Date: Sun, 29 Jul 2018 23:22:30 +0300 From: Leon Romanovsky To: Randy Dunlap Cc: rd_dunlab , lkml , Vineet Gupta , linux-snps-arc@lists.infradead.org, Elad Kanfi , Ofer Levi Subject: Re: [PATCH 3/4 v3] arc: fix data type errors in platform headers Message-ID: <20180729202230.GR7157@mtr-leonro.mtl.com> References: <15326613951079@infradead.org> <1532661395712@infradead.org> <20180729070113.GC7157@mtr-leonro.mtl.com> <0d2870ef-ae4c-d9a8-c894-c4f252fae7da@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d2870ef-ae4c-d9a8-c894-c4f252fae7da@infradead.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [213.57.183.250] X-ClientProxiedBy: HE1PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:7:28::15) To VI1PR0501MB2703.eurprd05.prod.outlook.com (2603:10a6:800:a2::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b519133-c332-4a16-f055-08d5f5910829 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0501MB2703; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2703;3:qWF1slxfHBm/liGX+DrSbj/KAZ1QjuzN+ZyyM7AP6qmdp5fFAwDuSQlOy65UGeu1jb9zC+OdHO5CgxNy1jxT1ZFb3wOQXV5MM2l74OlhOrjndsfCPCkMVwr7bAW1IavAo4vZB3JLpbJpY7pc7qCRRfb29Awd5TPtXdRNGqvMIHPG99LWySkiPgS8iSIiPp9AaSjnj9IGStaeyQLoL+hU4AwRS91m6WrG62mWyuy3O7I6TA9gVUWMZrI+T5b3u+xQ;25:ntzLIlQPJCN5z1nyAzb4q9upQ29LFFnsqP8Pvzt9NtNv+O34kmenZnH21zgZMS9uLcGYOd7k+HtRyHawpOGuuufJAgejrXALe5F9E/ekvCFFA7EwIQunlwMn37BOacWlY8v1+wosQKB1dUQsDxYHZNh+Q/3ZPc5SjC/6c15jgZYhs17OFc47m8k6KidR58rPTKJPt0NP7pCKW5Aq9EuaWjAvw6o2t5Y+0ixFPh6lCWq3n3T40+/tfp2yoFXY7M/V+P3XvvOGLa/s1K7WkgTn95qS8H9wElX1G6RWEMp6aOGPGmv1kDDRIk/7+eFWbwKSAQ71JTuQAXoWyS1jdPyE0g==;31:CktT+t/QD9CXpgNHrmfcEbe3PQOjC1WyhL6mRZ2hnMKEH636BayTKHe4OnSd/N8RiNHzQDS8BDD7uFdKf4cs2iNxiTOEVSfevjUYmScOYsKOJL648Wc4LhYSx5dQOwoUcGr1FgIR1yW3iNk8P+nsGvFxqG0waz+VXQpPl+Y1276U8Nt5E6Bbny1/dXqH5ZywqpUHUg1UfMn3RfhaStQ3FdAOIqCijafC1zB3ZU8DAVA= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2703: X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2703;20:a4KDXz9lSeGCn+Yif8N6JLUKHfV8JJfwDppV0cAzNvT7HtN7UXT202++lSskFNgEaOKzKTd57aVNmrmDdyJ0XDeapOpUaetaWkldFL8U/ctmqtI6Lt1ouxj3emptLHxW+DF7J5DJAAYP4HxG3Or3kBcmFwamPZuNT1e/AclO5Q68cdqkqoERf0B9QdTHImw1BgZrmjYhwbF0B/+4R7mjJ2HEsd4LW8HkDajK0gcoQlnzVqyQ0EI/BoyUOrTBtUSO/BEC39qMK7pqV6sqkPd7AtHoeCqolfsKQoubCPg/yLR+8vunvcdkbxy6olzPpGNOh9WvKKUC7NLoW3ktRpEDLyA9UGbUf6ltkwEMEyjLgunEDdSFFG48NfOFFKO5QBn/mnNMGXFS8IEjw1Qfn53wHa6anwzyJlafClijgIXBIkhr1MU+M/pPhC5jtDQyhWNfd9hRZOl/zE8yhIz3R1dE0P6mhyZ1DZ+4M0IYki4P3TcrGA9471fqyu+IXB/XscCv;4:hmOwctBdUoTcyHIZ98s4U1QVHlAYVnXKMmepJRgFN0DzUE1VxEs/ZlYoZ7nC05OQQMvpaYzf4ePkxULM5g6nRmF+U/Mum/d3+EzdQDXbRFwUppBkbauWQgOHO0xpn4cZLG23JBd2JbLgVcx+GkcSvk1YdaXWlGIAAIWGCWpa1RX2Hi0/3yS7cW1kTReZ4mctgjbfpxoul3H+AZo2BgqbVwf+xcnkq8LDUTGRFaz8PfIF0AyS8ang5KUxklKpq8FXVypnvtF4WvsZapIH0WaAb2SUJX6IubsCe6G5Ev4M0ZnvX/V0gE2siWXQgZ5l7yMY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(258649278758335); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016);SRVR:VI1PR0501MB2703;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0501MB2703; X-Forefront-PRVS: 0748FF9A04 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(366004)(39860400002)(136003)(396003)(346002)(376002)(199004)(189003)(486006)(6496006)(39060400002)(107886003)(6246003)(53936002)(476003)(33656002)(2906002)(66066001)(47776003)(50466002)(76506005)(105586002)(106356001)(93886005)(97736004)(33896004)(6916009)(68736007)(1076002)(305945005)(478600001)(7736002)(16526019)(186003)(81166006)(6116002)(8676002)(3846002)(16586007)(81156014)(8936002)(9686003)(58126008)(316002)(53546011)(229853002)(26005)(6666003)(446003)(23726003)(6486002)(86362001)(76176011)(52116002)(11346002)(4326008)(25786009)(386003)(5660300001)(54906003)(956004)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2703;H:localhost;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0501MB2703;23:oE/iOYPte+LRjx6Up4OJ1OWrU4Vn4yGgijUnBVh?= =?us-ascii?Q?efPd2VlrIXeFegH3nPH4C9tdVkJA8SauvD/aB8Axbw7esCmBrnpQEastH84I?= =?us-ascii?Q?aXZsY178tJP/967Oq851RUMrOzE0Uv9mKEgjFDjMDbMOiAaVTjniU1OA+pAP?= =?us-ascii?Q?2mLQlnfIS2AFH/h6kRcZfxOImGjR5hyp4guNMlZrW2SQ7hA4cLjvs9SilcyZ?= =?us-ascii?Q?5R4DVi7EOXJafe1WQzgSF0VvFmCQUv2M28LoVDQ98Q+CNu+i7ukQfT7yxbDa?= =?us-ascii?Q?CRtv7Oiz0VCAyLcfcONozEskEfIL/qfCzAMFT4vrOrJ93ANpzee9ZPOkXtCT?= =?us-ascii?Q?4Ms6afvKQn0AbQ5C7VrDNKI6tMeW8a0fryyrLpFf5w27Y0Mo8aBYCojjwx/G?= =?us-ascii?Q?0YIe5YZAM8FSTDMhNd3OPrJAiug/UVX4hiFj3waK1uveAr1LS1NIWoyhcemi?= =?us-ascii?Q?/UedbOZED1HlDmslE6yLoe8FfalI6aSckT18MhlaShfZYiqwkSSyPJLLRO0c?= =?us-ascii?Q?SMen2LTJL0kuG/9zc0HXqdplrdvCszxwaS20H7RRnrHISYt6UztW7s/RfqY7?= =?us-ascii?Q?qb6p9XP8v4igeLXyyazXlsMjBLz8gsc4P60PhOOdr/xoM620zj8Xm82NBavf?= =?us-ascii?Q?vPiKkSNal4nG1adEqbEwiKNnB8nQJU9bRMYvcBzWt32mViBLwjbr6RK0FTNl?= =?us-ascii?Q?NH6BbZ3JbOEQIGCeiRGWLhOjRzvJfPama6orAuWK69zw311rZu9GQxfAwols?= =?us-ascii?Q?Nz8xxj+KdPwobopwKdw85eXrBoESEFG7fIcWXSIym0/K+qpWHA5AHlCZdztK?= =?us-ascii?Q?iUrgaBx2g0XGsWxODjyGNxgTgF5GO1oku4gcOmH6Do4t/v9V6FLzMgL4YyD9?= =?us-ascii?Q?w6VhM6L4pml4xLddHC16y9NAueiIVJOUzUBbgssHzbIumvlREWmH+e33OobZ?= =?us-ascii?Q?kKdAI+eVPJHc434kk59jhVXiFLqunkfGr/sdv9Ck2u5oSP5LaIEhX3CW7G+o?= =?us-ascii?Q?U4yARnpNkSvdnfjynmt3KmZM1G5ZqR8TIjgqYctcOzS4hXq0OIi7fQxC2IW7?= =?us-ascii?Q?oMCYLdztnO0ACxAdV+80R+0Kl2iUAy1CqyegwE1jBzLRdSRA7vh9Pu8ABOGy?= =?us-ascii?Q?nmoBcUz78q9ZjPv6dtSt/RVdXim/wQVhHU91UDF4zaguKt82/NgAtMrXfYuj?= =?us-ascii?Q?vF7mj8UMqNo3kiHNApcMiXsRLU4IAITtq+sXN05iVmrtuOadDW8E9+FZC51p?= =?us-ascii?Q?qKlxa2x6FCZZwwRHoCr7eKYlb9MTYoxFqhKWYgcV4wAxGdfQRhCDJBXrTarB?= =?us-ascii?Q?Ox36hrUbVKcMAOtbdOi1Qhfv/u8tJw0VBZrgSV5xv4Xo67M7oSsH6cjVHycZ?= =?us-ascii?Q?rdfBp52Y32OB/Dmn+fe8X+XXidww=3D?= X-Microsoft-Antispam-Message-Info: an/dDNa9tlDVFr8B632YC+VzS3qOZUTvANFWcJhC0j5YV6ZCOoZQHT6zLBftF/Rmzz/b6Tt2+9Dsx+ByOW1XRI9WRkQXaQBofKHicDpqiFyO+71HTZO9nCfno186lnWzyOsRf66xVnn70qJLYoWyfxE/firdtYU0waktV1C5yPJpObHU61SKgPO7zXg1Nz0fQLJ2WFcLoZGnp4OTNOupg8COMNGQgFjHwOIAMin4CLQfMepJyaAGs/JtRgM561HdwelA1HNxl1fi17Ud3MpxyM5l4IFdQ4UlIvVhUIKswyl8AaoUrjsC7UOhBOfbl/HPmOSDWgA/DxLB+wv0Ol1LdYORajfm65lDE/c+Jc26qK4= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2703;6:lUjhgaKyMZIoyRXOcXNZYI28j7wHRN0uAlUkjA2DiK2K+FaBzR1FBq3b66RtX+C0bp73ZYm9ZjnJNcwLoKK0l4nEP11MYQHeDszFG+c4Beuv62dhAJusj2sKmhQ4Ug3+FeDKSaNmczrGP0g6ExDl2bEKOl0IVTuWVabccQB5QVv74tAMtjWDUaASD6T35aLX1oO51B4FIgukgCP+J7dcymv4ggVUaWhVbaLc0h4hsWMlEwlqLaW8aYNar/9ycbg/JpKM/+uK9+FKCFXSrCU/sz8TVPY2t759tsY3LimJyQNEGrkNGGH4RJHoUC3vv6yDUKPEdvCKlAMbJW0Zsx8ElLcC8fLpZYiOZgjhAEck3xbEASnxdlzsAeduo7QWNoZuaus7ukaf+ezQ903plS+DkHugi3b2FfYqDhS7hj285oijW5eONfyNQoKoBxMAURZGAh4y7y8TWrKGPxcwpesrZA==;5:bUPZ0OOCvRLai2waTSccDUoyuqrDQpdgsTF+0IBvLSh7P/RSRGy0k3VOFeXShaKk3LSwKohgxPVp/BGtpqkRTvMw0h0+Dt0lhDIt4Vc4BfFHYEy/Ori8OhIWgG6jNfMjzwFHYvDs8y0jFI6s3Ztg9W708NCxRfTI9BsE1B5MLmA=;7:yrvlfchiA4oQan2swBcDlcKSQHPkF9seAwzRziNznIoOpL/0Zw+7DgaMZA7G6B2a6ySDvSz4AnWnShRJBDTCI2th/CB8cc7hDg0JTRj/0sUgd/FFxDZi1tGzEq8noAu2JR/MPT8PIZlddL5mmXH3NiNRksoa9zkIukNApCjM9KPp7thVrQ7FDi+UDvAXYUU2NUhX9uMIv9HhfjAP7RFjQpJ5VMPWfqmsuXo9Ix5+yjRe52NLiU3PYP+RFxfNzg1c SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2018 20:22:39.0835 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b519133-c332-4a16-f055-08d5f5910829 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2703 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 29, 2018 at 11:10:51AM -0700, Randy Dunlap wrote: > On 07/29/2018 12:01 AM, Leon Romanovsky wrote: > > On Thu, Jul 26, 2018 at 08:16:35PM -0700, rd_dunlab wrote: > >> From: Randy Dunlap > >> > >> Add to fix build errors. > >> Both ctop.h and use u32 types and cause many > >> errors. > >> > >> Examples: > >> ../include/soc/nps/common.h:71:4: error: unknown type name 'u32' > >> u32 __reserved:20, cluster:4, core:4, thread:4; > >> ../include/soc/nps/common.h:76:3: error: unknown type name 'u32' > >> u32 value; > >> ../include/soc/nps/common.h:124:4: error: unknown type name 'u32' > >> u32 base:8, cl_x:4, cl_y:4, > >> ../include/soc/nps/common.h:127:3: error: unknown type name 'u32' > >> u32 value; > >> > >> ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32' > >> u32 gen:1, gdis:1, clk_gate_dis:1, asb:1, > >> ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32' > >> u32 value; > >> ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32' > >> u32 csa:22, dmsid:6, __reserved:3, cs:1; > >> ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32' > >> u32 value; > >> > >> Signed-off-by: Randy Dunlap > >> Cc: Vineet Gupta > >> Cc: linux-snps-arc@lists.infradead.org > >> Cc: Elad Kanfi > >> Cc: Leon Romanovsky > >> Cc: Ofer Levi > >> --- > >> v2: no change > >> > >> arch/arc/plat-eznps/include/plat/ctop.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> --- linux-next-20180723.orig/arch/arc/plat-eznps/include/plat/ctop.h > >> +++ linux-next-20180723/arch/arc/plat-eznps/include/plat/ctop.h > >> @@ -21,6 +21,7 @@ > >> #error "Incorrect ctop.h include" > >> #endif > >> > >> +#include > > > > I'm not familiar with arch/* code, so maybe my question will sound > > naive., but why "asm-generic/types.h" and not "linux/types.h"? > > Nope, good question. That works and should be preferred. > > Please use the new patch below. > > -- > > From: Randy Dunlap > > Add to fix build errors. > Both ctop.h and use u32 types and cause many > errors. > > Examples: > ../include/soc/nps/common.h:71:4: error: unknown type name 'u32' > u32 __reserved:20, cluster:4, core:4, thread:4; > ../include/soc/nps/common.h:76:3: error: unknown type name 'u32' > u32 value; > ../include/soc/nps/common.h:124:4: error: unknown type name 'u32' > u32 base:8, cl_x:4, cl_y:4, > ../include/soc/nps/common.h:127:3: error: unknown type name 'u32' > u32 value; > > ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32' > u32 gen:1, gdis:1, clk_gate_dis:1, asb:1, > ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32' > u32 value; > ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32' > u32 csa:22, dmsid:6, __reserved:3, cs:1; > ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32' > u32 value; > > Signed-off-by: Randy Dunlap > Cc: Vineet Gupta > Cc: linux-snps-arc@lists.infradead.org > Cc: Elad Kanfi > Cc: Leon Romanovsky > Cc: Ofer Levi > --- > v2: no change > v3: use instead of > > arch/arc/plat-eznps/include/plat/ctop.h | 1 + > 1 file changed, 1 insertion(+) > Thanks, Reviewed-by: Leon Romanovsky