From: Greg KH <gregkh@linuxfoundation.org>
To: John Whitmore <johnfwhitmore@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
Date: Mon, 30 Jul 2018 11:11:38 +0200 [thread overview]
Message-ID: <20180730091138.GA22781@kroah.com> (raw)
In-Reply-To: <20180729210747.10803-2-johnfwhitmore@gmail.com>
On Sun, Jul 29, 2018 at 10:07:33PM +0100, John Whitmore wrote:
> Remove the typedef of the structure cmpk_txfb_t. This clears the
> checkpatch issue with defining new types.
>
> Additionally the type is renamed from cmpk_txfb_t to cmd_pkt_tx_feedback
> removing the '_t' as the typedef has been removed.
>
> These changes are purely coding style in nature and should have no
> impact on runtime code execution.
>
> Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> ---
> drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8 ++++----
> drivers/staging/rtl8192u/r819xU_cmdpkt.h | 6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> index 3140b3413f91..630cf612f265 100644
> --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> @@ -66,7 +66,7 @@ rt_status SendTxCommandPacket(struct net_device *dev, void *pData, u32 DataLen)
> * Overview:
> *
> * Input: PADAPTER pAdapter
> - * CMPK_TXFB_T *psTx_FB
> + * STRUCT CMD_PKT_TX_FEEDBACK *psTx_FB
nit, this should all be in lowercase now right?
Anyway, these function comments need to all go anyway, they are horrid :)
Something for future patches, look at the ones for the gasket driver
sent yesterday as an example of what to do.
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-30 9:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 21:07 [PATCH v2 00/15] staging:rtl8192u: Coding style changes John Whitmore
2018-07-29 21:07 ` [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style John Whitmore
2018-07-30 9:11 ` Greg KH [this message]
2018-07-30 18:43 ` John Whitmore
2018-07-29 21:07 ` [PATCH v2 02/15] staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE " John Whitmore
2018-07-29 21:07 ` [PATCH v2 03/15] staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE " John Whitmore
2018-07-29 21:07 ` [PATCH v2 04/15] staging:rtl8192u: Correct spelling in comments - style John Whitmore
2018-07-29 21:07 ` [PATCH v2 05/15] staging:rtl8192u: Remove typedef of cmpk_intr_sta_t - Style John Whitmore
2018-07-29 21:07 ` [PATCH v2 06/15] staging:rtl8192u: Remove typedef of cmpk_set_cfg_t " John Whitmore
2018-07-29 21:07 ` [PATCH v2 07/15] staging:rtl8192u: Refactor use of enum dm_dig_sta_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 08/15] staging:rtl8192u: Refactor enum dm_ratr_sta_e usage " John Whitmore
2018-07-29 21:07 ` [PATCH v2 09/15] staging:rtl8192u: Remove enum dm_dig_op_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 10/15] staging:rtl8192u: Refactor enum dm_dig_alg_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 11/15] staging:rtl8192u: Remove unused enum dm_dig_dbg_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 12/15] staging:rtl8192u: Refactor dm_dig_connect_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 13/15] staging:rtl8192u: Refactor enum dm_dig_pd_th_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 14/15] staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 15/15] staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method " John Whitmore
-- strict thread matches above, loose matches on Subject: below --
2018-07-29 21:05 [PATCH v2 00/15] staging:rtl8192u: Coding style changes John Whitmore
2018-07-29 21:05 ` [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730091138.GA22781@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.