From: Jiri Pirko <jiri@resnulli.us>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Eyal Birger <eyal.birger@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values
Date: Mon, 30 Jul 2018 16:21:55 +0200 [thread overview]
Message-ID: <20180730142155.GC10626@nanopsycho> (raw)
In-Reply-To: <f455f493-c106-aa93-b92a-2aa94c969d31@mojatatu.com>
Mon, Jul 30, 2018 at 04:03:50PM CEST, jhs@mojatatu.com wrote:
>On 30/07/18 08:30 AM, Paolo Abeni wrote:
>> }
>> + if (!tcf_action_valid(a->tcfa_action)) {
>> + NL_SET_ERR_MSG(extack, "invalid action value, using TC_ACT_UNSPEC instead");
>> + a->tcfa_action = TC_ACT_UNSPEC;
>> + }
>> +
>> return a;
>
>
>I think it would make a lot more sense to just reject the entry than
>changing it underneath the user to a default value. Least element of
>suprise.
It might break existing user who is incorrectly doing it. But I'm okay
with both solutions.
>
>cheers,
>jamal
next prev parent reply other threads:[~2018-07-30 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 12:30 [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection Paolo Abeni
2018-07-30 12:30 ` [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values Paolo Abeni
2018-07-30 12:36 ` Jiri Pirko
2018-07-30 14:03 ` Jamal Hadi Salim
2018-07-30 14:21 ` Jiri Pirko [this message]
2018-07-30 16:41 ` Paolo Abeni
2018-07-30 19:31 ` Jamal Hadi Salim
2018-07-31 9:41 ` Paolo Abeni
2018-07-31 13:53 ` Jamal Hadi Salim
2018-07-31 14:40 ` Paolo Abeni
2018-08-01 14:34 ` Jamal Hadi Salim
2018-07-30 12:30 ` [PATCH net-next v5 2/4] tc/act: remove unneeded RCU lock in action callback Paolo Abeni
2018-07-30 12:30 ` [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT Paolo Abeni
2018-07-30 12:40 ` Jiri Pirko
2018-07-30 16:31 ` David Miller
2018-07-30 16:49 ` Jiri Pirko
2018-07-30 16:56 ` David Miller
2018-07-30 12:30 ` [PATCH net-next v5 4/4] act_mirred: use TC_ACT_REINSERT when possible Paolo Abeni
2018-07-30 12:42 ` Jiri Pirko
2018-07-30 16:31 ` [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730142155.GC10626@nanopsycho \
--to=jiri@resnulli.us \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eyal.birger@gmail.com \
--cc=jhs@mojatatu.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.