Re: [PATCH 1/4] travis: build against multiple kernel versions

[Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>]

On Mon, Jul 30, 2018 at 07:50:17AM -0400, Neil Horman wrote:
> On Sat, Jul 28, 2018 at 07:31:20PM -0300, Marcelo Ricardo Leitner wrote:
> > With recent changes, configure is probing for kernel features before
> > enabling them in the library.
> > 
> > Now with this change, travis-ci will build the library against several
> > different kernels, allowing a better CI.
> > 
> > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> > ---
> > 
> > The comments in linux-build.sh are intentional. Place holders for next
> > steps.
> > 
> >  .travis.yml            | 17 ++++++++++++-----
> >  .travis/linux-build.sh | 43 ++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 55 insertions(+), 5 deletions(-)
> >  create mode 100755 .travis/linux-build.sh
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index 75d07aa0640d73d12321231ecce18aa407ce15f4..c0fb7c68c4977c7185cd05df1b88b6d552cfa59f 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -1,10 +1,17 @@
> >  language: c
> > +addons:
> > +  apt:
> > +    packages:
> > +      - libelf-dev
> >  script:
> > -  - ./bootstrap
> > -    && ./configure
> > -    && make -j `/usr/bin/getconf _NPROCESSORS_ONLN`
> > -  # ipv6 is not supported by Travis
> > -  - make -C src/func_tests/ v4test
> > +  - ./.travis/linux-build.sh
> > +env:
> > +  - KERNEL=4.10
> > +  - KERNEL=4.11
> > +  - KERNEL=4.12
> > +  - KERNEL=4.13
> > +  - KERNEL=4.16
> > +  - KERNEL=4.17
> >  compiler:
> >    - gcc
> >    - clang
> > diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
> > new file mode 100755
> > index 0000000000000000000000000000000000000000..e1874f3e16fb86ab86d7796b6c807b791b584e95
> > --- /dev/null
> > +++ b/.travis/linux-build.sh
> > @@ -0,0 +1,43 @@
> > +#!/bin/bash
> > +
> > +set -ex
> Did you mean to keep this in here?  I can understand the -e since this is for

Yes,

> travis ci testing, but -x seems like its just going to generate alot of noise.

but it's not much. There is no loop and it doesn't get propagated to
what the script is calling, so it prints pretty much the same number
of code lines, as debug lines.

As is it helps on identifying which command outputted what, instead of
adding specific echo commands.

Thx,
  Marcelo